Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763623AbXLMSmd (ORCPT ); Thu, 13 Dec 2007 13:42:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756047AbXLMSmX (ORCPT ); Thu, 13 Dec 2007 13:42:23 -0500 Received: from palinux.external.hp.com ([192.25.206.14]:56808 "EHLO mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754201AbXLMSmW (ORCPT ); Thu, 13 Dec 2007 13:42:22 -0500 Date: Thu, 13 Dec 2007 11:42:21 -0700 From: Matthew Wilcox To: Mark Lord Cc: Jens Axboe , IDE/ATA development list , Linux Kernel , linux-scsi , James Bottomley Subject: Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ? Message-ID: <20071213184221.GP26334@parisc-linux.org> References: <47617B92.6020908@rtr.ca> <47617C07.3020501@rtr.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47617C07.3020501@rtr.ca> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1446 Lines: 31 On Thu, Dec 13, 2007 at 01:37:59PM -0500, Mark Lord wrote: > The problem is, the block layer *never* sends an SG entry larger than 8192 > bytes, > and even that size is exceptionally rare. Nearly all I/O segments are 4096 > bytes, > so I never see a single I/O larger than 512KB (128 * 4096). > > If I patch various parts of block and SCSI, this limit doesn't budge, > but when I change the hardware PRD limit in libata, it scales by exactly > whatever I set the new value to. This tells me that adjacent I/O segments > are not being combined. > > I thought that QUEUE_FLAG_CLUSTER (aka. SCSI host .use_clustering=1) should > result in adjacent single pages being combined into larger physical > segments? I was recently debugging a driver and noticed that consecutive pages in an sg list are in the reverse order. ie first you get page 918, then 917, 916, 915, 914, etc. I vaguely remember James having patches to correct this, but maybe they weren't merged? -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/