Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp2703004rdd; Fri, 12 Jan 2024 20:54:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IHU9fqlZTnw7xIbh7QCvR69VxyvoGnKil/3CE8Qxp57V7xuXnstbmsVCweXbr7i/yyvCM23 X-Received: by 2002:a92:c942:0:b0:35f:e9c4:7051 with SMTP id i2-20020a92c942000000b0035fe9c47051mr2264216ilq.95.1705121658500; Fri, 12 Jan 2024 20:54:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705121658; cv=none; d=google.com; s=arc-20160816; b=mSLwNCKoc67JAPtbXBsrCofYGyTQZmCSWb57LI0onMUUaZzDE8T+Fad1r6oFvFQDl2 /JxF6VaitkC+VTRTWDgIj1M9HvWdKhbc04vZJU8lrk1ANBt6YDfOdwJkQoHuNcAKo6h8 RHnQ49eXlLxhUzqjay+UFeMRhxoerJgHTXQKN+U778ChV6Bp8uAA0GF0QRyX+i9b3U/c VAFLkcHSD5aCSAj7tRA1SSv4CJKWEk2pTi3C3AuNlZA6cRS7FS/OF6s9Kq1uL8oxinX+ W6i8abYQLQJrsp7DvmXIanCxXy9/evQEdoOJzbjjOA/ShnaNMAMWbTPgBo+UUwrv97aB K20Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=HyhhtLBlwuT0db1cYCnecKMxo/jq/0bSomGEhxEpXvw=; fh=iC0LeWTtFXfmi/Bq4YP3Z8pNDcOwr7Ci/il68BugYyk=; b=YLz/slYCwgmdEhqg1oU3PLpW+tg+7uSbMEcXSi4/i5sl6nI2o7hfIJvPF8SQiTl8l4 Xo5fQAfoZAus4B4C0OMkzK7ZohvQyeecu49HfJl0bV/BtQk4EmluNYnR9VbIjXzLPEnJ Tax7pEffvSkbnsJG3P6PW1lApdCdIQLSbE9wjoXGDMBfN+qABBt3ECGiusjveTWI6jwu uiuB1fky7no9N1frfCA92ksrQ3qB/VXua/nXnmOleYxvCPw00AZ1li4WHMiJpj5l+iP+ Uv0sYPztimMJVjhpU+UOEB45ixuyB8tJMZiBh73aRj5UmbGmrFuneuVIdwl6RQVpGX0g B7oA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=WypgN0AS; spf=pass (google.com: domain of linux-kernel+bounces-25196-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-25196-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id jd10-20020a170903260a00b001d523500201si4462645plb.12.2024.01.12.20.54.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jan 2024 20:54:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-25196-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=WypgN0AS; spf=pass (google.com: domain of linux-kernel+bounces-25196-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-25196-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id A371C284CD3 for ; Sat, 13 Jan 2024 04:54:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6A58CF510; Sat, 13 Jan 2024 04:54:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="WypgN0AS" Received: from mail-oo1-f46.google.com (mail-oo1-f46.google.com [209.85.161.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 442C9FBE7 for ; Sat, 13 Jan 2024 04:54:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-oo1-f46.google.com with SMTP id 006d021491bc7-5989e17b01fso1800806eaf.1 for ; Fri, 12 Jan 2024 20:54:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1705121648; x=1705726448; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HyhhtLBlwuT0db1cYCnecKMxo/jq/0bSomGEhxEpXvw=; b=WypgN0AS6Gb78YKgNiTH5rOJBw9THj+eXva0jvZgze7AGKu4R/kKH0aqu5leUbGZIt rGI3M9ui3yQMLXhJpusOIx4BBvBdb0dVFw8NXhyNpHw8ja/1lPGcXFhgAamjTDdyivuI TDvdOlPGXAR63SQOV6Zj6YfaBo/waWrXwxsf8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705121648; x=1705726448; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HyhhtLBlwuT0db1cYCnecKMxo/jq/0bSomGEhxEpXvw=; b=ksD4tmUBVhB5MthXpVEdSLYth6BAFwQahaf1NFh8pi64dF3JR25wY60mqH2QPDB91F S9gPDpbzhjYL0yIMkX7GhKkxLIcCxeewUGF3LoVCDx9MYrv9uZ/D5uanLMNfg/EKI/ra KWny2UPM8Uvm7d36s5GD639m5rsgDhNA42zbQTOUoa5dfb5ewCG23GMI8pgoT3UF/C0t aunChKwqL3iNL+NhC1blXbDgSyfDdXhgGJPVCsYXEuLdTKw3JIBzokNvSo7AwRIjkuAD 4KTJuMHdAlOJFd8NzEmw8TRiFGEKuMtY+e3B/zL6hSIF7J/KVE5jTEcFqNYg6x77zqKC PrnA== X-Gm-Message-State: AOJu0Yy7tB9GxLg0a8FV+sq84OqMK5ab0xgtHWdvKlIjiHKfFOTFpRmI uuUg707QKFKJb48H9ITbgBW17LleAdqSAd2yfOsOnkgSvehM X-Received: by 2002:a05:6870:9a1b:b0:206:bd2a:b222 with SMTP id fo27-20020a0568709a1b00b00206bd2ab222mr2104109oab.72.1705121648191; Fri, 12 Jan 2024 20:54:08 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240111234142.2944934-1-jeffxu@chromium.org> In-Reply-To: From: Jeff Xu Date: Fri, 12 Jan 2024 20:53:57 -0800 Message-ID: Subject: Re: [PATCH v6 0/4] Introduce mseal() To: Randy Dunlap Cc: akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com, sroettger@google.com, willy@infradead.org, gregkh@linuxfoundation.org, torvalds@linux-foundation.org, usama.anjum@collabora.com, jeffxu@google.com, jorgelo@chromium.org, groeck@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, pedro.falcato@gmail.com, dave.hansen@intel.com, linux-hardening@vger.kernel.org, deraadt@openbsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Jan 12, 2024 at 6:20=E2=80=AFPM Randy Dunlap wrote: > > > > On 1/11/24 15:41, jeffxu@chromium.org wrote: > > From: Jeff Xu > > > > This patchset proposes a new mseal() syscall for the Linux kernel. > > > > Jeff, > Building arm64 defconfig, on linux-next-20240112, I get: > I don't quite get how this is related to my change. Can you please send me the steps to reproduce ? I don't usually build arm. Thanks -Jeff > CC arch/arm64/kernel/asm-offsets.s > In file included from ../include/uapi/linux/mman.h:5, > from ../include/linux/mm.h:33, > from ../include/linux/memblock.h:12, > from ../arch/arm64/include/asm/acpi.h:14, > from ../include/acpi/acpi_io.h:7, > from ../include/linux/acpi.h:39, > from ../include/acpi/apei.h:9, > from ../include/acpi/ghes.h:5, > from ../include/linux/arm_sdei.h:8, > from ../arch/arm64/kernel/asm-offsets.c:10: > ../arch/arm64/include/asm/mman.h: In function 'arch_calc_vm_prot_bits': > ../arch/arm64/include/asm/mman.h:15:24: error: 'VM_ARM64_BTI' undeclared = (first use in this function); did you mean 'ARM64_BTI'? > 15 | ret |=3D VM_ARM64_BTI; > | ^~~~~~~~~~~~ > | ARM64_BTI > ../arch/arm64/include/asm/mman.h:15:24: note: each undeclared identifier = is reported only once for each function it appears in > ../arch/arm64/include/asm/mman.h:18:24: error: 'VM_MTE' undeclared (first= use in this function); did you mean 'VM_MAP'? > 18 | ret |=3D VM_MTE; > | ^~~~~~ > | VM_MAP > ../arch/arm64/include/asm/mman.h: In function 'arch_calc_vm_flag_bits': > ../arch/arm64/include/asm/mman.h:32:24: error: 'VM_MTE_ALLOWED' undeclare= d (first use in this function) > 32 | return VM_MTE_ALLOWED; > | ^~~~~~~~~~~~~~ > ../arch/arm64/include/asm/mman.h: In function 'arch_validate_flags': > ../arch/arm64/include/asm/mman.h:59:29: error: 'VM_MTE' undeclared (first= use in this function); did you mean 'VM_MAP'? > 59 | return !(vm_flags & VM_MTE) || (vm_flags & VM_MTE_ALLOWED= ); > | ^~~~~~ > | VM_MAP > ../arch/arm64/include/asm/mman.h:59:52: error: 'VM_MTE_ALLOWED' undeclare= d (first use in this function) > 59 | return !(vm_flags & VM_MTE) || (vm_flags & VM_MTE_ALLOWED= ); > | ^~~~~~~~~~~~~~ > > > -- > #Randy