Received-SPF: pass (google.com: domain of linux-kernel+bounces-25271-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20231228054630.3595093-1-tfiga@chromium.org> <CAK7LNATBipJtprjvvRVYg8JcYOFXQdpLEyEc+4+8j1PtBQ+PUg@mail.gmail.com>
 <CAAFQd5C3vAUJhKiQ1LPkZv3dJxNvK4QinRezV9Q8rz_Ov6FSUQ@mail.gmail.com>
In-Reply-To: <CAAFQd5C3vAUJhKiQ1LPkZv3dJxNvK4QinRezV9Q8rz_Ov6FSUQ@mail.gmail.com>
From: Masahiro Yamada <masahiroy@kernel.org>
Date: Sat, 13 Jan 2024 20:22:25 +0900
Message-ID: <CAK7LNAQcaDneE4rnjvV+GTSBBMozm5deu_q9+STTn60ervZJbA@mail.gmail.com>
Subject: Re: [PATCH] kconfig: menuconfig: Make hidden options show as dim
To: Tomasz Figa <tfiga@chromium.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Jesse Taube <Mr.Bossman075@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Jan 10, 2024 at 10:05=E2=80=AFPM Tomasz Figa <tfiga@chromium.org> w=
rote:
>
> On Fri, Dec 29, 2023 at 1:10=E2=80=AFAM Masahiro Yamada <masahiroy@kernel=
org> wrote:
> >
> > On Thu, Dec 28, 2023 at 2:46=E2=80=AFPM Tomasz Figa <tfiga@chromium.org=
> wrote:
> > >
> > > When hidden options are toggled on (using 'z'), the number of options
> > > on the screen can be overwhelming and may make it hard to distinguish
> > > between available and hidden ones. Make them easier to distinguish by
> > > displaying the hidden one as dim (using the A_DIM curses attribute).
> > >
> > > Signed-off-by: Tomasz Figa <tfiga@chromium.org>
> >
> >
> >
> > Do you think this is useful?
> >
> > This changes the color only when you select a hidden item.
> >
> >
> > For unselected items, you cannot distinguish hidden ones,
> > as A_DIM has no effect to black text.
> >
> >
>
> Hmm, are you sure about that? For me it seems to dim the text. it
> seems to be also used in the existing code for dlg.button_inactive.atr
> of the mono theme:
>
> https://elixir.bootlin.com/linux/latest/source/scripts/kconfig/lxdialog/u=
til.c#L26


Then, your code works only on the mono theme.
(when your terminal does not support color, or
"MENUCONFIG_COLOR=3Dmono make menuconfig")


In the normal color mode, the foreground text is black.
(Just like a picture in https://en.wikipedia.org/wiki/Menuconfig)
A_DIM does nothing for black.


--=20
Best Regards
Masahiro Yamada