Received-SPF: pass (google.com: domain of linux-kernel+bounces-25321-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Sat, 13 Jan 2024 15:26:43 +0000
From: Jonathan Cameron <jic23@kernel.org>
To: Nuno =?UTF-8?B?U8Oh?= <noname.nuno@gmail.com>
Cc: David Lechner <dlechner@baylibre.com>, linux-iio@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: core: use INDIO_ALL_BUFFER_MODES in
 iio_buffer_enabled()
Message-ID: <20240113152643.242c5fd5@jic23-huawei>
In-Reply-To: <d927b0b761eb7105d2193d9dca48f2c6df8868b7.camel@gmail.com>
References: <20240108200647.3916681-1-dlechner@baylibre.com>
	<d927b0b761eb7105d2193d9dca48f2c6df8868b7.camel@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Tue, 09 Jan 2024 15:07:57 +0100
Nuno S=C3=A1 <noname.nuno@gmail.com> wrote:

> On Mon, 2024-01-08 at 14:06 -0600, David Lechner wrote:
> > This replaces use of individual buffer mode flags with
> > INDIO_ALL_BUFFER_MODES in the iio_buffer_enabled() function.
> >=20
> > This simplifies the code and makes it robust in case of the addition of
> > new buffer modes.
> >=20
> > Signed-off-by: David Lechner <dlechner@baylibre.com>
> > --- =20
>=20
> LGTM,
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
Applied to the togreg branch of iio.git and pushed out as testing for all t=
he
normal reasons.

>=20
> > =C2=A0drivers/iio/industrialio-core.c | 4 +---
> > =C2=A01 file changed, 1 insertion(+), 3 deletions(-)
> >=20
> > diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio=
-core.c
> > index c77745b594bd..8855d377d710 100644
> > --- a/drivers/iio/industrialio-core.c
> > +++ b/drivers/iio/industrialio-core.c
> > @@ -210,9 +210,7 @@ bool iio_buffer_enabled(struct iio_dev *indio_dev)
> > =C2=A0{
> > =C2=A0	struct iio_dev_opaque *iio_dev_opaque =3D to_iio_dev_opaque(indi=
o_dev);
> > =C2=A0
> > -	return iio_dev_opaque->currentmode &
> > -	=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (INDIO_BUFFER_HARDWARE | INDIO_B=
UFFER_SOFTWARE |
> > -		INDIO_BUFFER_TRIGGERED);
> > +	return iio_dev_opaque->currentmode & INDIO_ALL_BUFFER_MODES;
> > =C2=A0}
> > =C2=A0EXPORT_SYMBOL_GPL(iio_buffer_enabled);
> > =C2=A0 =20
>=20