Received-SPF: pass (google.com: domain of linux-kernel+bounces-25393-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240111234142.2944934-1-jeffxu@chromium.org> <20240111234142.2944934-3-jeffxu@chromium.org>
 <202401131146.F017DB5870@keescook>
In-Reply-To: <202401131146.F017DB5870@keescook>
From: Jeff Xu <jeffxu@chromium.org>
Date: Sat, 13 Jan 2024 19:48:46 -0800
Message-ID: <CABi2SkXrUm-oa7bZBxFGHdL6qknAeD0OkLio2vniJw=YgDXQaA@mail.gmail.com>
Subject: Re: [PATCH v6 2/4] mseal: add mseal syscall
To: Kees Cook <keescook@chromium.org>
Cc: rdunlap@infradead.org, akpm@linux-foundation.org, jannh@google.com, 
	sroettger@google.com, willy@infradead.org, gregkh@linuxfoundation.org, 
	torvalds@linux-foundation.org, usama.anjum@collabora.com, jeffxu@google.com, 
	jorgelo@chromium.org, groeck@chromium.org, linux-kernel@vger.kernel.org, 
	linux-kselftest@vger.kernel.org, linux-mm@kvack.org, pedro.falcato@gmail.com, 
	dave.hansen@intel.com, linux-hardening@vger.kernel.org, deraadt@openbsd.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, Jan 13, 2024 at 11:48=E2=80=AFAM Kees Cook <keescook@chromium.org> =
wrote:
>
> On Thu, Jan 11, 2024 at 11:41:39PM +0000, jeffxu@chromium.org wrote:
> > diff --git a/include/linux/mm.h b/include/linux/mm.h
> > index f5a97dec5169..345667583b03 100644
> > --- a/include/linux/mm.h
> > +++ b/include/linux/mm.h
> > @@ -30,6 +30,7 @@
> >  #include <linux/kasan.h>
> >  #include <linux/memremap.h>
> >  #include <linux/slab.h>
> > +#include <uapi/linux/mman.h>
>
> I think the arm64 build failure is from this include -- it's happening
> too early and some of the arm defines aren't available yet?
>
good point, I will try fixing it.
Thanks!
-Jeff

> -Kees
>
> --
> Kees Cook