Received-SPF: pass (google.com: domain of linux-kernel+bounces-25412-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Sun, 14 Jan 2024 15:18:27 +0800
From: Yue Hu <zbestahu@gmail.com>
To: Gao Xiang <hsiangkao@linux.alibaba.com>
Cc: linux-erofs@lists.ozlabs.org, Yue Hu <huyue2@coolpad.com>,
 bugreport@ubisectech.com, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] erofs: fix inconsistent per-file compression format
Message-ID: <20240114151827.000069d6.zbestahu@gmail.com>
In-Reply-To: <20240113150602.1471050-1-hsiangkao@linux.alibaba.com>
References: <20231227050633.1507448-1-hsiangkao@linux.alibaba.com>
	<20240113150602.1471050-1-hsiangkao@linux.alibaba.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Sat, 13 Jan 2024 23:06:02 +0800
Gao Xiang <hsiangkao@linux.alibaba.com> wrote:

> EROFS can select compression algorithms on a per-file basis, and each
> per-file compression algorithm needs to be marked in the on-disk
> superblock for initialization.
> 
> However, syzkaller can generate inconsistent crafted images that use
> an unsupported algorithmtype for specific inodes, e.g. use MicroLZMA
> algorithmtype even it's not set in `sbi->available_compr_algs`.  This
> can lead to an unexpected "BUG: kernel NULL pointer dereference" if
> the corresponding decompressor isn't built-in.
> 
> Fix this by checking against `sbi->available_compr_algs` for each
> m_algorithmformat request.  Incorrect !erofs_sb_has_compr_cfgs preset
> bitmap is now fixed together since it was harmless previously.
> 
> Reported-by: <bugreport@ubisectech.com>
> Fixes: 8f89926290c4 ("erofs: get compression algorithms directly on mapping")
> Fixes: 622ceaddb764 ("erofs: lzma compression support")
> Reviewed-by: Yue Hu <huyue2@coolpad.com>
> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>

LGTM.

Reviewed-by: Yue Hu <huyue2@coolpad.com>