DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:references:mime-version:content-type:content-disposition:content-transfer-encoding:in-reply-to:user-agent;
        b=jrrcyBn7kLgzCpyEof/BgXjqeI+rNb1HSC/qr5coxrVAP1v1X82x37nwxlTxTKA+krL4mbBNY6xcSd2MZ9teYmnGZ/lHrQ672eDmQrGnk1tTzcevep/hz0TsIaW1lLnPFaEr27DpmuhlcknVqL5x/y3Pe4hOJ2IbIVd5a2NDS2A=
Date: Thu, 13 Dec 2007 20:50:46 +0100
From: Marcin =?utf-8?Q?=C5=9Alusarz?= <marcin.slusarz@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Antonino Daplas <adaplas@gmail.com>,
       linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [PATCH] logo: move declarations of logos to linux_logo.h
Message-ID: <20071213195040.GA8016@joi>
References: <20071209214027.GG9440@joi> <20071213023111.30ddc487.akpm@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20071213023111.30ddc487.akpm@linux-foundation.org>
User-Agent: Mutt/1.5.16 (2007-06-09)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1107
Lines: 24

On Thu, Dec 13, 2007 at 02:31:11AM -0800, Andrew Morton wrote:
> On Sun, 9 Dec 2007 22:40:31 +0100 Marcin Ślusarz <marcin.slusarz@gmail.com> wrote:
>
> > logo: move declarations of logos to linux_logo.h
> >
> > there was a mismatch between externs in logo.c and code generated by pnmtologo
> > (on old tree, you need to rm drivers/video/logo/logo_*.c before compilation)
>
> This patch (after I fixed it) keeps on causing trouble: mismatches between
> the header file declarations and the actual definitions of the lookup
> tables.  This happens as I apply and unapply the patch.
>
> It _shouldn't_ happen, but there would appear to be some missing makefile
> rules.  I guess the C files aren't being regenerated when
> scripts/pnmtologo.c has been altered, so the C files aren't matching the
> header which this patch alters.
Ok, I'll try to fix that.

Marcin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/