Received-SPF: pass (google.com: domain of linux-kernel+bounces-25470-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Sun, 14 Jan 2024 15:42:39 +0200
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org,
	linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	christophe.jaillet@wanadoo.fr, David.Laight@aculab.com,
	ddiss@suse.de, geert@linux-m68k.org
Subject: Re: [PATCH v3 0/4] kstrtox: introduce memparse_safe()
Message-ID: <ZaPkz7gU42Eahf4L@smile.fi.intel.com>
References: <cover.1704324320.git.wqu@suse.com>
 <ZZllAi_GbsoDF5Eg@smile.fi.intel.com>
 <7708fc8b-738c-4d58-b89e-801ce6a4832a@gmx.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7708fc8b-738c-4d58-b89e-801ce6a4832a@gmx.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Sun, Jan 07, 2024 at 07:28:27AM +1030, Qu Wenruo wrote:
> On 2024/1/7 01:04, Andy Shevchenko wrote:
> > On Thu, Jan 04, 2024 at 09:57:47AM +1030, Qu Wenruo wrote:

..

> > Having test cases is quite good, thanks!
> > But as I understood what Alexey wanted, is not using the kstrtox files for this.
> > You can introduce it in the cmdline.c, correct? Just include local "kstrtox.h".
> 
> Not really possible, all the needed parsing helpers are internal inside
> kstrtox.c.

I'm not sure I follow. The functions are available to other library (built-in)
modules.

> Furthermore, this also means memparse() can not be enhanced due to:
> 
> - Lack of ways to return errors

What does this mean?

> - Unable to call the parsing helpers inside cmdline.c

??? (see above)

-- 
With Best Regards,
Andy Shevchenko