Received-SPF: pass (google.com: domain of linux-kernel+bounces-25529-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Sun, 14 Jan 2024 13:59:36 -0500
From: Sasha Levin <sashal@kernel.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Mario Limonciello <mario.limonciello@amd.com>,
	Marcus Aram <marcus+oss@oxar.nl>,
	Mark Herbert <mark.herbert42@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>, Basavaraj.Natikar@amd.com,
	Shyam-sundar.S-k@amd.com, linux-gpio@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 4.14 3/6] pinctrl: amd: Mask non-wake source pins
 with interrupt enabled at suspend
Message-ID: <ZaQvGNNPpgZ5VCfa@sashalap>
References: <20231226002725.7471-1-sashal@kernel.org>
 <20231226002725.7471-3-sashal@kernel.org>
 <ZZ0xX2Mqx0ezfoWG@duo.ucw.cz>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <ZZ0xX2Mqx0ezfoWG@duo.ucw.cz>

On Tue, Jan 09, 2024 at 12:43:27PM +0100, Pavel Machek wrote:
>Hi!
>
>> From: Mario Limonciello <mario.limonciello@amd.com>
>>
>> [ Upstream commit 2fff0b5e1a6b9c577b4dd4958902c877159c856b ]
>>
>> If a pin isn't marked as a wake source processing any interrupts is
>> just going to destroy battery life.  The APU may wake up from a hardware
>> sleep state to process the interrupt but not return control to the OS.
>>
>> Mask interrupt for all non-wake source pins at suspend. They'll be
>> re-enabled at resume.
>
>Not sure what is going on here, but it is queued for 6.6 and 4.14, but
>not for the kernels between them.

Ack, it should have been dropped from 4.14. Thanks!

-- 
Thanks,
Sasha