Received: by 2002:a05:7412:8d11:b0:fa:4934:9f with SMTP id bj17csp313282rdb; Sun, 14 Jan 2024 19:24:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IHvrQUdMXSn845kwgT/5/M0q1KMSsbXpYm6OWjVt89uMPGaEvmlyE5GH8fjQu1hJTjIW4Zn X-Received: by 2002:a05:620a:a5d:b0:783:53f2:8558 with SMTP id j29-20020a05620a0a5d00b0078353f28558mr3099502qka.87.1705289044806; Sun, 14 Jan 2024 19:24:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705289044; cv=none; d=google.com; s=arc-20160816; b=G5Ugxc7wMDf8w0szvHQ/Wjs3/c8lWXmHKKJaJjHyUjgUoCIY1MkWwx+awzFKMtaneJ HVgtTT04haZRfWoJBIAj/RSBlgYc6jLw3ySgQPdpRaAwSS3cbsoz+kuC3x4RALps6fWu v5XOUCCddDXs1gWueVXU9u+hTn5wTT7i9Fihd57MhVwxQGAlcLN3t87lxWhoqR81LLJp LyNEz2Rma1AGNtXfovKenOZmgXE9p1FFN8KN0amIGDE/BpOc8Jcad7P7h8Hc1VLMDtxT G0KfSQPHi9sVHyh38Howz1wFaOoKYIR36jVmgVEGaaaWKNyYI32KeOZZORYIJZXQ6QGG i2mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=zV0pvOnK/qtk5NvR24f+LdLTt7kPH5uRjJyapwSsLlo=; fh=SK3RslGnOoK0KpZkXW1HCoOc+vb2Tq7UT3D3rEMIJEY=; b=0/yN63us7e2oMbh088QzLTFVy4nJN74VsDxTYr+27gv4tnZfH9Kbk6qe/0Ccbo0Yaa 8q6EjAS0Dk437W1uIRKlCAO5Yzg0d9BGmT/2Nvhz8c7HJiiVirc7auoKDvJDoXwAtjbQ FizoNU8mg0xLlDsXS1k42GerNmdmfX1D6EzW5Rp+WWbq8QtKBIBWy9kUs4+h5Yx4U45+ eYNN2vZd8wP4NN5dXBQullqr0V6jgu3b6UUX4dHNfVEDQsVWjdQpc5TTk978yk4kN7iz Z7nrzoMA5D77biJ3k24XeWWmrwTodrFD9JKRqes2acRK1xzLlXWEDjsQCjy7A+M2j8z6 ZiOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UwzluulG; spf=pass (google.com: domain of linux-kernel+bounces-25603-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-25603-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id pe25-20020a05620a851900b00783390ed3cdsi7186709qkn.707.2024.01.14.19.24.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Jan 2024 19:24:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-25603-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UwzluulG; spf=pass (google.com: domain of linux-kernel+bounces-25603-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-25603-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 8307D1C20C8D for ; Mon, 15 Jan 2024 03:24:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CAC7A20E6; Mon, 15 Jan 2024 03:23:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UwzluulG" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EED061842; Mon, 15 Jan 2024 03:23:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60AFAC433F1; Mon, 15 Jan 2024 03:23:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705289032; bh=zVQ4Atjg+ZZXRw35BNYzt6eRLBSNn7IT89ZOhNOYHh0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=UwzluulGpswDZu/e/NAeK7k8IsGLqOyBFpxkP29pXfVmi3Gvn569ub7FRhMyIkvR5 OSVn7a5b374DCez11xZDXpO1LP8TYoHr6lD++TEr+mff353sDc7PDMNeQQDJc290QM entoRdaDOiiXRFcvNtqIiUnTV+YWgbtgOn37a6EsumFPNbHt9iuwm+6R2LZ1uBQ2hi 6REjtiyVNU9O3sLbDmEqpOWpb1NV0KoMD9zd6uRGInRnxkkTHZrscQUtNMpbUCmp+8 yhr++pD2YQjWMheSxxlYWcGvCyzJeXYCvO3n9JQgQqMr3h6YKWbZdmf/pbgAbivxqz EscAFqJ2iF1eQ== Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a26f73732c5so952027266b.3; Sun, 14 Jan 2024 19:23:52 -0800 (PST) X-Gm-Message-State: AOJu0YxfZCiyuKrtvqQaAjiKXjGThe7SNMZMtf5kXcCxiCfdkpap/eZw ++R+897FXflm4fMWk7CNs4ATXX+mhqvwuxjP+k0= X-Received: by 2002:a17:907:9515:b0:a28:88d6:5d9c with SMTP id ew21-20020a170907951500b00a2888d65d9cmr2067170ejc.131.1705289030867; Sun, 14 Jan 2024 19:23:50 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240108032117.215171-1-wangrui@loongson.cn> In-Reply-To: From: Huacai Chen Date: Mon, 15 Jan 2024 11:23:41 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 0/2] Rust enablement for LoongArch To: Miguel Ojeda Cc: WANG Rui , Boqun Feng , Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Jonathan Corbet , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , WANG Xuerui , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linux-doc@vger.kernel.org, loongson-kernel@lists.loongnix.cn Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Miguel, On Sun, Jan 14, 2024 at 11:44=E2=80=AFPM Miguel Ojeda wrote: > > On Thu, Jan 11, 2024 at 4:16=E2=80=AFAM WANG Rui wr= ote: > > > > 6.8 > > Thanks, that is quite expedited... > > Please `rustfmt` the code to avoid failing the `rustfmtcheck` target. > I see you already created the 6.8 tag but I have not seen it in > linux-next yet and you did not send the PR, so it would be ideal if > you could fix this before it goes to Linus. > > diff --git a/scripts/generate_rust_target.rs b/scripts/generate_rust_targ= et.rs > index 3edda6a10..0da52b548 100644 > --- a/scripts/generate_rust_target.rs > +++ b/scripts/generate_rust_target.rs > @@ -163,10 +163,7 @@ fn main() { > ts.push("target-pointer-width", "64"); > } else if cfg.has("LOONGARCH") { > ts.push("arch", "loongarch64"); > - ts.push( > - "data-layout", > - "e-m:e-p:64:64-i64:64-i128:128-n64-S128", > - ); > + ts.push("data-layout", "e-m:e-p:64:64-i64:64-i128:128-n64-S128")= ; > ts.push("features", "-f,-d"); > ts.push("llvm-target", "loongarch64-linux-gnusf"); > ts.push("llvm-abiname", "lp64s"); > > Thanks! Thank you for your suggestion, but since this will be replaced by the built-in target soon, and I don't want to change the tag to make Linus unhappy. Let's leave it as is. Huacai > > Cheers, > Miguel