Received: by 2002:a05:7412:8d11:b0:fa:4934:9f with SMTP id bj17csp354570rdb; Sun, 14 Jan 2024 22:00:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IHuR6vld8vDyijUaVodtB+N8yJ35F1oD+ImMXKIwkBWDw76sk5cw3c3G4qoYxOc4DM5oXWH X-Received: by 2002:a05:6358:c614:b0:175:50d8:ae2b with SMTP id fd20-20020a056358c61400b0017550d8ae2bmr1501641rwb.37.1705298434565; Sun, 14 Jan 2024 22:00:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705298434; cv=none; d=google.com; s=arc-20160816; b=AD/LxIxZZh+zsWwjRTXF5xUCyBTsJO0MAnuk/QszX5n3N/pBAXI3mWOwSCjuq1GNsF WWMaK+n90v1jmnNcc9d3GX6X3G41Ernh6+tTOedUZ+ES+PYDgaepcz9Rc4rfCvEIjpfx CNZmT0Pbw1lAJbdwZoT1MgsnAxen3IIpWOn5qf5fJoVGE1U+kvmoWAexbyBjikU1Ap5k 7vTzkIMQN8jYc4/ACV5JM19Iu6MsUdV6jQeEOlUL8W7RYlq1My+5enUDj94Z6JnPcuCM YNHD9mE+fTsoblQ+nBNP910WcYBq1/O2I8CEI71OaDKiADkcQohuh+jZGnqKnMUuiTnq AGZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:list-unsubscribe:list-subscribe:list-id :precedence:date:message-id:dkim-signature; bh=uyeVkaizlVzKddAtNODyS0H7XtdU67ViDGrXRlk+WyI=; fh=ol9azfkH4D67heCVTuk5Ed5+oF7qgo2q1nG+gcnQwqU=; b=ZQ41hzmG/5tyXw251rvrTqkSRd1SJFHdygoxKwIkxYc2ZqveplFWN2dUfT3dzn+riO TVZqmIlcEep8YBcFmWhq3PG7/c5bdfhRoKbV+tBQ6NEFMT0x5TfSCZSUOmP9FBm9RCgv j3kerBc/vxtWNaMksENtB11UrIQ/2WMT76Bty07AvLf5YlN4Z/nm5PVBgZgUMLOLvqKG IYXknDD+IP6XgsqSOOEwpg6rbbq1aDSAYV73cWI4HL5MKzeIvgPguebnE3rzujvIE4QQ q8eEV8SRW3AoCInsnIO9U9gJLVmVnlrdauT7sbgdnZIem9jGGrmdxkNlq487bcSondNa bubA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="hAv42R/u"; spf=pass (google.com: domain of linux-kernel+bounces-25644-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-25644-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id by21-20020a056a02059500b005c69365abbbsi9292367pgb.318.2024.01.14.22.00.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Jan 2024 22:00:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-25644-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="hAv42R/u"; spf=pass (google.com: domain of linux-kernel+bounces-25644-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-25644-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 3AC39281A2D for ; Mon, 15 Jan 2024 05:54:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 82EA528E3; Mon, 15 Jan 2024 05:54:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="hAv42R/u" Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64305522B; Mon, 15 Jan 2024 05:54:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40F5lP0t007070; Mon, 15 Jan 2024 05:54:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=uyeVkaizlVzKddAtNODyS0H7XtdU67ViDGrXRlk+WyI=; b=hA v42R/u/rAPv69pP9jmoBYyZg2bqgNaaiycodFYLnlU+pbF90zSPvEj6s+wUIa3mZ uxPbj7kmb5azr9eFfWS5ITdYATsLLlpvDB59PYTIPVolHnKUSK3p9sz0MA2L+nmo wJq9JUtCsGdJumb0QosJ1xFCOSkdjTaGbKZm1v36kgZM2TWltk+wlcpfdsDBzN6R W9Ewmly7vZRaMc5GtYOtoAc3hYJC3aACJxAe9GBUA/4LjTcy6zmBIhWRLE4voqh9 1QpvexiHT/oOV/JFo711UNeomgxfhk5eAJoKfClP40O/2tk4Mn75qhlkuVzX5bIm XtejccEEMYRuDH2Njdfw== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3vkmjujpxm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Jan 2024 05:54:14 +0000 (GMT) Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 40F5sDbw015621 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Jan 2024 05:54:13 GMT Received: from [10.238.139.231] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Sun, 14 Jan 2024 21:54:10 -0800 Message-ID: Date: Mon, 15 Jan 2024 13:54:10 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] arm64: dts: qcom: qcs6490-idp: Add definition for three LEDs. To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley CC: , , References: <20240112-lpg-v4-1-c4004026686b@quicinc.com> <1f14bff5-4f3e-426b-b81d-006da061af1e@linaro.org> From: hui liu In-Reply-To: <1f14bff5-4f3e-426b-b81d-006da061af1e@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: T6G1asB1vliVUoccl5DI6Yw_C_vH-ZgL X-Proofpoint-GUID: T6G1asB1vliVUoccl5DI6Yw_C_vH-ZgL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-09_01,2023-12-07_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=1 bulkscore=0 impostorscore=0 mlxlogscore=222 clxscore=1015 malwarescore=0 priorityscore=1501 adultscore=0 mlxscore=1 spamscore=1 phishscore=0 suspectscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2311290000 definitions=main-2401150042 On 1/12/2024 3:44 PM, Krzysztof Kozlowski wrote: > On 12/01/2024 04:05, Hui Liu via B4 Relay wrote: >> From: Hui Liu >> >> Add definition for three LEDs to make sure they can >> be enabled base on QCOM LPG LED driver. >> >> Signed-off-by: Hui Liu >> --- >> Changes in v4: >> - Removed "label" definition and added "function" definition. > > You did not test your patch before sending. > > Subject is still wrong. Also, it still has unnecessary full stop. Drop it. I will update it to qcm6490-idp, I understood wrong previously. > > Best regards, > Krzysztof >