Received-SPF: pass (google.com: domain of linux-kernel+bounces-25651-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <0063df77-aede-4365-819e-5ec8eb6c5b3f@kylinos.cn>
Date: Mon, 15 Jan 2024 14:08:39 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] vfio/platform: Remove unnecessary free in
 vfio_set_trigger
Content-Language: en-US
To: Alex Williamson <alex.williamson@redhat.com>
Cc: eric.auger@redhat.com, a.motakis@virtualopensystems.com,
 b.reynal@virtualopensystems.com, kvm@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240112064107.137384-1-chentao@kylinos.cn>
 <20240112083447.750ad1c6.alex.williamson@redhat.com>
From: Kunwu Chan <chentao@kylinos.cn>
In-Reply-To: <20240112083447.750ad1c6.alex.williamson@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 2024/1/12 23:34, Alex Williamson wrote:
> On Fri, 12 Jan 2024 14:41:07 +0800
> Kunwu Chan <chentao@kylinos.cn> wrote:
> 
>> commit 57f972e2b341 ("vfio/platform: trigger an interrupt via eventfd")
>> add 'name' as member for vfio_platform_irq,it's initialed by kasprintf,
>> so there is no need to free it before initializing.
> 
> What?!  Just look at the call path where vfio_set_trigger() is called
> with a valid fd and existing trigger.  This change would leak irq->name
> as it's reallocated via kasprintf().  Thanks,
> 
> Alex
>   
>> Fixes: 57f972e2b341 ("vfio/platform: trigger an interrupt via eventfd")
>> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
>> ---
>>   drivers/vfio/platform/vfio_platform_irq.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/vfio/platform/vfio_platform_irq.c b/drivers/vfio/platform/vfio_platform_irq.c
>> index 61a1bfb68ac7..5e3fd1926366 100644
>> --- a/drivers/vfio/platform/vfio_platform_irq.c
>> +++ b/drivers/vfio/platform/vfio_platform_irq.c
>> @@ -179,7 +179,6 @@ static int vfio_set_trigger(struct vfio_platform_device *vdev, int index,
>>   	if (irq->trigger) {
>>   		irq_clear_status_flags(irq->hwirq, IRQ_NOAUTOEN);
>>   		free_irq(irq->hwirq, irq);
>> -		kfree(irq->name);
>>   		eventfd_ctx_put(irq->trigger);
>>   		irq->trigger = NULL;
>>   	}
> 
Thanks for your reply.

It's my bad.I misunderstood. Sorry to bother you.
-- 
Thanks,
   Kunwu