Received-SPF: pass (google.com: domain of linux-kernel+bounces-25697-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 15 Jan 2024 09:53:13 +0200
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: "Christian A. Ehrhardt" <lk@c--e.de>
Cc: linux-usb@vger.kernel.org, Dell.Client.Kernel@dell.com,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Hans de Goede <hdegoede@redhat.com>,
	Jack Pham <quic_jackp@quicinc.com>,
	Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
	Samuel =?utf-8?B?xIxhdm9q?= <samuel@cavoj.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] usb: ucsi: Add quirk infrastructure
Message-ID: <ZaTkaf/OmhvEr7ZI@kuha.fi.intel.com>
References: <20240107001701.130535-1-lk@c--e.de>
 <20240107001701.130535-3-lk@c--e.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240107001701.130535-3-lk@c--e.de>

On Sun, Jan 07, 2024 at 01:16:59AM +0100, Christian A. Ehrhardt wrote:
> Allow bus drivers to specify quirks for the UCSI core on
> attach. Allow the user to override the quirks on the command
> line.
> 
> Signed-off-by: Christian A. Ehrhardt <lk@c--e.de>
> ---
>  Documentation/admin-guide/kernel-parameters.txt |  5 +++++
>  drivers/usb/typec/ucsi/ucsi.c                   | 12 +++++++++++-
>  drivers/usb/typec/ucsi/ucsi.h                   |  6 +++++-
>  drivers/usb/typec/ucsi/ucsi_acpi.c              |  2 +-
>  drivers/usb/typec/ucsi/ucsi_ccg.c               |  2 +-
>  drivers/usb/typec/ucsi/ucsi_glink.c             |  2 +-
>  drivers/usb/typec/ucsi/ucsi_stm32g0.c           |  2 +-
>  7 files changed, 25 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 0a6a4b7f7a3b..fd8152dd4450 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -6783,6 +6783,11 @@
>  			<port#>,<js1>,<js2>,<js3>,<js4>,<js5>,<js6>,<js7>
>  			See also Documentation/input/devices/joystick-parport.rst
>  
> +	typec_ucsi.quirks=	[USB]
> +			A hex value specifying the quirks to enable for
> +			the USB Type-C connector system software interface
> +			driver. This overrides auto detected quirks.

New module parameters are not going to be accepted.

Please just fix the issue with Dell's first like I proposed, and then
you can start thinking about the infra for the quirks.

thanks,


-- 
heikki