Received-SPF: pass (google.com: domain of linux-kernel+bounces-25701-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <7170ecaf-32e3-4bfc-b20d-a08a341ae381@intel.com>
Date: Mon, 15 Jan 2024 15:57:23 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] connector: Change the judgment conditions for clearing
 proc_event_num_listeners
Content-Language: en-US
To: wangkeqi <wangkeqi_chris@163.com>, <davem@davemloft.net>,
	<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>
CC: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>, wangkeqi
	<wangkeqiwang@didiglobal.com>
References: <20240115075120.186143-1-wangkeqi_chris@163.com>
From: "Yin, Fengwei" <fengwei.yin@intel.com>
In-Reply-To: <20240115075120.186143-1-wangkeqi_chris@163.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dWxCbzhWcVRpT2JocjR5cVpXbE40Wjk3VWtKaXRadS95d3NSZWZDYUN4YXAx?=
 =?utf-8?B?OE1FbW1CNDJ2Z0pNaCtlTGtQeGpxbjVXNkpMY0tra3dDUUphWU9aRFhOdHdl?=
 =?utf-8?B?V1R6ditYUkFucmVITEVjQVhaeW5SWkY4SGFMZzluVDVUaUZRVzg0L0VtZWo3?=
 =?utf-8?B?NVhsMW5XWG1KVFd3WmhRdlY5NWNKVml3RHJzeU4wTGhQeDkvZkwwWXhiN0FG?=
 =?utf-8?B?ZVV6MDQ0UFFkeFBPZ01ySHptd2pqQ3lqSE4zd3FXS0NoUFA4bFQwQTNZN2hM?=
 =?utf-8?B?NG5PamZFSjVxNk1RNXZ2MEd6eDhEbzB6MFZLcXFCa3VsWS9qeWs3anZyUUFJ?=
 =?utf-8?B?VFk0SjlLZmlteCt1ZW5QUTlZOXJiOTBNVjVmZUxDT2dPS1lnS2FBSjlVd3NM?=
 =?utf-8?B?c3hMMU1oclNKWmJYM2FHQ0hSTThmVTgxVGNjRVljdlYyT3JoZlVGOFpzNjZu?=
 =?utf-8?B?MFFtS3IxYmlQV2I4QWxNVUVtSkx1c3ZJdnZGREJyTmd5RjZmOFkyUjRldW9p?=
 =?utf-8?B?c2tndVFmVTRpR1JFelV0VVNXSEVJZVJCUHFhNGc0STdYWkNnQVVvTVJVaG0w?=
 =?utf-8?B?QWtmbkxWV3IreGlFT1BjTnlKMDhqWFFSUzR0K1dndDBpWEJFSjlmWnBIb2th?=
 =?utf-8?B?aElsaTJBOEZleDVwRnZwTldJZ0N5TnpyeGxCUnV3azU2dHhOblI1Vi9TT1F1?=
 =?utf-8?B?SWtFTkxSaitrNUdoSlhqREY1b0t2YlZxU1EzMGZBOW9tOFR3QnprZ2lIbUlH?=
 =?utf-8?B?RTh3M1dYY25UamtBSHEvSkkwTGtBNDJzaGhWVWpHalBRdmd5RVE2Z3htME9Y?=
 =?utf-8?B?bkVQTUp6bVdVYjJuelNrTkNmTHBhOVJJV2FOSjhFRjhYYThXSGt3Sk50b1BZ?=
 =?utf-8?B?QlVFS1gzNVVhU2Vra3o2SzIrUGJueWpCV0RCOVI2QnNCOGpSRFRYTmViSTRZ?=
 =?utf-8?B?WklRQWxCemlmY3I5bmRYU3JiYWFaLzRiSzZCTWRQOFJLNHBCVVFQMWM2Y0Vw?=
 =?utf-8?B?UHFnL052cUFnSkJXVDl4T3ZObUd6Yno0Zm80ZDVzYVJLdkhsUFV1bk9qeEJD?=
 =?utf-8?B?Yzh5Ymo1MzJKV0JRaCtrTG9ROU9BWWZ2V2hoN2JkTDVyMDIySDRvNDdmc21t?=
 =?utf-8?B?V2l5cUFIbGJJUEJDMEozTFRnWXFpdytZVVYzS0xVZm4rZDB2cVljRXYrWnRi?=
 =?utf-8?B?VHZpU0czTTI2dE5XNHJMb1l2UGtGZ205SjRDVm0rSE0xbndESVBKdHhMYlpa?=
 =?utf-8?B?NmF0Z2JUdW9LSThmS2JJaFNPS0ZZejNaZlM1bzJtTkZEZjZZTURhczRXODBR?=
 =?utf-8?B?R3RYVHZoTnhpaFF4eDk4RUdhSitpNy95SmZVNXdZNzZIcHhrRE1WeTdJclFi?=
 =?utf-8?B?NlIzMy9mOWVpUFh0SFBFMXNXSUtjeGIzMDJDREtmVzZ5d1ZoeGRuSXkwcU5K?=
 =?utf-8?B?eHlGbWxGNUdYVTRoNURCbkZhd1dxRDlpKzNydEVoeDJCUU1zbW9Pc2VIYTg1?=
 =?utf-8?B?cDR0RDNmNU1qU3E0TW4vdGw5Rk5ieFdibzY5VmhzeExwbytsZjd0d2ZNdGN6?=
 =?utf-8?B?Rm1aangwbjhHTXhVRkczdlhQUFp6WUtlSCsyM2Ird1JjTmV3RHk4Kzd5S3Mw?=
 =?utf-8?B?anF1UEpUeGtJU293QXRvTUdrZkFjaUI2N1lBSzYrUkNOTGd3SGJ6MVZJSEtL?=
 =?utf-8?B?TjRhWlZqOGFNRzBBbmVuTHRLdXVnL1hMUGVwVnNsVVA1RTRESEhiMmxuN1pV?=
 =?utf-8?B?N2RRN2pMOUYzTGJKck1GODdHb3d2VDJQUDgrOUVmWUQzSjdqRStVL1VBVjZ3?=
 =?utf-8?B?aS95OWJrSGw4a0xWcVNweUp0aUpMNytmSzN4Q29pSm9Mb1FUSDkvVHRvdkZq?=
 =?utf-8?B?cGlRa2NHVlYvcVJPV045SlluK0ZsVXRjUlRkdWp1VCtkYUp4SG9LYTRPMlh0?=
 =?utf-8?B?bE9lWVBZM0RXVlZxcGcxR0ZscHpjbTFWMjgzWitpZlZZOTNHSDQrcGhsb1oz?=
 =?utf-8?B?UDNuNmNwOENyVDhZV2xsZVJKZ3ZwRmIra3NmaGY3cjZ2Rmd1ZHBrbUZYL3dr?=
 =?utf-8?B?WVpGTWp5aTlQcXcwYUxlNW43bituSVp3K0UxS01MR25mK2xFS3JWWXBkbEh1?=
 =?utf-8?B?VVZLRWxPRWZLbVFCN2dhZVFlNHdYQW5hRzgweWN3bWNNWlZoZi9iVnVVaHV2?=
 =?utf-8?B?ekE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0dd89e98-a84b-4642-c8c2-08dc159f9f8f
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2024 07:57:30.3595
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hUS4jW//hgTtDVgWzIRiO/eHv/TofFKlW28Wu4lq2Q4XCqBgINae5CWaB17+ZFyHPNAde6pUrNY427z8be348w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7980
X-OriginatorOrg: intel.com


On 1/15/2024 3:51 PM, wangkeqi wrote:
> From: wangkeqi <wangkeqiwang@didiglobal.com>
> 
> It is inaccurate to judge whether proc_event_num_listeners is
> cleared by cn_netlink_send_mult returning -ESRCH.
> In the case of stress-ng netlink-proc, -ESRCH will always be returned,
> because netlink_broadcast_filtered will return -ESRCH,
> which may cause stress-ng netlink-proc performance degradation.
> Therefore, the judgment condition is modified to whether
> there is a listener.
> 
> Signed-off-by: wangkeqi <wangkeqiwang@didiglobal.com>

Regarding the original report:

If you fix the issue in a separate patch/commit (i.e. not just a new 
version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <oliver.sang@intel.com>
| Closes: 
https://lore.kernel.org/oe-lkp/202401112259.b23a1567-oliver.sang@intel.com


Could you please add the tag? Thanks.

> ---
>   drivers/connector/cn_proc.c   | 6 ++++--
>   drivers/connector/connector.c | 6 ++++++
>   include/linux/connector.h     | 1 +
>   3 files changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/connector/cn_proc.c b/drivers/connector/cn_proc.c
> index 3d5e6d705..b09f74ed3 100644
> --- a/drivers/connector/cn_proc.c
> +++ b/drivers/connector/cn_proc.c
> @@ -108,8 +108,10 @@ static inline void send_msg(struct cn_msg *msg)
>   		filter_data[1] = 0;
>   	}
>   
> -	if (cn_netlink_send_mult(msg, msg->len, 0, CN_IDX_PROC, GFP_NOWAIT,
> -			     cn_filter, (void *)filter_data) == -ESRCH)
> +	if (netlink_has_listeners(get_cdev_nls(), CN_IDX_PROC))
> +		cn_netlink_send_mult(msg, msg->len, 0, CN_IDX_PROC, GFP_NOWAIT,
> +			     cn_filter, (void *)filter_data);
> +	else
>   		atomic_set(&proc_event_num_listeners, 0);
>   
>   	local_unlock(&local_event.lock);
> diff --git a/drivers/connector/connector.c b/drivers/connector/connector.c
> index 7f7b94f61..1b2cd410e 100644
> --- a/drivers/connector/connector.c
> +++ b/drivers/connector/connector.c
> @@ -129,6 +129,12 @@ int cn_netlink_send(struct cn_msg *msg, u32 portid, u32 __group,
>   }
>   EXPORT_SYMBOL_GPL(cn_netlink_send);
>   
> +struct sock *get_cdev_nls(void)
> +{
> +	return cdev.nls;
> +}
> +EXPORT_SYMBOL_GPL(get_cdev_nls);
> +
>   /*
>    * Callback helper - queues work and setup destructor for given data.
>    */
> diff --git a/include/linux/connector.h b/include/linux/connector.h
> index cec2d99ae..255466aea 100644
> --- a/include/linux/connector.h
> +++ b/include/linux/connector.h
> @@ -127,6 +127,7 @@ int cn_netlink_send_mult(struct cn_msg *msg, u16 len, u32 portid,
>    */
>   int cn_netlink_send(struct cn_msg *msg, u32 portid, u32 group, gfp_t gfp_mask);
>   
> +struct sock *get_cdev_nls(void);
>   int cn_queue_add_callback(struct cn_queue_dev *dev, const char *name,
>   			  const struct cb_id *id,
>   			  void (*callback)(struct cn_msg *, struct netlink_skb_parms *));