Received-SPF: pass (google.com: domain of linux-kernel+bounces-25712-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <00742a4d-c7aa-42b9-b851-e6ead0f7a29b@intel.com>
Date: Mon, 15 Jan 2024 16:20:47 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 3/3] vfio: Report PASID capability via VFIO_DEVICE_FEATURE
 ioctl
Content-Language: en-US
To: Jason Gunthorpe <jgg@nvidia.com>, Alex Williamson
	<alex.williamson@redhat.com>
CC: "Duan, Zhenzhong" <zhenzhong.duan@intel.com>, "joro@8bytes.org"
	<joro@8bytes.org>, "Tian, Kevin" <kevin.tian@intel.com>,
	"robin.murphy@arm.com" <robin.murphy@arm.com>, "baolu.lu@linux.intel.com"
	<baolu.lu@linux.intel.com>, "cohuck@redhat.com" <cohuck@redhat.com>,
	"eric.auger@redhat.com" <eric.auger@redhat.com>, "nicolinc@nvidia.com"
	<nicolinc@nvidia.com>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
	"chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
	"yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>, "peterx@redhat.com"
	<peterx@redhat.com>, "jasowang@redhat.com" <jasowang@redhat.com>,
	"shameerali.kolothum.thodi@huawei.com"
	<shameerali.kolothum.thodi@huawei.com>, "lulu@redhat.com" <lulu@redhat.com>,
	"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
	"joao.m.martins@oracle.com" <joao.m.martins@oracle.com>, "Zeng, Xin"
	<xin.zeng@intel.com>, "Zhao, Yan Y" <yan.y.zhao@intel.com>
References: <20231127063909.129153-1-yi.l.liu@intel.com>
 <20231127063909.129153-4-yi.l.liu@intel.com>
 <20231211110345.1b4526c6.alex.williamson@redhat.com>
 <SJ0PR11MB674458A8B7319F30A67FE55F928EA@SJ0PR11MB6744.namprd11.prod.outlook.com>
 <20231211203946.35552183.alex.williamson@redhat.com>
 <20231212152725.GJ3014157@nvidia.com>
From: Yi Liu <yi.l.liu@intel.com>
In-Reply-To: <20231212152725.GJ3014157@nvidia.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NWhMbS9GMWJMRUFFbGZDM2Uwck9MSSt5cjJxVU8yQnoxZGt5M1AxNmdJeUdl?=
 =?utf-8?B?cmlLZU45c2JCaEcvclpDUVljek85NVU0NXI2YzVkY1l4U3RxdnpSVU55Unla?=
 =?utf-8?B?aFlVdWxoT1BBNHhmeHFBZTF4bmVjSlJXM09SNjZYUnMyM1Z3bW5yWENmMlZL?=
 =?utf-8?B?Zld0N3BMR3NlR2FOU05xL0QzZXNNdkRqUzhWWDQ5VU9nV1paekFiR3g4a2RE?=
 =?utf-8?B?Z1ptZ084Z3ZvUUJRR2t0MXVsd21jcTVPWFRNN3hIaHJOb3F1QldXakltTDNm?=
 =?utf-8?B?YXQ2SCtVL0tvZHpENFllRzZPcW54TUtsMmNBRmtQUE4xT3FQVUVjcHJIYTJw?=
 =?utf-8?B?QXlmMVU3ZVFwaDhaeXVZbisvQk5aa1BZRDlWZU1TWWRxUEZtaC8xVjFFTUEy?=
 =?utf-8?B?Smw1RjNYUWZIOGROVlZnbnVwTVdZSlZabmNGQlN1bDVZOGRSZHpYQW43L2FQ?=
 =?utf-8?B?aFJIQlZxYzh3UGMyS1VaMFBqUmNXQUpHc2hpeUczSTZiZEM1YTdhb2F0NFM3?=
 =?utf-8?B?NUlNME1mb3RxNXNta3cwQ2ZqRVhpR29WaUFGUkQ0S1E2L25uekZUTjVLc1Nq?=
 =?utf-8?B?dkxvTVJkY2Qyb0UrdFFZTHdiSURVQVVsSFpGS2VXVEhtUVpIeEdLQUhsMVBD?=
 =?utf-8?B?RGhLbzRiVzRaUUNZSTlmRUNkZk1OdW9Xd1lBdmFXeWljTitjTEtuMG0vdnha?=
 =?utf-8?B?NnhhSzFkQ3E4WEZCY2FremdQV3JjV2dqZDVVZEhsMmRydTVtN2JONTdIRXZi?=
 =?utf-8?B?MlB4b3hxMjhLclBUOU5HM1BwT0UrTjFWc29iYitGU3p2bW5UZ1JhM2NZRE5w?=
 =?utf-8?B?cTVCT3gza09zR0hFOVRTMmd5RmlrcDY1dkdia2VvdnZpa2ZSVUdCbzFYTWZJ?=
 =?utf-8?B?ZkkyRjA2aDA2VlZCRCtBRjBrbTI5M3YrRFdpWVM2bHFHQzNrSGVJNWVPRU54?=
 =?utf-8?B?dG1nZnphaEtrRlNieDVWcVVIVkIzcXZ4VjBDRXJCZEJjQkZDYktXdmpTcENJ?=
 =?utf-8?B?MiszSzRheEVXeHVNeHJxeklvVnBQUHZPSGtaejFQVmdlSzRFdnFmN1dJMkVU?=
 =?utf-8?B?TnlZMlp6U2hBQmM1YUF0YkxaVC9IbFcycVdaemVrZVV5Z0ljR3JNSnFJODRK?=
 =?utf-8?B?K1J2bzIyZ0xQN202TzVmMmJzeit6YWRyTFhOTDhNb3dwcmNBNTdFa25obDFZ?=
 =?utf-8?B?ZUVRYW9tVENEWTI0amRIK3VuMWgvVUttNXUrYTI2WW9SN2QvcUVTZjJXRGYw?=
 =?utf-8?B?bWptRGNIYWw4OWkvNDVmd0ZvSjRSTEhsQmQxNG9Jam9MSktrbHJSOWNuL3Rv?=
 =?utf-8?B?UHd0VmpETGdWazhoa2JXaDVRV294N2JEaXJ6Ukd1RVYzVlp2N0x6MHNTK1B6?=
 =?utf-8?B?dm1EaXNnQWZUaFY4R2FzM3doUFlSVDVTRE5xaXpSbVJLYTVyTW9RSk15RS9U?=
 =?utf-8?B?dk9wM1doS2t1dVBUMm5NM2ZCS2dFbHpyKzErbkdueUJDZ0FHRmErRzY3dm1O?=
 =?utf-8?B?RXpKTUkwdUZQQjUrS01Rb0ZFcGpuaXAzYkx0MS92eDl3eXIzQWFuaStBNks0?=
 =?utf-8?B?UnNDUlFJNGFSMGl4cGNxWWJkZFhvTDZmRzRGOUxNTExkUnhodVBBc1RaMS9O?=
 =?utf-8?B?c0h6ZWdqZEN0TVNjUnhhK2FXblUwTWpFUnUyV1pNN3B6STVuSFhaTFNJNVNQ?=
 =?utf-8?B?RENlazFpUW9RWnlGWUhoc1NPQkFPT0pWSmhUbTgrU2xieGQxRHQxRi9pZHJU?=
 =?utf-8?B?U0pSczIvc1kraG5yV1I2QWpzeEk0OXA0ZWxOaVFScXNzUUZwamhtUTlQTkZt?=
 =?utf-8?B?UWY1YjFkazJNaml3dXU2NG41UDhVSkVDUHA4VlVtZ2thQVBySFFNbkF1aFA2?=
 =?utf-8?B?eDFHM3F0T01xRG1IL242WlBqdU94aENHb1NGQU85NG11cmV1NUFjeVFNK2pq?=
 =?utf-8?B?TENQbzYveHVtZ3ViTkVXRTk4ZUMxVm0yNHkra0JiM3dWcy9GVjdoRDluQWFo?=
 =?utf-8?B?L1lCUkJtU05uSktMb00rUHEzaDVHRU0rOWErSGloMjlQOFZwZFVvdHJFQmla?=
 =?utf-8?B?VUtNUHpERXk1dHZjNmQvTDEwYy9lN3M3WTluOC8wVXVuZzBFYmNYWnNML2pJ?=
 =?utf-8?Q?ebMqtCCJbvAFP78G3aJ1swUw0?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d4da294d-447c-49c5-9885-08dc15a275ed
X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7540.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2024 08:17:49.0186
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DhdFY9u2CoO+hyhsXV4CeqiQCY2Nq9zNePyStA+zskroZCX/+npM6vIxYOxIQhm8xpiOX8REKPvchPF+NgZwzA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7027
X-OriginatorOrg: intel.com

On 2023/12/12 23:27, Jason Gunthorpe wrote:
> On Mon, Dec 11, 2023 at 08:39:46PM -0700, Alex Williamson wrote:
> 
>> So how do we keep up with PCIe spec updates relative to the PASID
>> capability with this proposal?  Would it make more sense to report the
>> raw capability register and capability version rather that a translated
>> copy thereof?  Perhaps just masking the fields we're currently prepared
>> to expose.
> 
> I think the VMM must always create a cap based on the PCIe version it
> understands. We don't know what future specs will put there so it
> seems risky to forward it if we don't know that any possible
> hypervisor support is present.

This series parses the capability register and reports the known caps
to user. While this does not include the version number, userspace should
decide the proper version number. Seems like what you suggests here.

> 
> We have this problem on and off where stuff in PCI config space needs
> explicit hypervisor support or it doesn't work in the VM and things
> get confusing.
> 
> Jason

-- 
Regards,
Yi Liu