Received-SPF: pass (google.com: domain of linux-kernel+bounces-25748-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <ebb7908c-d28c-4549-8aa2-1e0e62c62e8a@intel.com>
Date: Mon, 15 Jan 2024 09:45:47 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] scsi: isci: request: Fix an error code problem in
 isci_io_request_build
To: Su Hui <suhui@nfschina.com>, <jejb@linux.ibm.com>,
	<martin.petersen@oracle.com>, <nathan@kernel.org>, <ndesaulniers@google.com>,
	<morbo@google.com>, <justinstitt@google.com>
CC: <dan.j.williams@intel.com>, <linux-scsi@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <llvm@lists.linux.dev>,
	<kernel-janitors@vger.kernel.org>
References: <20240112041926.3924315-1-suhui@nfschina.com>
Content-Language: en-US
From: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
In-Reply-To: <20240112041926.3924315-1-suhui@nfschina.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WUYza0VrbHVwZUUxbDVGUFIvR2J6MUphSm1yaHB1bnRpYnM1ZFYrYUNNc2Zs?=
 =?utf-8?B?a1plVEhGM3R0b3ZIZlFTSENFc0pKekhldDhKYTZwckI1L2ptaWhEMUdMbDFB?=
 =?utf-8?B?bjk4bGwrSFVUVGxtTUdSLzJML1FvbktXbS8vSXUzeDZoZUJkanNzSGlUTDZs?=
 =?utf-8?B?R0JDVUpleEVmTWtVRldqTmlZV0JOZmNxV3EyVDVVNkRaS3dmcnp3SUFxNkx5?=
 =?utf-8?B?dUowQ29hUTMwSGh1Vmd1ME0rNks4UEhjcklFVUQya0FzMXZjT3dRYUI1Q2s3?=
 =?utf-8?B?TXJIbmI1bVNqWFowR1BJeldHN2N1MnZnMkthQU9vd2ZHQlRIR2JsSXp6RXBr?=
 =?utf-8?B?bUtIQnlBK3ROWkxZN1NkK0J3UnVUQzZmS3BRcDBIbVNlcDdUVktNM3RESGRI?=
 =?utf-8?B?T0VDYjFETFBvOENQWjBydUpOalI0L3pMdE5EOWZLc3lTc05iaXVFdFlHeWFt?=
 =?utf-8?B?d0tISWs4M2tyQTJxcFkva2x6OEtxaHNZYW5GbUZBa0Ric2pGSmdKWFJqUnRV?=
 =?utf-8?B?ZEwvU2lCVzJXUzhDL01ISXdDeGM1YXVUanNKNU5YUTZmTmErWDlSKzg4UUVL?=
 =?utf-8?B?aUEvdENCS2J3YlZCdWlrRVkwWExTWm5FSGJBNVNkb3dLS3N6ZzVjcEJCV1dX?=
 =?utf-8?B?UXY4WFBCTm1iSGQwZVdBbVJ3QmNZM1JWbXM0NE9KMU9YOGtJbTI2RXh5bEM5?=
 =?utf-8?B?QllaNXQvaXhmeGRoU3BOc21DQ1ZjdEU1SnZaVzVlcDJ4TDlSVzdRVHhJRGl0?=
 =?utf-8?B?aitmcFFJaXZrRVlqakFwaHpSWGpNWG1zcWNrNG5NbUhyZ2R3SVNkODBmRTcy?=
 =?utf-8?B?Rm9kQkJQZGtWZDl6SFhhYzdRRkVKWnpKb2EySUtwbzJSaDdBSUt3bWpLMTg0?=
 =?utf-8?B?MG1QTjBRdnRMY0FwUWlLd3FNTmJNaUFHZ3MrY2pDbTRwUHE1TThmMzdYUXJJ?=
 =?utf-8?B?SS9mUFl1bUVndjVic0JSRUcvQzRINXpEa3UvaDZzNllqNkZPeFFLNEFwRzNX?=
 =?utf-8?B?MkxBRFlMblJ6VGNKbHVJWlVTWVk4d1pObi9hamEyZWxYTFNDOHFpWFFEbE5a?=
 =?utf-8?B?aUt5cWlBeU5qQ0FwNkh3blZjU1g3Zlp0eHFZUDFLaG9NaGlhZlliWFJHUmk1?=
 =?utf-8?B?NC9odHlMYWxBK2tQN1hveVdBS0lDRldqSy9aNGt6dzFWS2Uxc1NMNitXcHls?=
 =?utf-8?B?OUcvZGFtd2t5L1FadkpuU2owUmhsbC9BTVB0cVg2TEpkR1g5a3ZFYzVsMG1G?=
 =?utf-8?B?QWlKcFVSY3dOVWx6MFdLNWgzeTBQL0NWYlkzYmV6bHNwdUV6SnZ5VkJ1amVm?=
 =?utf-8?B?VEhSMTI3UzJLcVZ2RFk1anlxbUdGNk52ekRuN0YzY3Q4RG5oTHlPeGkvb0cw?=
 =?utf-8?B?aEVqNXd4OEtCQ04rY3ZDbmJyZmdBZ2xGUitTRkp1YzFRRXRNRkpBVDNMd0RD?=
 =?utf-8?B?UkFlQ3pBbTZlRWZZYS92UFJ6UHFxNnF0TlRESExzWWhYalhXL1NIZEhlOFNi?=
 =?utf-8?B?NEU2N0VPMEdId1ZqTjZrbHpsYStKSkE5Y0JKY1FFRmFKU3lyODBGeEVkNTYr?=
 =?utf-8?B?bDZSdjEvQkRwZTNKaEpmb1RrdUkyYXNsOXlyYTVUb2l4VytPK2M5MDFwWFNK?=
 =?utf-8?B?WnorTnBNM2Niekp6ZVMrMWt5dW1Sa1BXZE1vQVZRVTFRU01WMUZPdVlHTVM1?=
 =?utf-8?B?Rm9LaS9uYlNQZlRNSkJ5N09sL3BrN2pTbEFCbFk1UVN6VnAxTVRSV0NtS3JF?=
 =?utf-8?B?alp2cjNYdVd2RENrekprVzY1M2dGRG90R2c4a3Z0cDJRQmpLQTlLN2hFOUZv?=
 =?utf-8?B?VU5tRlBjb1RWWnVWUG5hVUp0Y1cwbXh5VTFRMlhwa0VFT0YreVFGZWc5NGc5?=
 =?utf-8?B?ZS82eTVsVUltN256Tk55SjVIbnUrY3RGSiswZHlCQnpLYU0yQ3ptYTRuWVhF?=
 =?utf-8?B?NUxab2VMMElNUzVuNFpGQlN3Vy9oT1hSc1BabDBRVDhqOHJScTd4bnVmLzgr?=
 =?utf-8?B?cXFYNWQzUWptNnVIVkNUUzhWWi96NVlHUWtWeWRxMHFjSVpEemgzRU9ZaUFH?=
 =?utf-8?B?VlFiWGtLQ2NsSjRQTG9iamtUaDFsaTgvLzJLUXFKT1BLOG9DeUZtWDd6OGZh?=
 =?utf-8?B?R3Qzd2NsOXNxQkFYQnphZS9rKzIrWjhQc2k1c3RWVWdJSEJRWUhCbEdrNXY1?=
 =?utf-8?B?S0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a638728-2408-40dd-3199-08dc15a661ac
X-MS-Exchange-CrossTenant-AuthSource: LV8PR11MB8724.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2024 08:45:52.9394
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8yXHXQK+crS4bXF7xiZBvnjBQOVSpgprdT9NxbNFhGjnunt+L1/JdlsyRNbHKJANGWeffLjivtPNKFbHU2jJpUg9A8RWQ60waUsNq8gQVzY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5831
X-OriginatorOrg: intel.com

On 1/12/24 05:19, Su Hui wrote:
> Clang static complains that Value stored to 'status' is never read.
> Return 'status' rather than 'SCI_SUCCESS'.
> 
> Fixes: f1f52e75939b ("isci: uplevel request infrastructure")
> Signed-off-by: Su Hui <suhui@nfschina.com>

Reviewed-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>