Received-SPF: pass (google.com: domain of linux-kernel+bounces-25750-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 15 Jan 2024 17:48:25 +0900
From: Byungchul Park <byungchul@sk.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	kernel_team@skhynix.com, akpm@linux-foundation.org,
	ying.huang@intel.com, namit@vmware.com, xhao@linux.alibaba.com,
	mgorman@techsingularity.net, hughd@google.com, david@redhat.com,
	peterz@infradead.org, luto@kernel.org, tglx@linutronix.de,
	mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com
Subject: Re: [v5 4/7] mm: Separate move/undo doing on folio list from
 migrate_pages_batch()
Message-ID: <20240115084825.GA18164@system.software.com>
References: <20240111060757.13563-1-byungchul@sk.com>
 <20240111060757.13563-5-byungchul@sk.com>
 <ZaAMf5JX2D3N7Epi@casper.infradead.org>
 <20240115020817.GA56966@system.software.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240115020817.GA56966@system.software.com>
User-Agent: Mutt/1.9.4 (2018-02-28)

On Mon, Jan 15, 2024 at 11:08:18AM +0900, Byungchul Park wrote:
> On Thu, Jan 11, 2024 at 03:42:55PM +0000, Matthew Wilcox wrote:
> > On Thu, Jan 11, 2024 at 03:07:54PM +0900, Byungchul Park wrote:
> > > +static void migrate_folios_move(struct list_head *src_folios,
> > > +		struct list_head *dst_folios,
> > > +		free_folio_t put_new_folio, unsigned long private,
> > > +		enum migrate_mode mode, int reason,
> > > +		struct list_head *ret_folios,
> > > +		struct migrate_pages_stats *stats,
> > > +		int *retry, int *thp_retry, int *nr_failed,
> > > +		int *nr_retry_pages)
> > > +{
> > > +	struct folio *folio, *folio2, *dst, *dst2;
> > > +	bool is_thp;
> > > +	int nr_pages;
> > > +	int rc;
> > > +
> > > +	dst = list_first_entry(dst_folios, struct folio, lru);
> > > +	dst2 = list_next_entry(dst, lru);
> > > +	list_for_each_entry_safe(folio, folio2, src_folios, lru) {
> > > +		is_thp = folio_test_large(folio) && folio_test_pmd_mappable(folio);

JFYI, in the v4 patch set, I hadn't changed the original code that I
refactored. I just copied and pasted this part from the original code.

> > 
> > You don't need to call folio_test_large() first.  folio_order() includes
> > a call to test_large() so it can return 0.
> > 
> > > +		nr_pages = folio_nr_pages(folio);
> > 
> > ... or since you're calculating this anyway,
> > 
> > 		is_thp = nr_pages >= HPAGE_PMD_NR

I didn't apply what you suggested me here to the next version yet
because I was not sure if it'd make the code more readable.

Thanks anyway!

	Byungchul

> Cool. Thanks.
> 
> 	Byungchul
> 
> > perhaps