Received-SPF: pass (google.com: domain of linux-kernel+bounces-25824-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 15 Jan 2024 10:52:32 +0100
From: Markus Schneider-Pargmann <msp@baylibre.com>
To: Francesco Dolcini <francesco@dolcini.it>
Cc: Chandrasekar Ramakrishnan <rcsekar@samsung.com>, 
	Wolfgang Grandegger <wg@grandegger.com>, Marc Kleine-Budde <mkl@pengutronix.de>, 
	"David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, 
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, 
	Francesco Dolcini <francesco.dolcini@toradex.com>, linux-can@vger.kernel.org, netdev@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] can: m_can: remove redundant check for pm_clock_support
Message-ID: <nls37vv4rj6pn5vvrjizapb23l3mikpwkh2fk7gtrpnxgiym5b@jbmlyci4q3pg>
References: <20240104235723.46931-1-francesco@dolcini.it>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20240104235723.46931-1-francesco@dolcini.it>

On Fri, Jan 05, 2024 at 12:57:23AM +0100, Francesco Dolcini wrote:
> From: Francesco Dolcini <francesco.dolcini@toradex.com>
> 
> m_can_clk_start() already skip starting the clock when
> clock support is disabled, remove the redundant check in
> m_can_class_register().
> 
> This also solves the imbalance with m_can_clk_stop() that is called
> afterward in the same function before the return.
> 
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>

Reviewed-by: Markus Schneider-Pargmann <msp@baylibre.com>

Best,
Markus

> ---
> I spotted the issue while debugging some other part of the code,
> the patch is only compile-tested.
> ---
>  drivers/net/can/m_can/m_can.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
> index 16ecc11c7f62..bd1d1626684d 100644
> --- a/drivers/net/can/m_can/m_can.c
> +++ b/drivers/net/can/m_can/m_can.c
> @@ -2056,11 +2056,9 @@ int m_can_class_register(struct m_can_classdev *cdev)
>  {
>  	int ret;
>  
> -	if (cdev->pm_clock_support) {
> -		ret = m_can_clk_start(cdev);
> -		if (ret)
> -			return ret;
> -	}
> +	ret = m_can_clk_start(cdev);
> +	if (ret)
> +		return ret;
>  
>  	if (cdev->is_peripheral) {
>  		ret = can_rx_offload_add_manual(cdev->net, &cdev->offload,
> -- 
> 2.39.2
>