Received-SPF: pass (google.com: domain of linux-kernel+bounces-25825-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 15 Jan 2024 10:52:11 +0100
From: Martin Kaiser <martin@kaiser.cx>
To: Peng Fan <peng.fan@nxp.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpio: vf610: allow disabling the vf610 driver
Message-ID: <ZaUAS2syv-hnE7qS@v2202401214221251712.nicesrv.de>
References: <20240111150429.681567-1-martin@kaiser.cx>
 <DU0PR04MB9417956F985780AD85FD733E886F2@DU0PR04MB9417.eurprd04.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <DU0PR04MB9417956F985780AD85FD733E886F2@DU0PR04MB9417.eurprd04.prod.outlook.com>
Sender: "Martin Kaiser,,," <martin@akranes.kaiser.cx>

Hi Peng,

Thus wrote Peng Fan (peng.fan@nxp.com):

> Thanks Linus for Ccing me.

I did already Cc you on the initial patch. My hope was to get feedback about
unwanted side effects.

> > Subject: [PATCH] gpio: vf610: allow disabling the vf610 driver

> > The vf610 gpio driver is enabled by default for all i.MX machines, without any
> > option to disable it in a board-specific config file.

> > Most i.MX chipsets have no hardware for this driver. Change the default to
> > enable GPIO_VF610 for SOC_VF610 and disable it otherwise.

> > Add a text description after the bool type, this makes the driver selectable by
> > make config etc. i.MX chips other than SOC_VF610 can now enable the driver
> > from their board config.

> This will break i.MX8QM,DXL,ULP/i.MX93 boot. You could add text description
> to make it selectable, but please not drop def y. Or you need update defconfig.

Thanks for bringing this up.

It seems to me that other gpio drivers are disabled by default and enabled
where needed. I suggest adding CONFIG_GPIO_VF610=y to
arch/arm64/configs/defconfig and probably also to
arch/arm/configs/imx_v6_v7_defconfig.

I'll send a v2 with these changes unless you (or someone else) disagree.

Thanks,
Martin