Received-SPF: pass (google.com: domain of linux-kernel+bounces-25868-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240115052140.18858-1-rdunlap@infradead.org>
In-Reply-To: <20240115052140.18858-1-rdunlap@infradead.org>
From: Bartosz Golaszewski <brgl@bgdev.pl>
Date: Mon, 15 Jan 2024 11:15:41 +0100
Message-ID: <CAMRc=MeGmN1xEEGhXV=zY9kKJayBbF4UABZEK4ieQPxzVefHfw@mail.gmail.com>
Subject: Re: [PATCH v2] gpio: EN7523: fix kernel-doc warnings
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, John Crispin <john@phrozen.org>, 
	Linus Walleij <linus.walleij@linaro.org>, Felix Fietkau <nbd@nbd.name>, linux-gpio@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 15, 2024 at 6:21=E2=80=AFAM Randy Dunlap <rdunlap@infradead.org=
> wrote:
>
> Add "struct" keyword and explain the @dir array differently to
> prevent kernel-doc warnings:
>
> gpio-en7523.c:22: warning: cannot understand function prototype: 'struct =
airoha_gpio_ctrl '
> gpio-en7523.c:27: warning: Function parameter or struct member 'dir' not =
described in 'airoha_gpio_ctrl'
> gpio-en7523.c:27: warning: Excess struct member 'dir0' description in 'ai=
roha_gpio_ctrl'
> gpio-en7523.c:27: warning: Excess struct member 'dir1' description in 'ai=
roha_gpio_ctrl'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: John Crispin <john@phrozen.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Bartosz Golaszewski <brgl@bgdev.pl>
> Cc: Felix Fietkau <nbd@nbd.name>
> Cc: linux-gpio@vger.kernel.org
> ---
> v2: Add commit text.
>
>  drivers/gpio/gpio-en7523.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff -- a/drivers/gpio/gpio-en7523.c b/drivers/gpio/gpio-en7523.c
> --- a/drivers/gpio/gpio-en7523.c
> +++ b/drivers/gpio/gpio-en7523.c
> @@ -12,11 +12,11 @@
>  #define AIROHA_GPIO_MAX                32
>
>  /**
> - * airoha_gpio_ctrl - Airoha GPIO driver data
> + * struct airoha_gpio_ctrl - Airoha GPIO driver data
>   * @gc: Associated gpio_chip instance.
>   * @data: The data register.
> - * @dir0: The direction register for the lower 16 pins.
> - * @dir1: The direction register for the higher 16 pins.
> + * @dir: [0] The direction register for the lower 16 pins.
> + * [1]: The direction register for the higher 16 pins.
>   * @output: The output enable register.
>   */
>  struct airoha_gpio_ctrl {

Could you add a Fixes: tag too, please?

Bartosz