Received-SPF: pass (google.com: domain of linux-kernel+bounces-25870-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <ebd2d3ef-f222-42ed-8103-c8dd61c99742@amd.com>
Date: Mon, 15 Jan 2024 11:17:56 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] drm/amdgpu: Remove usage of the deprecated
 ida_simple_xx() API
Content-Language: en-US
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
 Alex Deucher <alexander.deucher@amd.com>, "Pan, Xinhui"
 <Xinhui.Pan@amd.com>, David Airlie <airlied@gmail.com>,
 Daniel Vetter <daniel@ffwll.ch>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
 amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
References: <c3b8e4bfb819d901e532e90a2ae0efa9eb661c55.1705245232.git.christophe.jaillet@wanadoo.fr>
From: =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
In-Reply-To: <c3b8e4bfb819d901e532e90a2ae0efa9eb661c55.1705245232.git.christophe.jaillet@wanadoo.fr>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZGowTHVKYk5zVG8yQjJiV285YjdQekpEVkJwZlpmU09DdlBWUVdacThjYk1y?=
 =?utf-8?B?K3J1Q0Z3VXB5d3JYMkcwUVBxNzRLSWUrTmxnSStPZ0hQcTdQVUF1T3kzZ1ow?=
 =?utf-8?B?RlNWdkRKcG84TVFUYldYTWtQUmlaRUFzbjlUd1EwU2g4T3N0Mi81c2Y2UGZP?=
 =?utf-8?B?UHU1TlY1TldJekJPNHIydXRkZkdxSER6YUFCMlJ0ZW9FQmRDMzBnTlUwZDJ2?=
 =?utf-8?B?RmhDNDMrZ2hoUkdiMjRKM1l3OGMxcEhLNktLMFkzZmdONENKMm9xUHRlOTRp?=
 =?utf-8?B?WmF6QVNYOFZWRnNaOXZoYjhHanlObGNTYkZvamkwcXcxQ2ZES0JkcVJ0ZGpQ?=
 =?utf-8?B?dVN1OUhjS21VQWtTTjhEOVdQYTNvSm4vNEdnTEV1Q1FXSldsVlFKS09WLzgr?=
 =?utf-8?B?UzREcmQ4NnZqcmxaNTNRWDNsclNuNlFmQkNPZlVtcTBid013STFhb2xoaUxV?=
 =?utf-8?B?TmxtallQUWp4dWt0QlBiM2tES1B1K0M5YkRKcys5YXdXRlA4MzJwN3NiaEY0?=
 =?utf-8?B?SWFwN29XNW5DNVJkVVNXaW5YYjdXa0FpY0FNcmpXSzdBL2oraGNjVFZGL2FX?=
 =?utf-8?B?cFNjNlFnaXpONjBLMGhFWnVTdUJxWEk3T2pldVZjMHoxL2NhNWNPdjlUbTk2?=
 =?utf-8?B?bWZZZzJmV3dyeE9KTE80MTRQZ2xVRm9veHd1ZDdLcFB3d0pVMS9JcEhVR09n?=
 =?utf-8?B?UGxYQ0xiV0EwTlc5MkxxWVNXVzJTdmhIY0VHajNncEg4SjQ1UmVLWms3eUIw?=
 =?utf-8?B?NGFKVk8wTHF3elJEekExaWoxRHNsVDhlcC9qV2pKSzdVMVc2cUhOU09hVHk3?=
 =?utf-8?B?Zm0xK0FQVXdqakQ3bDU0QUxkZTBZVWwrcm5PY2tzZHhaUUVSckNpbXNxdmtj?=
 =?utf-8?B?VmtlWWRUQ3pwRmU3UHVzTk5vNnU4VlphNk9ValNBU3JPdVFnNVVFc3RmdTcz?=
 =?utf-8?B?N2NLVnNMNGZIUG5TQXdrWG1lQ2ZjTFdOMTlZN0RqcWt1amRoaVErbE9YNnA2?=
 =?utf-8?B?S0tUbFRnK0dkeEdNcU1oSEwzOTVnb1J3TkV4Zi9McW9WRDNndU92YnNUbEpH?=
 =?utf-8?B?MUROb0xBbDVBenFmM1MxbnJuZ29BaTRCTytEdWpodFJjYklSQ3JCSktKek9L?=
 =?utf-8?B?dHVrcFZEMWZJSlF1K3lLY0dGRmExblAxQ0xDUVVJQkJaV0lMbEFLLzZ0TEps?=
 =?utf-8?B?NmNjTHJHb2NIRXlHdUpQZmlGMTIwK2d6aXdDTWoyQUxLcTNmTmt1UlBGRE5T?=
 =?utf-8?B?TWpXSUx5cmJMVDVCSGw3QU1vVndyYmZ3UU85MiswNHNGUFFiSFVob0MzWlpa?=
 =?utf-8?B?TDlBVk54TVJBQlo5SFJZa05aTTZtZmhuaGtkRkNTazBoMUFxWWQwU1ppREov?=
 =?utf-8?B?elQ4SHhzenFBNFVTcWRaWW8vSTdWNk5pMDZmN2dpV2s3TzI4VUJmU0lkQmlF?=
 =?utf-8?B?TUkwRFE0bFZEV2tUQmx5VEpVWVF5Y3FSL3lVYTVGNDdmUUJ5UjB2RW5WSzJk?=
 =?utf-8?B?M2UxaWZDS21mTFdwUExGL2dFdlg5TWhmUEtHc2d2ckllOHZYMXlKM0E1SE0v?=
 =?utf-8?B?RXQvcU9MZFhoWHRraE9OZUJEeFZPcUdxUUZ0bmxRRWIzWUxkc3JOSDYxOEtQ?=
 =?utf-8?B?TWdIVVE5WXBhZm9ua0tna0ptQ2d5SldsazhDNXp4U1UyaWNzWHRQTjJwTC9E?=
 =?utf-8?B?bmVoQjBQcTF2bVhOVytpWVQzZng3VEVLU2pITHlzSVNSS2ZCZkR4SWVwWi9W?=
 =?utf-8?B?dG1maGo1WGljZjZlTDhJbjdCdmUycXpCeWpZbkxSN0prL0FIbkpacXd6V3pa?=
 =?utf-8?B?VXhrNlJ2NExhSDlzSU5MbVhwZUpUWWpJc2RxYmFmcWMvVitRalJ1Nis3Y0wv?=
 =?utf-8?B?b1FTbVEza2ZTV09WNjR2ZVd1MWpBR1FSZ1EvdXVrRWlDVUlOekprSVVrRmJ2?=
 =?utf-8?B?Zkh5WWV4ZmhPYXJtZ1I0NnpQYWxlZ1dCeDV5d0I3VnRkWlhYNzRXOFZnUm5k?=
 =?utf-8?B?ZDkrUnlheFlNWEJVdVlDMEVwYVV0dStlNkszT2JwaUw3N3pybkRadW9tbUYx?=
 =?utf-8?B?Qm5Fc01ONTZ1b0tjaTNFeWhSYXNySE43K2M5b3ppQm5NWDdLcnc1SjlBU0tB?=
 =?utf-8?Q?zpT5JmREVSWhlBQQbKBWGt1xo?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3e3c3c88-0af7-4992-a0ca-08dc15b341e2
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5685.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2024 10:18:03.0939
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: S65iTwGO4/4PBdFkhVeN8gLNEHb5szd5ky9Zu4IMsGtTZfQcWZvLKaMAYpjLpRTA
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6297

Am 14.01.24 um 16:14 schrieb Christophe JAILLET:
> ida_alloc() and ida_free() should be preferred to the deprecated
> ida_simple_get() and ida_simple_remove().
>
> Note that the upper limit of ida_simple_get() is exclusive, but the one of
> ida_alloc_range() is inclusive. So a -1 has been added when needed.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
> index ddd0891da116..3d7fcdeaf8cf 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
> @@ -62,9 +62,8 @@ int amdgpu_pasid_alloc(unsigned int bits)
>   	int pasid = -EINVAL;
>   
>   	for (bits = min(bits, 31U); bits > 0; bits--) {
> -		pasid = ida_simple_get(&amdgpu_pasid_ida,
> -				       1U << (bits - 1), 1U << bits,
> -				       GFP_KERNEL);
> +		pasid = ida_alloc_range(&amdgpu_pasid_ida, 1U << (bits - 1),
> +					(1U << bits) - 1, GFP_KERNEL);
>   		if (pasid != -ENOSPC)
>   			break;
>   	}
> @@ -82,7 +81,7 @@ int amdgpu_pasid_alloc(unsigned int bits)
>   void amdgpu_pasid_free(u32 pasid)
>   {
>   	trace_amdgpu_pasid_freed(pasid);
> -	ida_simple_remove(&amdgpu_pasid_ida, pasid);
> +	ida_free(&amdgpu_pasid_ida, pasid);
>   }
>   
>   static void amdgpu_pasid_free_cb(struct dma_fence *fence,