Received: by 2002:a05:7412:8d11:b0:fa:4934:9f with SMTP id bj17csp445602rdb; Mon, 15 Jan 2024 02:26:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IGfv7/h0C4sc7RD6RvkOinXCzHREj9LClPNx0awG91VXBKjLU1FB0QSpxyoLoGQC+xqnBy4 X-Received: by 2002:ae9:f305:0:b0:781:94d7:9575 with SMTP id p5-20020ae9f305000000b0078194d79575mr7574385qkg.47.1705314404769; Mon, 15 Jan 2024 02:26:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705314404; cv=none; d=google.com; s=arc-20160816; b=Fmsd61Sx4CGfiAiVNjhppYQBXJLtLMztWQFC4Dv66ZtZEyOlHdw3vbeb1nLErk5TTx FDNnru57fpARae6oytWYXdvE3yrv5P9dE40wAF5RfCmCfJpbDXyM9AEu40w4bVmmKcOo EPUMwBuFGPGRUbvuh8o4NJ+Hr4u8YhxpMGkZad4REUrIr6//qolnguvUl4o/odva/l+Z oGWLiM3DfnD8dheggLHvszvDwKN82TYa1HdQ1QYwo060fS126HZEjsVZX+gtMyohgMBh nBZWqGfH/6fq1i2uY5dbaUsEYyHp85xwcDCatEfYZpA4zBkWMNanSP0wqo9dI4NLxZyC oYtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=CCs002bTp0dpYZEwjNsd+KgyGAUvCEUtLlhdrUILSlg=; fh=6pVrWhhI+1Qba8bvvuov4NFFiLQtYQ9SnJO9ZZec3x8=; b=racmAgFR0+ePM8L27fM/WLbaRRRWK1CW0+U+lZc2SrR9b6aXfwrouCi93ppG9guauR Ll9nJrjQvpK9REBJRTBbq+UUZ6xwpmrocGyjSnY+wiiTvPeaRmPYS6gCLSppj0RQtw65 quduvL5FOSXg9JT7KHJXN8dHYiHLm6IeFJaLj8G2jhft0huTuirTVdB/CMkNrWoJXYsX qqbI2mF/BtYepn5XAzXp9LazE+k+cxThSHCuXbK+JtkQ0MVPvkJjZ3y6z5jXzMie715e tTcKi/mQIBvjSFzJM7Ilkva1jmaJAxDQum13tN9RLG91PZG40wR+cJOTaFyI6N7TK0rA gPyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=F0aACSLS; spf=pass (google.com: domain of linux-kernel+bounces-25887-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-25887-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id oq7-20020a05620a610700b007832b3e9f96si7556268qkn.7.2024.01.15.02.26.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jan 2024 02:26:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-25887-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=F0aACSLS; spf=pass (google.com: domain of linux-kernel+bounces-25887-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-25887-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 752B81C21856 for ; Mon, 15 Jan 2024 10:26:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 446E312E6C; Mon, 15 Jan 2024 10:26:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="F0aACSLS" Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCE0F101C6 for ; Mon, 15 Jan 2024 10:26:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2cd0d05838fso96440401fa.1 for ; Mon, 15 Jan 2024 02:26:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1705314392; x=1705919192; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CCs002bTp0dpYZEwjNsd+KgyGAUvCEUtLlhdrUILSlg=; b=F0aACSLSJ4W4Oq2dVMI8+Xh9mgsWxLLqkJYEjGBVjuK2NCiQZVK03tLk5Q4B3Pq7QH aNRLbHmDDgHnX6bmf1e0HblfMQ81UULOiq+62Z9iMelWmrOul7jfiTXBtvn4csnc8Hgj F/nO+wZw7N4JNorpyoCscdHei3ANLTu2w1gOdu+IOiCx2eO3IkQ4E/Hi2DDce4d5UXlr NOG0psCHx3ozUjkJQKVtJLnABkBVxXbCEh2MT6o9PvZGArpRcJMIgvGriAyPAwl2/u11 vx2XQwcyPKahlwpx53X/F0/ji2r9ixUTdWdiYoWXYnLVvV/reu56ZOBMrtYtg33DOVD6 g4AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705314392; x=1705919192; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CCs002bTp0dpYZEwjNsd+KgyGAUvCEUtLlhdrUILSlg=; b=J93aR1/YKr3f/xb/VctJNQJ+TS3kH/Il+cUgnVoRHhbPgbz18W+MTQS8f7sHdDrwyP eW03SctXpZR3IGM7jNz/fgbArTKv6fB3jQuVQSFfCp4nStyRHvIEdeSabs1MUf6cNFS4 C6YT+ZPL3sud1EdG/pjhOJSGSCVUwjBKtfASJXpuBxw3FKuw6sQdr3bm9AfHTmj9ZNy+ V8hA4PGBdNnh0yqRSvFkDBVWHp5Mz0lRwkFahm3kg1d4U4v+RK0O/2ENG5ySD424XLPf wFVY0RXhNYZSDnwL2epAHlOjo9lHeKRKRD+57q+ts/L+q1NumZeNdj6j77plsxKBkiN3 SjEA== X-Gm-Message-State: AOJu0YwSbGfKZbHl5mjxF6BmzNSYV4Oj/wlAMMwHH7JsecB32xHowYVU 8Q/VNMt4BBbTSyeB4iBupTE+9rj5hyCT0g== X-Received: by 2002:a2e:8896:0:b0:2cd:6bf9:a7c7 with SMTP id k22-20020a2e8896000000b002cd6bf9a7c7mr2127657lji.61.1705314391768; Mon, 15 Jan 2024 02:26:31 -0800 (PST) Received: from [192.168.1.20] ([178.197.215.66]) by smtp.gmail.com with ESMTPSA id dh19-20020a0564021d3300b00557332d657fsm5331358edb.39.2024.01.15.02.26.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jan 2024 02:26:31 -0800 (PST) Message-ID: <6c29ce72-e303-406a-bb75-5b36b0cd8ee4@linaro.org> Date: Mon, 15 Jan 2024 11:26:29 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5] arm64: dts: qcom: qcm6490-idp: Add definition for three LEDs Content-Language: en-US To: hui liu , Dmitry Baryshkov Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240115-lpg-v5-1-3c56f77f9cec@quicinc.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 15/01/2024 11:18, hui liu wrote: > > > On 1/15/2024 5:56 PM, Dmitry Baryshkov wrote: >> On Mon, 15 Jan 2024 at 11:48, Hui Liu via B4 Relay >> wrote: >>> >>> From: Hui Liu >>> >>> Add definition for three LEDs to make sure they can >>> be enabled base on QCOM LPG LED driver. >> >> The "function" property is still placed incorrectly. Posting the next >> iteration before concluding the discussion on the previous one is not >> the best idea. > Do you mean I should update it as below? Seems there is no consumer to > use the function config, do we need to add now? Paste the output of dtbs_check for your board (or CHECK_DTBS=y for your Makefile target). Best regards, Krzysztof