Received: by 2002:a05:7412:8d11:b0:fa:4934:9f with SMTP id bj17csp446458rdb; Mon, 15 Jan 2024 02:29:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IHbrnY/xtnppP7irrm/A8e7bh/OjVfOU0Gpqm5ZPL2uq5Zo7AJmG1WlLqrKYdUnAjmQ6L42 X-Received: by 2002:a05:6a20:e68c:b0:19a:9d9f:6af9 with SMTP id mz12-20020a056a20e68c00b0019a9d9f6af9mr6308670pzb.73.1705314545071; Mon, 15 Jan 2024 02:29:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705314545; cv=none; d=google.com; s=arc-20160816; b=xXVx8fosQOuLizJIa4TY3g14h+LL4lu3b+dWrIKBR6+NmuBWM81XXNEEMBQyPrKN0V ju5DKt4h/nq5FhTJ2eYuHjEiWWh+oUbNCPkq1UPSLrVLN6flEbUMB2ggbxOmz9jy3AMB FR6Iv4VAptmSo8NvhJRJM1AnvIXYVOtArXl6CM04HlY3reAAV/1hUN2aNmW1/Ru2XhF1 F4j3TJ3A4vYuHqmCX9sjTvqqkgCK2fSA8EGw8PHIbB9YPDTwT7dUWhZO2TqcnVvgp5Eo 4DJoU/Q5D/DPGzLPg026/P1hj+NeGE9/7rKFmxNp7n6JGa10tviISjjPyAgUvsDbN/64 XOqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=8EDVcplyTD7Jj30L71TV/lmRnhLESsL7ZK2KGoKvnkg=; fh=irLPU+ryMC0v1ZyCjvOqy75GeGLVvObVHyC7vucjOpg=; b=G4Hs4kFriNBxsbb6FebHxAkbwMNzRBBTrIcIIwBSncNu2EPEP/wiMo+Sm2H0CtYb7w XDglhdgZbKtjiJaR9a5n0C89pwBA7AfKm5Ndxp2WrH7xZKSWy4ouTUMcAMwK62pgyCKX zcI3vZZv3XzY69iYk4pn4xnwXlxfg/AcVwNBwpvBLgglIMZukpCePR6tyatvtpsIS7Wn XzNbnEHZrVTvnT36QxINwIcNlKi5lNaQiuUux9Cp8l46L0eBR93zEHkD6AJazzZNsIJ7 /aVHMJmA9RSfl8QnVoVSl6umR0FXwhHNSPUDcVQB+1GcmW8yoeA1bcyeuM0Kq0uLD5qY 1ntw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-25890-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-25890-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id k192-20020a6284c9000000b006d9abe94a76si8585431pfd.67.2024.01.15.02.29.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jan 2024 02:29:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-25890-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-25890-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-25890-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 3786528236D for ; Mon, 15 Jan 2024 10:29:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 76EF512E63; Mon, 15 Jan 2024 10:28:57 +0000 (UTC) Received: from h3cspam02-ex.h3c.com (smtp.h3c.com [60.191.123.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 715C4101C1; Mon, 15 Jan 2024 10:28:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=h3c.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=h3c.com Received: from mail.maildlp.com ([172.25.15.154]) by h3cspam02-ex.h3c.com with ESMTP id 40FAQblH006444; Mon, 15 Jan 2024 18:26:37 +0800 (GMT-8) (envelope-from hu.yadi@h3c.com) Received: from DAG6EX02-IMDC.srv.huawei-3com.com (unknown [10.62.14.11]) by mail.maildlp.com (Postfix) with ESMTP id 053852004BC6; Mon, 15 Jan 2024 18:31:05 +0800 (CST) Received: from localhost.localdomain (10.99.206.12) by DAG6EX02-IMDC.srv.huawei-3com.com (10.62.14.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.1258.27; Mon, 15 Jan 2024 18:26:36 +0800 From: Hu Yadi To: , , , , , , , CC: , , , , <514118380@qq.com>, , "Hu.Yadi" Subject: [PATCH v4] selftests/landlock:Fix two build issues Date: Mon, 15 Jan 2024 18:24:09 +0800 Message-ID: <20240115102409.19799-1-hu.yadi@h3c.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BJSMTP02-EX.srv.huawei-3com.com (10.63.20.133) To DAG6EX02-IMDC.srv.huawei-3com.com (10.62.14.11) X-DNSRBL: X-SPAM-SOURCE-CHECK: pass X-MAIL:h3cspam02-ex.h3c.com 40FAQblH006444 From: "Hu.Yadi" Two issues comes up while building selftest/landlock on my side (gcc 7.3/glibc-2.28/kernel-4.19) the first one is as to gettid net_test.c: In function ‘set_service’: net_test.c:91:45: warning: implicit declaration of function ‘gettid’; [-Wimplicit-function-declaration] "_selftests-landlock-net-tid%d-index%d", gettid(), ^~~~~~ getgid net_test.c:(.text+0x4e0): undefined reference to `gettid' the second is compiler error gcc -Wall -O2 -isystem fs_test.c -lcap -o selftests/landlock/fs_test fs_test.c:4575:9: error: initializer element is not constant .mnt = mnt_tmp, ^~~~~~~ Fixes: 04f9070e99a4 ("selftests/landlock: Add tests for pseudo filesystems") Fixes: a549d055a22e ("selftests/landlock: Add network tests") this patch is to fix them Signed-off-by: Hu.Yadi Suggested-by: Jiao Reviewed-by: Berlin --- Changes v4 -> v3: fix gettid error from kernel test robot https://lore.kernel.org/oe-kbuild-all/202401151147.T1s11iHJ-lkp@intel.com/ Changes v3 -> v2: - add helper of gettid instead of __NR_gettid - add gcc/glibc version info in comments Changes v1 -> v2: - fix whitespace error - replace SYS_gettid with _NR_gettid tools/testing/selftests/landlock/fs_test.c | 5 ++++- tools/testing/selftests/landlock/net_test.c | 7 ++++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/landlock/fs_test.c b/tools/testing/selftests/landlock/fs_test.c index 18e1f86a6234..a992cf7c0ad1 100644 --- a/tools/testing/selftests/landlock/fs_test.c +++ b/tools/testing/selftests/landlock/fs_test.c @@ -4572,7 +4572,10 @@ FIXTURE_VARIANT(layout3_fs) /* clang-format off */ FIXTURE_VARIANT_ADD(layout3_fs, tmpfs) { /* clang-format on */ - .mnt = mnt_tmp, + .mnt = { + .type = "tmpfs", + .data = "size=4m,mode=700", + }, .file_path = file1_s1d1, }; diff --git a/tools/testing/selftests/landlock/net_test.c b/tools/testing/selftests/landlock/net_test.c index 929e21c4db05..d50f2920ed82 100644 --- a/tools/testing/selftests/landlock/net_test.c +++ b/tools/testing/selftests/landlock/net_test.c @@ -21,6 +21,11 @@ #include "common.h" +static pid_t landlock_gettid(void) +{ + return syscall(__NR_gettid); +} + const short sock_port_start = (1 << 10); static const char loopback_ipv4[] = "127.0.0.1"; @@ -88,7 +93,7 @@ static int set_service(struct service_fixture *const srv, case AF_UNIX: srv->unix_addr.sun_family = prot.domain; sprintf(srv->unix_addr.sun_path, - "_selftests-landlock-net-tid%d-index%d", gettid(), + "_selftests-landlock-net-tid%d-index%d", landlock_gettid(), index); srv->unix_addr_len = SUN_LEN(&srv->unix_addr); srv->unix_addr.sun_path[0] = '\0'; -- 2.23.0