Received: by 2002:a05:7412:8d11:b0:fa:4934:9f with SMTP id bj17csp454502rdb; Mon, 15 Jan 2024 02:52:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IG1umQXEQaDKJrFxi8rT4d0C5HekfRCR5fCTxNm9FpVZ3h26oolgShleMK4DoJXu+Qiu/8E X-Received: by 2002:a05:6a21:6d9f:b0:19a:7c3c:ae00 with SMTP id wl31-20020a056a216d9f00b0019a7c3cae00mr5528824pzb.21.1705315946971; Mon, 15 Jan 2024 02:52:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705315946; cv=none; d=google.com; s=arc-20160816; b=x01j6zcVXSVYWjNE5voI7vmVH1ldIi3iQIPqjN3DWU61IHvHzR+11NKIlFfObDRQWp udDJw+fr/GobQXpQpETNid03apCdHwfwWBB+ZvhP6AysYKGY+XbCpluCn49npXCvsjgG mCY3tkZhuCBu/YFzCfizF5VumpGruAUF7NwTFb2vb8OTRNoa6oteisD1crnXLMKDlC9l 930DfDPY55KieFRr6kT5/ndJGRsdqjoLFuGxHtgfry/NdcgQdmrljBCJ9IIOTXyzPyT3 USEFg/LpA2rb7b4a74q7et1ksL0kVTW9W5sZUtVyCzFVJrIwVnmfEDNUBqRAq6PeAfhX pm9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=etknRYg9NALmVcPptGWAGWmpFTn+NI1j2A0OKWF+POE=; fh=l1ypY5qQnwrNBfdzZsOIJXfOXT7S4l11DUrrvPW9x8A=; b=Z8lF8QEKua/WyBDA5wCpsLh47DZjM5amy1yiY6juSfE8sAAd6H0DGirMMaSOyN/o7U tD0mYPdRt/apZvGVP4vk6Wtb+2h4RowbW+mdepRaQvXIJg09QxTGlOlL16Uxl6wmQHhZ ZCO+sswiXG/Vu3WJvvS6qW49HDWnMhdaAV5jhyLRaegLczy5PQGoeW3NBRtxPGapuM+o OGOAkb3OOjXR27aufg2VgUNukqdQtJHFUGBo9sxq/6zLnpfjWJM0fBrLVjha+a9wPtZ9 PdJAT1gKz8XutSWxi0rZ01ANaIzX8/kBKEGxVMGa0NoK34cJDzdl0LLJIxbuofAuOJTN TuAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CI8t6imj; spf=pass (google.com: domain of linux-kernel+bounces-25901-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-25901-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id k4-20020a17090a9d8400b0028d956cf50fsi8783824pjp.99.2024.01.15.02.52.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jan 2024 02:52:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-25901-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CI8t6imj; spf=pass (google.com: domain of linux-kernel+bounces-25901-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-25901-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 9C6BD2824FE for ; Mon, 15 Jan 2024 10:52:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A15F72BAFD; Mon, 15 Jan 2024 10:52:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CI8t6imj" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8F1018E00; Mon, 15 Jan 2024 10:52:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DF796C433F1; Mon, 15 Jan 2024 10:52:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705315935; bh=yNMnDGNncTu5nTM1tbDByTT3u4h9k8S1TWf2WSI5WYk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CI8t6imjMbeNVG10AzRCaWdkzIXkQ/3oJNXQ3qU26ho8eV34BV5R3mkA0KAQVoYCy h+nuurAfJAV/OrXWJ/BeAhjstG85Rcwvba8nyryGmoKW1Yo5UMCqLRDNk5bTTJcPEe UmFA0g40BtxLHym/qG/R0umbgKJYzRJ0uukpajRhRcJdYnMT6P7olbaAnUl62B/pMM fzju+e4yMF5Y7qNrx+uu1HYGpEEVHO0wZnhh6fMt/gZnPfRfWJ69DYFv4gHALUWAk2 QohT+d+Q8JENFO/PMxetrmc/fQmo6rkbr3hOSxgnfZa6uHKZykfJ/ZCeCgz2HJU68b qQUBwXAF4IJPw== Date: Mon, 15 Jan 2024 10:52:09 +0000 From: Simon Horman To: Pavel Tikhomirov Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Florian Westphal , David Ahern , Jozsef Kadlecsik , Kees Cook , Nikolay Aleksandrov , Pablo Neira Ayuso , Roopa Prabhu , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, bridge@lists.linux.dev, kernel@openvz.org Subject: Re: [PATCH v3 2/4] netfilter: nf_queue: remove excess nf_bridge variable Message-ID: <20240115105209.GP392144@kernel.org> References: <20240111150645.85637-1-ptikhomirov@virtuozzo.com> <20240111150645.85637-3-ptikhomirov@virtuozzo.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240111150645.85637-3-ptikhomirov@virtuozzo.com> On Thu, Jan 11, 2024 at 11:06:38PM +0800, Pavel Tikhomirov wrote: > We don't really need nf_bridge variable here. And nf_bridge_info_exists > is better replacement for nf_bridge_info_get in case we are only > checking for existence. > > Signed-off-by: Pavel Tikhomirov Reviewed-by: Simon Horman