Received-SPF: pass (google.com: domain of linux-kernel+bounces-25922-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 15 Jan 2024 11:28:14 +0000
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Kunwu Chan <chentao@kylinos.cn>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	f.fainelli@gmail.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] net: phy: Fix possible NULL pointer dereference
 issues caused by phy_attached_info_irq
Message-ID: <ZaUWztbMPhbApPIH@shell.armlinux.org.uk>
References: <20240115085018.30300-1-chentao@kylinos.cn>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240115085018.30300-1-chentao@kylinos.cn>
Sender: Russell King (Oracle) <linux@armlinux.org.uk>

On Mon, Jan 15, 2024 at 04:50:18PM +0800, Kunwu Chan wrote:
> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> index ed0b4ccaa6a6..819574a06036 100644
> --- a/drivers/net/phy/phylink.c
> +++ b/drivers/net/phy/phylink.c
> @@ -1886,7 +1886,7 @@ static int phylink_bringup_phy(struct phylink *pl, struct phy_device *phy,
>  	irq_str = phy_attached_info_irq(phy);
>  	phylink_info(pl,
>  		     "PHY [%s] driver [%s] (irq=%s)\n",
> -		     dev_name(&phy->mdio.dev), phy->drv->name, irq_str);
> +		     dev_name(&phy->mdio.dev), phy->drv->name, irq_str ? irq_str : "");


		     dev_name(&phy->mdio.dev), phy->drv->name,
		     irq_str ? irq_str : "");

please.

Also, please hold off posting v3 until at least 24 hours have passed.

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!