Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933167AbXLMVXb (ORCPT ); Thu, 13 Dec 2007 16:23:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753111AbXLMVXU (ORCPT ); Thu, 13 Dec 2007 16:23:20 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:45674 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753943AbXLMVXT (ORCPT ); Thu, 13 Dec 2007 16:23:19 -0500 Date: Thu, 13 Dec 2007 22:22:21 +0100 From: Ingo Molnar To: Glauber de Oliveira Costa Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, glommer@gmail.com, tglx@linutronix.de, ehabkost@redhat.com, jeremy@goop.org, avi@qumranet.com, anthony@codemonkey.ws, virtualization@lists.linux-foundation.org, rusty@rustcorp.com.au, ak@suse.de, chrisw@sous-sol.org, rostedt@goodmis.org, hpa@zytor.com, zach@vmware.com, roland@redhat.com Subject: Re: [PATCH] avoid ifdefs in desc.h, getting rid of pack_ldt and pack_tss Message-ID: <20071213212221.GA16747@elte.hu> References: <11975561713425-git-send-email-gcosta@redhat.com> <20071213202800.GD25130@elte.hu> <20071213205838.GA9649@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071213205838.GA9649@elte.hu> User-Agent: Mutt/1.5.17 (2007-11-01) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1209 Lines: 37 * Ingo Molnar wrote: > just got the crash below. config attached. Suspects are: > > Subject: unify struct desc_ptr > Subject: unify paravirt pieces of descriptor handling i've bisected it down to: Subject: avoid ifdefs in desc.h, getting rid of pack_ldt and pack_tss From: Glauber de Oliveira Costa i have removed this patch from x86.git. Btw., note the advantage of small deltas, so only your v3->v4 delta patch got reverted instead of the whole 19-patch v3 kit ;-) > could we _please_ use basic tools as vmlinux size comparison and > objcompare when unifying, to make sure it's a 100% identity > conversion? case in point, the patch claims: > > No functional change is made. but vmlinux before/after size comparison shows: text data bss dec hex filename 8802894 1224910 3526656 13554460 ced31c vmlinux.before 8803042 1224910 3526656 13554608 ced3b0 vmlinux.after Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/