Received: by 2002:a05:7412:8d11:b0:fa:4934:9f with SMTP id bj17csp579139rdb; Mon, 15 Jan 2024 06:57:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IE+Fu/fk9CInk8yAGTxf6s5SD+HCB7+SNu0CIqSRQahfCm0BAcTWdAahX07IaS+5R5FCR2l X-Received: by 2002:a17:90b:2350:b0:28c:3d67:2d1a with SMTP id ms16-20020a17090b235000b0028c3d672d1amr3696746pjb.92.1705330619850; Mon, 15 Jan 2024 06:56:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705330619; cv=none; d=google.com; s=arc-20160816; b=09UMcrzE1xNFlzhmW6j5MDebwHR5sn3mYJ97BpxpWxBx2dBd/TCbZzD0mvHfos6CxN OzHPQsV5N6MY4M5rP7tv1Ceq//P99R7zdJROHaGU+XDdAcDGOsn6/yR8qH8rUNmiqk61 Q0wxtvUgvYKNrFgEjBIYFitVkipoA/ZPTdQLui2Uk7u12+agJumi/aNbwDJz5K3pzF38 mp9CdSl3ewUWyvGvm6TAH+iOJwzLr6yC6FBbPfwv55qNLFQk7nmpsUjieg6ZeS4t6AIs gdC2XDLrKh3nlny+rDzVZQMfIQGYfimbb+YO2k9VVooCfkMNHgUbjkcxdS/yEnUzV3LW waTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=NfVkFECEYLg7phsst9IiGQNivefIMr6weuO7dvL4wTQ=; fh=rAXVRNy+s6/0iCbFoOvHCZPduU6Dl9g8kRN5Eb9fti0=; b=szufQw33rZ8HFLsNYEoYwXAohpOKYSLohsJIVQAWXkc8yWLY6D7ya4ZrnOcr6mmFHF 8S1UroUwTf6kjL43H2CinIsilJcGKe1alOlLfTvnAu0zgcGUL/QNChv3b6disy0eMIsC bi8bQvud3ubf113NUbd8EeCkChGgjESRhIEc6GOhtlvBqSu2Pmjj/6H1GxD9l0MiqSbg p146y+HxS7aUeQQb4bAntJk6vuIpd8e4L6Bf+JGnDAsHhw0CQnxJG8WbEzvTTkUg6Utv pVMxc0l9fBInEkxyzkYjSPkqC90jlLbBrfs0W2nhfooFS6xLvMVCHGbhuG9YbA4QwROE cAWA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-26144-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-26144-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id kn5-20020a170903078500b001cf8e9e8813si8759643plb.315.2024.01.15.06.56.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jan 2024 06:56:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-26144-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-26144-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-26144-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id E5AF0B222D6 for ; Mon, 15 Jan 2024 14:53:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 707561774C; Mon, 15 Jan 2024 14:50:34 +0000 (UTC) Received: from mail.enpas.org (zhong.enpas.org [46.38.239.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE57210796; Mon, 15 Jan 2024 14:50:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=enpas.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=enpas.org Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail.enpas.org (Postfix) with ESMTPSA id B3927101657; Mon, 15 Jan 2024 14:50:28 +0000 (UTC) From: Max Staudt To: "Daniel J . Ogorchock" , Jiri Kosina , Benjamin Tissoires Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, max@enpas.org Subject: [PATCH v1] HID: nintendo: Don't fail on setting baud rate Date: Mon, 15 Jan 2024 23:50:00 +0900 Message-Id: <20240115145000.12777-1-max@enpas.org> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Some third-party controllers can't change the baud rate. We can still use the gamepad as-is, so let's do that. Signed-off-by: Max Staudt --- drivers/hid/hid-nintendo.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-nintendo.c b/drivers/hid/hid-nintendo.c index 997c3a1adaca..8cba0612c3ae 100644 --- a/drivers/hid/hid-nintendo.c +++ b/drivers/hid/hid-nintendo.c @@ -2164,8 +2164,11 @@ static int joycon_init(struct hid_device *hdev) /* set baudrate for improved latency */ ret = joycon_send_usb(ctlr, JC_USB_CMD_BAUDRATE_3M, HZ); if (ret) { + /* + * We can function with the default baudrate. + * Provide a warning, and continue on. + */ hid_err(hdev, "Failed to set baudrate; ret=%d\n", ret); - goto out_unlock; } /* handshake */ ret = joycon_send_usb(ctlr, JC_USB_CMD_HANDSHAKE, HZ); -- 2.39.2