Received-SPF: pass (google.com: domain of linux-kernel+bounces-26260-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 15 Jan 2024 12:30:50 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: Yan Zhao <yan.y.zhao@intel.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, pbonzini@redhat.com,
	seanjc@google.com, olvaffe@gmail.com, kevin.tian@intel.com,
	zhiyuan.lv@intel.com, zhenyu.z.wang@intel.com, yongwei.ma@intel.com,
	vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com,
	joro@8bytes.org, gurchetansingh@chromium.org, kraxel@redhat.com,
	zzyiwei@google.com, ankita@nvidia.com, alex.williamson@redhat.com,
	maz@kernel.org, oliver.upton@linux.dev, james.morse@arm.com,
	suzuki.poulose@arm.com, yuzenghui@huawei.com
Subject: Re: [PATCH 0/4] KVM: Honor guest memory types for virtio GPU devices
Message-ID: <20240115163050.GI734935@nvidia.com>
References: <20240105091237.24577-1-yan.y.zhao@intel.com>
 <20240105195551.GE50406@nvidia.com>
 <ZZuQEQAVX28v7p9Z@yzhao56-desk.sh.intel.com>
 <20240108140250.GJ50406@nvidia.com>
 <ZZyG9n0qZEr6dLlZ@yzhao56-desk.sh.intel.com>
 <20240109002220.GA439767@nvidia.com>
 <ZZyrS4RiHvktDZXb@yzhao56-desk.sh.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZZyrS4RiHvktDZXb@yzhao56-desk.sh.intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?H3q3n5AEbJ46yj8W9v4c3wGHygdVGb0qNtsm49bLALtlY8jJmEIV57iRnMT4?=
 =?us-ascii?Q?JjH5VvrIRoOdDBypeyTNtVjCuVHNa1laP/THKf/a/ptuj5Gsrcq9dUWNypB3?=
 =?us-ascii?Q?lbsIXrWAV6COficJiSxiDFckA9HKwA6q2mTXx2AZS9IKzbdcaOF7dpASn8Jb?=
 =?us-ascii?Q?Vqnrau5aKg8+FVwVkIo9OdxgE1U0/ndpraEOfZ6qcWKd0d8RBQp2cMBTkiD7?=
 =?us-ascii?Q?9mEy4amQhKmVnhz5/gl99ZjXbyQdmJXlvyjl3VXf11hEwYThqDHfuWQ0A+b3?=
 =?us-ascii?Q?PmEJtoR5AFm4gO2jw9MA3NgklS3PGwV4z40vcnTY+sZpYJ9LkSwsdLSgcGtV?=
 =?us-ascii?Q?9sMUzvVzG0YIFZDGEav6Miv2geEWUgNGcy3N+gdIaosvJUuukYhuOjLLHiAR?=
 =?us-ascii?Q?zWFmuhILvhTHD/PBdnsSPRAXbIM9xIhMASm3z+uBFuzxb5Yvz1moQq9v5j2Y?=
 =?us-ascii?Q?2m35LAd6AvgnASaswO6xHJg2DXUYlbOpbJAaB8LjcDK7t9rb8ARtsCuGisKV?=
 =?us-ascii?Q?rCzxhIn9jdzlRreYzTfE3omihfy1aVVP75l3fB4IGMxe0sDh3ySUBmrM1Jf/?=
 =?us-ascii?Q?rhLgQrttFk2FKbLcgd3ieZeI1SN/TRk5EiLVOEhekk9kqFO46FN4e3PPaFHE?=
 =?us-ascii?Q?jV+kV81pjm6nylHN6syXK/kgiLXe5k8eKV8XQUbOXBLC0YhPQkjA01oVo3nT?=
 =?us-ascii?Q?Uu26oBXpOlxuUftClOusyw1iDHtKlUbE7UFGNAoObgtT5LiLggKRwtMwEWXI?=
 =?us-ascii?Q?ycil3YjodWkBNTfEzNcmeCL2Ga7Ghx4lNrCyDlJn3toxNqHOGgrocFTO+nmU?=
 =?us-ascii?Q?ztk67WySrhiEC10Nh0tNz7EEgCTpbupKVV8cu5LhkJNRSZl5OI2s1gmkOmhe?=
 =?us-ascii?Q?lPrHen2IbWCd7zyLtyVEvtXSPwBqJMzHjhE5NwGgu/YSQ91+wybWJcRvHdko?=
 =?us-ascii?Q?XZ5oQd5xzXSOGlAqeV4Cf/6hqQXwUSu/tVWTVGkYvsziBSEyW+ygRU3v/ENs?=
 =?us-ascii?Q?SV1I/V9TI4QXCO+BXCK6z4pRxk6NEQQt3yKD3pqwftMFl765jvM2c2V3i9a2?=
 =?us-ascii?Q?NFqoadlbG27fTiZB9sClNTVprv4uaYpWtQHkZeQlGRAV49ns1SMECagI82sE?=
 =?us-ascii?Q?KYZb5Fa4R2xbQjPjRWuONXaJPWwNRq6nHbhfN4idC5P6Q/tPpv9A13QD67kz?=
 =?us-ascii?Q?96xgtWrd7ubwpl3dytZDoMW17Fh/XmeOjXqUYnRvrvXUvH2/IzXEQZ9FeQNX?=
 =?us-ascii?Q?5wzcErzknGi24il6BuU5s/iuefB2qUzer/xotmsBS9P7bz6713Lru4qVt2vb?=
 =?us-ascii?Q?xXNWHDveYaAQkL4oMraTv73cDVsXOvQDqLJvGSjO6jw7/SELfNXhNpH002Uk?=
 =?us-ascii?Q?ghWg5tODPF6ge5ZyguhlTWjHqMBOC7P7Ql+52OnR4EGSfVs4yzgtuZClE5T1?=
 =?us-ascii?Q?8giKRBPN3+e2swhIGGCJwor3HW0Pok+ZlUWgokfSidmWZEaqpHFdt2jqwjCn?=
 =?us-ascii?Q?CeBGjZaUXa1VfggF7PqsLmTEeGWB3aIE7FcdsLpQKMwNS6FTTfI9ZH3Yl1pM?=
 =?us-ascii?Q?ls1TIRmeyPupuu17nGNowy1Lo7LeXlmJck3AMNVK?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c5c896e-532e-48ff-446d-08dc15e75641
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2024 16:30:51.2101
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7AIHJwb71f8rhhBjwWloZUpy8nJwJnUKouE+dKUDacEXUY8nQEFSHBPDbiDj5qa6
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6121

On Tue, Jan 09, 2024 at 10:11:23AM +0800, Yan Zhao wrote:

> > Well, for instance, when you install pages into the KVM the hypervisor
> > will have taken kernel memory, then zero'd it with cachable writes,
> > however the VM can read it incoherently with DMA and access the
> > pre-zero'd data since the zero'd writes potentially hasn't left the
> > cache. That is an information leakage exploit.
>
> This makes sense.
> How about KVM doing cache flush before installing/revoking the
> page if guest memory type is honored?

I think if you are going to allow the guest to bypass the cache in any
way then KVM should fully flush the cache before allowing the guest to
access memory and it should fully flush the cache after removing
memory from the guest.

Noting that fully removing the memory now includes VFIO too, which is
going to be very hard to co-ordinate between KVM and VFIO.

ARM has the hooks for most of this in the common code already, so it
should not be outrageous to do, but slow I suspect.

Jason