Received-SPF: pass (google.com: domain of linux-kernel+bounces-26283-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <8c5afb4e52e0c5a6dd88f6b7eaa7bc2e97ba31ad.camel@linaro.org>
Subject: Re: [PATCH] dt-bindings: ignore paths outside kernel for
 DT_SCHEMA_FILES
From: =?ISO-8859-1?Q?Andr=E9?= Draszik <andre.draszik@linaro.org>
To: Michal Simek <michal.simek@amd.com>, Conor Dooley <conor@kernel.org>
Cc: Rob Herring <robh@kernel.org>, Rob Herring <robh+dt@kernel.org>, 
 Masahiro Yamada <masahiroy@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
 Mathieu Poirier <mathieu.poirier@linaro.org>, linux-kernel@vger.kernel.org,
  devicetree@vger.kernel.org, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@linaro.org>
Date: Mon, 15 Jan 2024 16:57:26 +0000
In-Reply-To: <ffd6f60e-fea9-4426-a981-badd3c68cd4d@amd.com>
References: <20231220145537.2163811-1-andre.draszik@linaro.org>
	 <170432630603.2042234.10993333941885772911.robh@kernel.org>
	 <827695c3-bb33-4a86-8586-2c7323530398@amd.com>
	 <bcd89ef7a43eb7d652f045c029d8e108adf7ba32.camel@linaro.org>
	 <20240115-fragment-clean-95ef01dd8b20@spud>
	 <ffd6f60e-fea9-4426-a981-badd3c68cd4d@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.1-1 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2024-01-15 at 17:37 +0100, Michal Simek wrote:
>=20
>=20
> On 1/15/24 17:29, Conor Dooley wrote:
> > On Mon, Jan 15, 2024 at 09:40:37AM +0000, Andr=C3=A9 Draszik wrote:
> > > Hi,
> > >=20
> > > On Mon, 2024-01-15 at 10:20 +0100, Michal Simek wrote:
> > > > This patch is causing issue for me. Look at log below.
> > > > I am running it directly on the latest linux-next/master.
> > > >=20
> > > > Thanks,
> > > > Michal
> > > >=20
> > > > $ make DT_SCHEMA_FILES=3D"Documentation/devicetree/bindings/arm/arm=
,cci-400.yaml"
> > > > dt_binding_check
> > >=20
> > > It'll work if you drop the 'Documentation/devicetree/bindings' part f=
rom the path, as
> > > it is implied since bindings can only be in that directory anyway:
> > >=20
> > > =C2=A0=C2=A0=C2=A0=C2=A0 make DT_SCHEMA_FILES=3D"arm/arm,cci-400.yaml=
" dt_binding_check
> > > =C2=A0=C2=A0=C2=A0=C2=A0 make DT_SCHEMA_FILES=3D"arm,cci-400.yaml" dt=
_binding_check
> > >=20
> > > both work.
> >=20
> > Requiring that is pretty user unfriendly though I think, passing the
> > full path from the root directory of the kernel tree would be my
> > assumption of the "default".
>=20
> I am using full path like this for years.

I just just went by Documentation/devicetree/bindings/writing-schema.rst
which doesn't suggest adding Documentation/devicetree/bindings/. In an
attempt to make it more robust for anybody following this doc, I opted
for the current implementation.

> I can fix my scripts but would be good to consider correct path inside th=
e=20
> kernel is something what this patch should also allow.
> Because path above is correct and it is not outside of the kernel that's =
why at=20
> least commit message should be massage a little bit.

I hear you, and I'll make a v2 to not imply the bindings directory.


Cheers,
A.