Received-SPF: pass (google.com: domain of linux-kernel+bounces-26313-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 15 Jan 2024 13:22:13 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: Yi Liu <yi.l.liu@intel.com>
Cc: joro@8bytes.org, alex.williamson@redhat.com, kevin.tian@intel.com,
	robin.murphy@arm.com, baolu.lu@linux.intel.com, cohuck@redhat.com,
	eric.auger@redhat.com, nicolinc@nvidia.com, kvm@vger.kernel.org,
	mjrosato@linux.ibm.com, chao.p.peng@linux.intel.com,
	yi.y.sun@linux.intel.com, peterx@redhat.com, jasowang@redhat.com,
	shameerali.kolothum.thodi@huawei.com, lulu@redhat.com,
	suravee.suthikulpanit@amd.com, iommu@lists.linux.dev,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	zhenzhong.duan@intel.com, joao.m.martins@oracle.com,
	xin.zeng@intel.com, yan.y.zhao@intel.com
Subject: Re: [PATCH 8/8] iommu/vt-d: Add set_dev_pasid callback for nested
 domain
Message-ID: <20240115172213.GM734935@nvidia.com>
References: <20231127063428.127436-1-yi.l.liu@intel.com>
 <20231127063428.127436-9-yi.l.liu@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231127063428.127436-9-yi.l.liu@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Jw4v51kUN6f8VscH8ne/RG5hjfLn3WzNto5dSeXf/abAA5GCzxVKz+Ixy88k?=
 =?us-ascii?Q?D/Y8DTCEf37J0IGmlJHV0L9T9G0EKk7qKE0ETbPcAHCHLhRFZ5h9WVPiXNPF?=
 =?us-ascii?Q?viRjWhpD4qJ2K05aKjZCUIjAR5nnWulQSngeFfnjIQ/Q5SLGpIveYQfaqr4z?=
 =?us-ascii?Q?BpTk4sTwd9TIdcdGRLW60YDoDMY7ylXydSUVHumdLdzBETeF2BceCDGyZla0?=
 =?us-ascii?Q?lj8/lirsU/0RSp4sXaxgtuKrqgg0Q/eu7ZUJ+ONv0K8NwE20k8uUpnbTDkT+?=
 =?us-ascii?Q?BmvqV51dcZk1V72XmB5cYvIkuIkW+wDYL+SScV6Xjqhu2O2gvQI45KktzKyx?=
 =?us-ascii?Q?XBIDh0USWe/TmtqcI/PzUCGfwc4mXph72Kumyxx1MK/64p+31YTEDJPIixia?=
 =?us-ascii?Q?5cX91aPI77NKzcf2NAwraUQlGkRh3lJeK4QV0Vs9r7F+F+zVtXAunFRcZMmt?=
 =?us-ascii?Q?IUBTjFbZNm7yDNwqbS+DnwUU2QUtQ1mpLwc9Yc9mPlvSTdOxNQvXsIwzL2KY?=
 =?us-ascii?Q?j5SU+H+bo//ZrYeeDydy5aTV/JwaFK36qZ/WmyOUiUhl9mbs6gW62zoXaugg?=
 =?us-ascii?Q?bAJjzbvXwqiEMomxoR3NapE4ISbzxSwvDybBsO4A+k6L2joqq8MUg9U/FetC?=
 =?us-ascii?Q?oh8ucRlE3bZQ09RNJfdbJ7rAvCACMKnvLkZd9SSBJon2h5p14DFE3kEnOcz0?=
 =?us-ascii?Q?JlmCnWsKOR/MOQoTqxhM1FbtpdEjxl9ceBoKTLEBz/QFiIX10q6dkMVykafH?=
 =?us-ascii?Q?moEdDURFMDElgoX1Hb/vBv2examyLy2fYZZBEzhOqhnQYi2Kw8bDsG+/tI+S?=
 =?us-ascii?Q?oYSJCxogRvabmRoK/OhUcPcoNjGkhekgrCZScX2H16F1lijzapcXohtTsk+D?=
 =?us-ascii?Q?6hyu9/n8Emnxpyx2cPD//fqMJ2ZSgSxqc8LbpwSfZIyQN6XY+xHZQnrJxNcv?=
 =?us-ascii?Q?+H6mQkeOJ5Movv7oY3Pr2Wft5dQ+N6BCG4L2uSIeUjjJTX/xnAI/sc8Hy/gY?=
 =?us-ascii?Q?DrQfEkNu1P+rD1T3gTnk/z8Z3vuvnekxcjcTsKEQZ/yLxrd5faWXP7jY7exD?=
 =?us-ascii?Q?NOR7RvOXpFcNPWcZlbSdYyAXoF3BrtOQFMqVpBfihaRm4/dvoZVyCde6gqvf?=
 =?us-ascii?Q?+z6DsjansM3OJSCfo5fbjP3CGiSR3w6S1y6RP18CpZc3/t5sJEYFfSTxEelv?=
 =?us-ascii?Q?JtSbDVXiGBEzWZBGiTNesaX8jjgGN3LBRcX+9BIDdT1AV6sXQfg2fBk4xOPY?=
 =?us-ascii?Q?IzVC/3zjRlbXAlgbZc/1D8anp0s5L9XcARCxlJLR0KlhkHOlI+q68xAI6Aiv?=
 =?us-ascii?Q?EA4bAlDy2c4pVHAjKDIuZqHZdbpDZa2Psr5nvpU8EGqelSPR/VvmkwGRMnCJ?=
 =?us-ascii?Q?vLIKijHbh3BhutWtButeCU8eloDoOpWHINnQinqFAwhK9g07+HWh6uQVaMtf?=
 =?us-ascii?Q?4tfofNHGiZiTie4Zqha4tz6BNZG0i6Yg/gzqOSaRGO/aZqBpbc0BG40483hf?=
 =?us-ascii?Q?ZQwYUDiX4BjfiZORYNfVvzPt9R966YEOeu8NCKTWNN7ldHZQ145NHVcZv27O?=
 =?us-ascii?Q?vOOOY37K4Co71MSrrHB5HDPHz+XQf3vug2Wbl040?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ada12b04-1a3c-4bcb-88d8-08dc15ee83f3
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2024 17:22:14.1677
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YeAg1MsCMZvXFu1ss7huLt+uT3vcvjxK7k+T1lbd6wEblOdIvRE9GkmilvEZjeyN
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4477

On Sun, Nov 26, 2023 at 10:34:28PM -0800, Yi Liu wrote:

> +static int intel_nested_set_dev_pasid(struct iommu_domain *domain,
> +				      struct device *dev, ioasid_t pasid)
> +{
> +	struct device_domain_info *info = dev_iommu_priv_get(dev);
> +	struct dmar_domain *dmar_domain = to_dmar_domain(domain);
> +	struct intel_iommu *iommu = info->iommu;
> +	struct dev_pasid_info *dev_pasid;
> +	unsigned long flags;
> +	int ret = 0;
> +
> +	if (!pasid_supported(iommu))
> +		return -EOPNOTSUPP;
> +
> +	if (iommu->agaw < dmar_domain->s2_domain->agaw)
> +		return -EINVAL;
> +
> +	ret = prepare_domain_attach_device(&dmar_domain->s2_domain->domain, dev);
> +	if (ret)
> +		return ret;
> +
> +	dev_pasid = kzalloc(sizeof(*dev_pasid), GFP_KERNEL);
> +	if (!dev_pasid)
> +		return -ENOMEM;
> +
> +	ret = domain_attach_iommu(dmar_domain, iommu);
> +	if (ret)
> +		goto err_free;
> +
> +	ret = intel_pasid_setup_nested(iommu, dev, pasid, dmar_domain);
> +	if (ret)
> +		goto err_detach_iommu;
> +
> +	dev_pasid->dev = dev;
> +	dev_pasid->pasid = pasid;
> +	spin_lock_irqsave(&dmar_domain->lock, flags);
> +	list_add(&dev_pasid->link_domain, &dmar_domain->dev_pasids);
> +	spin_unlock_irqrestore(&dmar_domain->lock, flags);
> +
> +	return 0;
> +err_detach_iommu:
> +	domain_detach_iommu(dmar_domain, iommu);
> +err_free:
> +	kfree(dev_pasid);
> +	return ret;
> +}

This seems alot longer than I'd think it should be, why isn't it
exactly the same code as the other set_dev_pasid's?

Jason