Received-SPF: pass (google.com: domain of linux-kernel+bounces-26308-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 15 Jan 2024 13:18:52 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: Yi Liu <yi.l.liu@intel.com>
Cc: joro@8bytes.org, alex.williamson@redhat.com, kevin.tian@intel.com,
	robin.murphy@arm.com, baolu.lu@linux.intel.com, cohuck@redhat.com,
	eric.auger@redhat.com, nicolinc@nvidia.com, kvm@vger.kernel.org,
	mjrosato@linux.ibm.com, chao.p.peng@linux.intel.com,
	yi.y.sun@linux.intel.com, peterx@redhat.com, jasowang@redhat.com,
	shameerali.kolothum.thodi@huawei.com, lulu@redhat.com,
	suravee.suthikulpanit@amd.com, iommu@lists.linux.dev,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	zhenzhong.duan@intel.com, joao.m.martins@oracle.com,
	xin.zeng@intel.com, yan.y.zhao@intel.com
Subject: Re: [PATCH 1/3] vfio-iommufd: Support pasid [at|de]tach for physical
 VFIO devices
Message-ID: <20240115171852.GK734935@nvidia.com>
References: <20231127063909.129153-1-yi.l.liu@intel.com>
 <20231127063909.129153-2-yi.l.liu@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231127063909.129153-2-yi.l.liu@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?PIoZKKGHS2hlZufkroHNU9MGpXp531ljGoN3MWvUhl3v1R4j6uj2e+mWQpKs?=
 =?us-ascii?Q?diOAJuv806ZsAC+HoNAFOisXWReOccTcNSlmUkTYP+Vgjf2tqNP5QJ3JvO1Z?=
 =?us-ascii?Q?aU/CChXCBQnPpJHYQMqBynu7OFeB9joWkE+rPP27M+Lhvv/sCH1BIemTJVQz?=
 =?us-ascii?Q?Jte1xTifw9zKc+80cV+9mRJ2g2C72WwXaR5EBu57JWo7RatizMhMH6RQPTi5?=
 =?us-ascii?Q?YqTDI0E1RwnkClMB1KpblGyd6IohMmBL2nz2OpVs3YeMB9I02f/iLNWBdyYr?=
 =?us-ascii?Q?15q/7JlXav0DmHhKgriUyVDlMpKsHsQYXB56I92TD1Kh0sZM5NE29Ft/5LF1?=
 =?us-ascii?Q?uqgjW0/ruAXXGmJ3L5ahdqTX3QBwszNThzLY08/joCOf+bq5jDgUIez+aWMQ?=
 =?us-ascii?Q?of+d2kup4IqhUDdti4qBCnkyLhN/XiGMs+TsBNLlDQo11nymEhhYqus3qI5f?=
 =?us-ascii?Q?BvuOsw8yHSnVaWH0GxSw0JJ3bODtnK0vHKpWpuJc/NVvEGe+rh9qXZ4Y3cjN?=
 =?us-ascii?Q?cAl6jorerqNAISYuD7EzevBqAi+1EjCbUWGV3UF4YyHqxOQRcbgN/c1Y0Uk7?=
 =?us-ascii?Q?jyZE7k9W2XOYX+9rphwc8J61p3S+qFkhzRcnRGgTU8zuFzUziuqNyPgPKh/x?=
 =?us-ascii?Q?ukcO3NXf8E4Q+LTTtvXyBUzqSKRLKYyfZ6SEQLceuQkBDsHJXjJU/oK3RLNJ?=
 =?us-ascii?Q?xJ+AhTBR9PjdMbriP3rSffmHktpyYQBB8CqTOXlwHBOrd96qRifHOX6peLkw?=
 =?us-ascii?Q?ZJJUTap9WsMV3v2yIQlBeTmtKuzE/lUkNJJP0QLFnV7aBPMh9mHPWSjmPc2z?=
 =?us-ascii?Q?fJ6NvtPpSvi5c7GS8TWDymVOF6Jw3Yjyd15aAI05vDnC0+cHrqtiMNQOm03L?=
 =?us-ascii?Q?GlSoLbpjvSbXkKx/B2ib1i7kLUEVGTPkU4JOnvQTl3AEhorcOwbheEM4vfGc?=
 =?us-ascii?Q?F+CvR/hJKaAv0Sui+eNXfw7rf2BLQLrs3dIB4kqDjCBrHCEuG26FAJLsX7n1?=
 =?us-ascii?Q?+0Ay5hiHLO+QjdjnowEdD4TeCJn7lZIucynte19QKt3+BLoyvaNuCZ/6Bgda?=
 =?us-ascii?Q?kN1DbIJLAxJJzRk5hgFhdGFR17eG5rhlOqE0+49PjlnLr+Vvjit+SAtNaAPy?=
 =?us-ascii?Q?gy8dej0c/qU5HFRV0FKhAMjdiZ0jq15SFDXvuhjTCgjk+YSAho+KLq4o975f?=
 =?us-ascii?Q?mv9N2NOVFr1WoJLKCgItEF4hpJUUuc074WqlEXpxdt+jTj9I6tD36j/kRlcE?=
 =?us-ascii?Q?onxlVDyqQaR+dM6ZUw9OPcD/8bEO0SqF8o95RCYtZ0znwCsEVXFCguCjudnO?=
 =?us-ascii?Q?xPQZ3HEKoR5wF26w6MxALK/15SBHYAaeAPyrovZfwYKN/7BbZjfACu9S9cdL?=
 =?us-ascii?Q?cqBwxhShg8WdPaWyPj/vUMOJASH3dpVJ7OoI+RY0hIq1bUAhLCPREDO/Lim/?=
 =?us-ascii?Q?LLMhG5FtU30gYvDGJQFe0GjeLMt5Hf4u78/kfn2C98cRmJA0VM3FrM+5p6oM?=
 =?us-ascii?Q?/OS0l61b2TYfvsxAVmx0z0wlC70AXaBUc9MK/PrIXnt46us4cX5eQ4Vpqqcj?=
 =?us-ascii?Q?cQQG+Ku7u9wQETzjvLnygb/jsmrXBKMQRvTjMamY?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4543a277-cef5-4064-e5cd-08dc15ee0c8a
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2024 17:18:53.8078
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RyCVu/WpuCMv9mQAdt7m35ZXHgy6zN5HgO+1n7s1kjKQu+43Hq5xFFQ1DTzQbcgY
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4477

On Sun, Nov 26, 2023 at 10:39:07PM -0800, Yi Liu wrote:

> @@ -168,6 +180,42 @@ void vfio_iommufd_physical_detach_ioas(struct vfio_device *vdev)
>  }
>  EXPORT_SYMBOL_GPL(vfio_iommufd_physical_detach_ioas);
>  
> +int vfio_iommufd_physical_pasid_attach_ioas(struct vfio_device *vdev,
> +					    u32 pasid, u32 *pt_id)
> +{
> +	void *entry;
> +	int rc;
> +
> +	lockdep_assert_held(&vdev->dev_set->lock);
> +
> +	if (WARN_ON(!vdev->iommufd_device))
> +		return -EINVAL;
> +
> +	entry = xa_load(&vdev->pasid_pts, pasid);
> +	if (xa_is_value(entry))
> +		rc = iommufd_device_pasid_replace(vdev->iommufd_device, pasid, pt_id);
> +	else
> +		rc = iommufd_device_pasid_attach(vdev->iommufd_device, pasid, pt_id);

An ida is a more approriate data structure if the only point is to
keep track if a pasid is in use or not..

Jason