Received-SPF: pass (google.com: domain of linux-kernel+bounces-26326-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20231220145537.2163811-1-andre.draszik@linaro.org>
 <170432630603.2042234.10993333941885772911.robh@kernel.org>
 <827695c3-bb33-4a86-8586-2c7323530398@amd.com> <bcd89ef7a43eb7d652f045c029d8e108adf7ba32.camel@linaro.org>
 <20240115-fragment-clean-95ef01dd8b20@spud> <ffd6f60e-fea9-4426-a981-badd3c68cd4d@amd.com>
 <8c5afb4e52e0c5a6dd88f6b7eaa7bc2e97ba31ad.camel@linaro.org>
In-Reply-To: <8c5afb4e52e0c5a6dd88f6b7eaa7bc2e97ba31ad.camel@linaro.org>
From: Rob Herring <robh@kernel.org>
Date: Mon, 15 Jan 2024 11:43:29 -0600
Message-ID: <CAL_JsqL3ELh=i6cA+8EhH0uBw19sw5+vCyLWUODU7D80JS-D8w@mail.gmail.com>
Subject: Re: [PATCH] dt-bindings: ignore paths outside kernel for DT_SCHEMA_FILES
To: =?UTF-8?Q?Andr=C3=A9_Draszik?= <andre.draszik@linaro.org>
Cc: Michal Simek <michal.simek@amd.com>, Conor Dooley <conor@kernel.org>, 
	Masahiro Yamada <masahiroy@kernel.org>, Conor Dooley <conor+dt@kernel.org>, 
	Mathieu Poirier <mathieu.poirier@linaro.org>, linux-kernel@vger.kernel.org, 
	devicetree@vger.kernel.org, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 15, 2024 at 10:57=E2=80=AFAM Andr=C3=A9 Draszik <andre.draszik@=
linaro.org> wrote:
>
> On Mon, 2024-01-15 at 17:37 +0100, Michal Simek wrote:
> >
> >
> > On 1/15/24 17:29, Conor Dooley wrote:
> > > On Mon, Jan 15, 2024 at 09:40:37AM +0000, Andr=C3=A9 Draszik wrote:
> > > > Hi,
> > > >
> > > > On Mon, 2024-01-15 at 10:20 +0100, Michal Simek wrote:
> > > > > This patch is causing issue for me. Look at log below.
> > > > > I am running it directly on the latest linux-next/master.
> > > > >
> > > > > Thanks,
> > > > > Michal
> > > > >
> > > > > $ make DT_SCHEMA_FILES=3D"Documentation/devicetree/bindings/arm/a=
rm,cci-400.yaml"
> > > > > dt_binding_check
> > > >
> > > > It'll work if you drop the 'Documentation/devicetree/bindings' part=
 from the path, as
> > > > it is implied since bindings can only be in that directory anyway:
> > > >
> > > >      make DT_SCHEMA_FILES=3D"arm/arm,cci-400.yaml" dt_binding_check
> > > >      make DT_SCHEMA_FILES=3D"arm,cci-400.yaml" dt_binding_check
> > > >
> > > > both work.
> > >
> > > Requiring that is pretty user unfriendly though I think, passing the
> > > full path from the root directory of the kernel tree would be my
> > > assumption of the "default".
> >
> > I am using full path like this for years.
>
> I just just went by Documentation/devicetree/bindings/writing-schema.rst
> which doesn't suggest adding Documentation/devicetree/bindings/. In an
> attempt to make it more robust for anybody following this doc, I opted
> for the current implementation.

It originally worked only with the full tree path. It's now enhanced
to take any substring for a match. As that is preferred (and shorter)
that's what the documentation has.

> > I can fix my scripts but would be good to consider correct path inside =
the
> > kernel is something what this patch should also allow.
> > Because path above is correct and it is not outside of the kernel that'=
s why at
> > least commit message should be massage a little bit.
>
> I hear you, and I'll make a v2 to not imply the bindings directory.

A follow-up, not a v2 because v1 is already applied.

Rob