Received-SPF: pass (google.com: domain of linux-kernel+bounces-26352-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <934627c5-eebb-4626-be23-cfb134c01d1a@arista.com>
Date: Mon, 15 Jan 2024 18:05:10 +0000
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 12/12] selftests/net: Add TCP-AO key-management test
Content-Language: en-US
To: "Nassiri, Mohammad" <mnassiri@ciena.com>
Cc: Shuah Khan <shuah@kernel.org>, David Ahern <dsahern@kernel.org>,
 "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
 Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
 Salam Noureddine <noureddine@arista.com>, Bob Gilligan
 <gilligan@arista.com>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
 "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
 Dmitry Safonov <0x7f454c46@gmail.com>
References: <20231215-tcp-ao-selftests-v1-0-f6c08180b985@arista.com>
 <20231215-tcp-ao-selftests-v1-12-f6c08180b985@arista.com>
 <DM6PR04MB4202DA43D14985A28055CE0FC56F2@DM6PR04MB4202.namprd04.prod.outlook.com>
From: Dmitry Safonov <dima@arista.com>
In-Reply-To: <DM6PR04MB4202DA43D14985A28055CE0FC56F2@DM6PR04MB4202.namprd04.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi Mohammad,

On 1/12/24 18:57, Nassiri, Mohammad wrote:
>> -----Original Message-----
>> From: Dmitry Safonov <dima@arista.com>
>> Sent: Thursday, December 14, 2023 9:36 PM
> 
>> +
>> +static void end_server(const char *tst_name, int sk,
>> +		       struct tcp_ao_counters *begin) {
>> +	struct tcp_ao_counters end;
>> +
>> +	if (test_get_tcp_ao_counters(sk, &end))
>> +		test_error("test_get_tcp_ao_counters()");
>> +	verify_keys(tst_name, sk, false, true);
>> +
>> +	synchronize_threads(); /* 4: verified => closed */
>> +	close(sk);
>> +
>> +	verify_counters(tst_name, true, false, begin, &end);
> 
> Shouldn't it be reversed instead?
> verify_counters(tst_name, false, true, begin, &end);
> The sk is an accept socket and the function is called by the server.

Good catch!
Do you want to send a patch? :-)

>> +	synchronize_threads(); /* 5: counters */ }
>> +
>> +int main(int argc, char *argv[])
>> +{
>> +	test_init(120, server_fn, client_fn);
>> +	return 0;
>> +}
>>
>> --
>> 2.43.0
> 

Thanks,
            Dmitry