Received-SPF: pass (google.com: domain of linux-kernel+bounces-26399-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 15 Jan 2024 14:38:14 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: peterx@redhat.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	James Houghton <jthoughton@google.com>,
	David Hildenbrand <david@redhat.com>,
	"Kirill A . Shutemov" <kirill@shutemov.name>,
	Yang Shi <shy828301@gmail.com>, linux-riscv@lists.infradead.org,
	Andrew Morton <akpm@linux-foundation.org>,
	"Aneesh Kumar K . V" <aneesh.kumar@kernel.org>,
	Rik van Riel <riel@surriel.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Axel Rasmussen <axelrasmussen@google.com>,
	Mike Rapoport <rppt@kernel.org>, John Hubbard <jhubbard@nvidia.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	Andrew Jones <andrew.jones@linux.dev>,
	linuxppc-dev@lists.ozlabs.org,
	Mike Kravetz <mike.kravetz@oracle.com>,
	Muchun Song <muchun.song@linux.dev>,
	linux-arm-kernel@lists.infradead.org,
	Christoph Hellwig <hch@infradead.org>,
	Lorenzo Stoakes <lstoakes@gmail.com>,
	Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v2 07/13] mm/gup: Refactor record_subpages() to find 1st
 small page
Message-ID: <20240115183814.GS734935@nvidia.com>
References: <20240103091423.400294-1-peterx@redhat.com>
 <20240103091423.400294-8-peterx@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240103091423.400294-8-peterx@redhat.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?qG9dqY9op9CmAUH/TIN9XB5pjS2yrYSTq6yqzafXqZa2fKZZYUU9rH75GlM0?=
 =?us-ascii?Q?lOqZYyNH4XUJlF+dYcZdQ/9WgyGvjR1s46Bb5fcAqSMNDXHri6Z5J8dEXgTo?=
 =?us-ascii?Q?ADa0xmNAAQFkZH3ceOE6Ebj2NkMV+R3dXlyATNloYDmaTjYX+XWuPdEXvE76?=
 =?us-ascii?Q?5xawQeQ1ymGDRQbQzNpc0YtMIZXh/0BM/nEnroGiAXlCXkyO8nEsSA/ZrJXN?=
 =?us-ascii?Q?ShBeVAPKO84TpfebXpgvW8oAuU+az6mYBdpvDc++CuHLf1gu4bi7trDzHgMa?=
 =?us-ascii?Q?ths/8zCeUdUs+RfF5qr/H91ZY4jTyrAPbJe8s1W1EvMSF5jtJ7x16V9yCnqW?=
 =?us-ascii?Q?bGNamYankbuyB6yPCuNQSOyncgSYeRETImr3TRjD01B4q7meIkJJAFUfxOSb?=
 =?us-ascii?Q?TSiPVkDbyWUM5ISZgErYaBXqVCD4H2kOIJNeF6ULJW0yIu7inpEqPAEGaqIm?=
 =?us-ascii?Q?JLQRTeQA/ra0qLNQ0YHo/7hRJnqa0AeOzhwDeEuq21DxGb28CwZ5SOdd0pS5?=
 =?us-ascii?Q?fWobKCirg3gH0ihTPGvhQBnqYLDubLZAd+wl8GGlnMGeMQs7OZXqEr8Obe3T?=
 =?us-ascii?Q?lAp4j3VIzMLORaTMPUn8WAHO3ucFZHDqUr0guiQaar1MbhZ2NUR6hkxihZ+k?=
 =?us-ascii?Q?DQPii/NtnM62G3ze7/2a3DTYWXDbco96sZRB7dk1wdfzRD3d56zIf9ziZz0I?=
 =?us-ascii?Q?4LReQsTXaTchlex3EMQbWhAmw6CCaFpEJWEV4pKDpV3kqEQ2+a9h+vTpkfR6?=
 =?us-ascii?Q?P0HvnNYPw89uPGy+wLOMtyZjh51Pk/mmtIZii7xQvWZDlaCsivcu4PQe6pF3?=
 =?us-ascii?Q?t3mVDF6XZZBpfrvJqoII3D4k8ZLpNeZYYv0SR/Tt97YRUjc2XHKXhkmYjw0g?=
 =?us-ascii?Q?Mfees3OWvVxzqpRlnxXFmv21FUGSn3pG4rDAHkzp8oYG9WkZUSFK/w9cPXQ2?=
 =?us-ascii?Q?A+TAGNwmBGqGvDSp6JFlcY4dtjkN7p5Fd6Q6iOyufPCs/o8AbQs7hvk83P5P?=
 =?us-ascii?Q?VA430ewijonmZVh9FSSW2QORjdnoV/J54cgSP60qBCmU6pONzTgvGiKxzp/n?=
 =?us-ascii?Q?WoE7CAsx3SmZ9jZdzuTGUaKNbD+W51I/Xl+Ao1GZZnKciOsMOsO5mOOisF7H?=
 =?us-ascii?Q?WR7eNxvIKuPgGj/H3L1/YJb8CiQS8u9Pmn9QoJO5tRFsOqaJHZEiPk30i86E?=
 =?us-ascii?Q?NK5Srq6oUmUzBVgWEoPOmFu9fX0lMmfVSI7LWVx1K5J9w4RxVcw149aleqs2?=
 =?us-ascii?Q?2TbUdjYVTP3MvQvqH/ld6r3xdaMQzTC+nvq2vRqEF1DBd0h6EunvWJLsRqAj?=
 =?us-ascii?Q?YwAKwNQBVcBf6dnIHN143u8WhsImqXkCnbRq9qAF4OxUP3dMLj0ZZyc36QE/?=
 =?us-ascii?Q?1rKQA5ei6b0vmpxGzfHFGo0tkZDnhi133xlho4yLGiYSgER35B0aaXu5V+/y?=
 =?us-ascii?Q?Lp4aF6BfMez47ok2iktJ+xAnhIA5ErlAornp/UAadwjPKc+AsBPLglHYV+Gj?=
 =?us-ascii?Q?iMJZ75R4qWCiOK5YrdDtQYCUUY9g4omy8bcze7H6Np6MjS1k/ZWp1kxJfKob?=
 =?us-ascii?Q?jxcleCuYXbAFK4F1kjWznb71bEw29WaOcpkkz6Il?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 99683257-a1d7-44c5-21a1-08dc15f92287
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2024 18:38:15.1323
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: S3Pa0nJB7662OhoKvuC0NcS0efX/TSnv1rJdKUDcm+0wbVmUXCX92rmqnSVwdeE3
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7792

On Wed, Jan 03, 2024 at 05:14:17PM +0800, peterx@redhat.com wrote:
> From: Peter Xu <peterx@redhat.com>
> 
> All the fast-gup functions take a tail page to operate, always need to do
> page mask calculations before feeding that into record_subpages().
> 
> Merge that logic into record_subpages(), so that it will do the nth_page()
> calculation.
> 
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  mm/gup.c | 25 ++++++++++++++-----------
>  1 file changed, 14 insertions(+), 11 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason