Received-SPF: pass (google.com: domain of linux-kernel+bounces-26404-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Mon, 15 Jan 2024 14:39:22 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: peterx@redhat.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	James Houghton <jthoughton@google.com>,
	David Hildenbrand <david@redhat.com>,
	"Kirill A . Shutemov" <kirill@shutemov.name>,
	Yang Shi <shy828301@gmail.com>, linux-riscv@lists.infradead.org,
	Andrew Morton <akpm@linux-foundation.org>,
	"Aneesh Kumar K . V" <aneesh.kumar@kernel.org>,
	Rik van Riel <riel@surriel.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Axel Rasmussen <axelrasmussen@google.com>,
	Mike Rapoport <rppt@kernel.org>, John Hubbard <jhubbard@nvidia.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	Andrew Jones <andrew.jones@linux.dev>,
	linuxppc-dev@lists.ozlabs.org,
	Mike Kravetz <mike.kravetz@oracle.com>,
	Muchun Song <muchun.song@linux.dev>,
	linux-arm-kernel@lists.infradead.org,
	Christoph Hellwig <hch@infradead.org>,
	Lorenzo Stoakes <lstoakes@gmail.com>,
	Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v2 08/13] mm/gup: Handle hugetlb for no_page_table()
Message-ID: <20240115183922.GT734935@nvidia.com>
References: <20240103091423.400294-1-peterx@redhat.com>
 <20240103091423.400294-9-peterx@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240103091423.400294-9-peterx@redhat.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?BGBzhAMP69pXkMnACiS7hyqSwXoT8Nm9uT7HxZhc2breIBlYcIvmAuyDSb3S?=
 =?us-ascii?Q?OK/fN8pn9X56lZUuxJf9ssjzcwEm2OwQvw6v/nYfAqaAlRYNlhIpY8P8dyvf?=
 =?us-ascii?Q?Y1krZ0ZlpGIff3Zmkin0u2rDfqWW/B7acXU8BLRovSBvzQ3vpgJ0MfVFl0wC?=
 =?us-ascii?Q?agYtqDqJwLYbQNsOBXpH1DlkKKN6pnFwLxmQOIuBqlaa0VVwV94gcSxrQMsH?=
 =?us-ascii?Q?fceXpqecNDtlKLK6Oj0xOhMTw03+jhSSnxT/lcAf8JY8gGyyAx4s9N0PN8TB?=
 =?us-ascii?Q?MFxDXxCbmWQGBZ1lYs7qL1oowcU/Zwl8lGrbzYZTrDwz0kdJ4NoxHF94CBvz?=
 =?us-ascii?Q?g+0XWoxwOi9hcEkLlaTX1T/KgX5iaGycTFcBHI2EpdXYEawOqUm5n3ZAQwlN?=
 =?us-ascii?Q?7WyLFO9OA1xiujtQsZPxngPxl0mMUoDyFqu9N5IRj4pHx/O4osuRhO3mr1Fp?=
 =?us-ascii?Q?O68F4KECtPmMADw6+FpjrHC56LkK06q+fhB3OJzflGAK70AmRo7WYrkleAzL?=
 =?us-ascii?Q?Q8KAXEBtPJ9Vezg+RPd6Et7o54LkIXsiX1qVbydAY7F2rxL5k/5Q3Qdqzuik?=
 =?us-ascii?Q?d+8scxn4i63khPoCXvxpW2BnaENi+vQQjq5KkxgaA1yeLy09LjRuGPQu6Wki?=
 =?us-ascii?Q?hd0ur79/AX8BJKFQUZLr4UAtvvM5FcD7jc3VsTzeRNuLByYT/ekAZmX0jof4?=
 =?us-ascii?Q?a3A0pgs432DHjyRntLfO5UFlxwQAztrEQpUd1xm9+FyejllWx8kQgAI4JCTc?=
 =?us-ascii?Q?KkMF2zgN4xek6NGsel5/DmSwbbe9UMQ5tr3sF0g+24Gs4/irN43zkBlk4ID4?=
 =?us-ascii?Q?PjHBlGXfQKf92y3OTeiH4t/bwnlHi/1ipQ2X8v2N37MaQGSe7ZRF8byYtsNh?=
 =?us-ascii?Q?T4Vkyet6jTLz17uEVVvKGzGxp2Pfy8khkY9J+DrechqmNOl42bkYwpVYtSol?=
 =?us-ascii?Q?wDFt01cQ6+fvEb+c3zVmr8i4hHoHj217YkNgKz6IWectn/6LRnTjAZAgtdI6?=
 =?us-ascii?Q?YuPFV1uUp61vtKFaMRP+z661BU3sAITMf96NY2FEyhj44lIi5iliA/J0DvtC?=
 =?us-ascii?Q?nqmZ2ETIvFxX0lnJGqklg+pasqMwajOTlBo9kRMIpmLHZ8ZVBpiuXBVQ1KSr?=
 =?us-ascii?Q?qD0lOEh21MAYR3nGKXfsqmOL1RGi7QYfBOjjiTsM49QoqwS1LJ20NNNpDyRD?=
 =?us-ascii?Q?FtkZ3BXTAXIrQVU4M+hXuM92YUuP7FB9ZratC+srIYn0hjHqZNJlpjagIgi0?=
 =?us-ascii?Q?BCI07DQKqNfRS87nrVcucl0Trp6a0Xr8aPqxs6cjzUzQFUISQp+HH9lTeA1O?=
 =?us-ascii?Q?UAzMfMi+zOieZ9Uzpe+dGIK57Ge0tI9fkSZ3f5kvELB9rgxlEsRkJfiLXBwi?=
 =?us-ascii?Q?iUTFmwi2mGdEAR5sR0oxCM9rfaP6nNNejrS1aYuGs/HoKgLgcw2JNv3EJPjM?=
 =?us-ascii?Q?XY0mmNCeCe19NyLZCrSG/cspAYCgZY/p7LBg0sRpuMN/t7lyECjF7yZUEcjv?=
 =?us-ascii?Q?DkuB1TWqMfdKDSPHzcKRVQhl/e03dQz8r/1BK8dKf0xvR5HSvwchhqt2nc8P?=
 =?us-ascii?Q?uPy8oNEfpp9vNNiPc//yKeNmQDZ4OIU21cDgM8Nm?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7e166839-e24f-4c7f-77b3-08dc15f94b6c
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2024 18:39:23.7763
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BqRa1Cj2gl43Z45j4vDV/qb4NfmghugEsbtqAgH6bY8EJyPJ4In8xNME0Xfpkzj1
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB9200

On Wed, Jan 03, 2024 at 05:14:18PM +0800, peterx@redhat.com wrote:
> From: Peter Xu <peterx@redhat.com>
> 
> no_page_table() is not yet used for hugetlb code paths. Make it prepared.
> 
> The major difference here is hugetlb will return -EFAULT as long as page
> cache does not exist, even if VM_SHARED.  See hugetlb_follow_page_mask().
> 
> Pass "address" into no_page_table() too, as hugetlb will need it.
> 
> Reviewed-by: Christoph Hellwig <hch@infradead.org>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  mm/gup.c | 44 ++++++++++++++++++++++++++------------------
>  1 file changed, 26 insertions(+), 18 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason