Received-SPF: pass (google.com: domain of linux-kernel+bounces-26412-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 15 Jan 2024 14:51:07 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: peterx@redhat.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	James Houghton <jthoughton@google.com>,
	David Hildenbrand <david@redhat.com>,
	"Kirill A . Shutemov" <kirill@shutemov.name>,
	Yang Shi <shy828301@gmail.com>, linux-riscv@lists.infradead.org,
	Andrew Morton <akpm@linux-foundation.org>,
	"Aneesh Kumar K . V" <aneesh.kumar@kernel.org>,
	Rik van Riel <riel@surriel.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Axel Rasmussen <axelrasmussen@google.com>,
	Mike Rapoport <rppt@kernel.org>, John Hubbard <jhubbard@nvidia.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	Andrew Jones <andrew.jones@linux.dev>,
	linuxppc-dev@lists.ozlabs.org,
	Mike Kravetz <mike.kravetz@oracle.com>,
	Muchun Song <muchun.song@linux.dev>,
	linux-arm-kernel@lists.infradead.org,
	Christoph Hellwig <hch@infradead.org>,
	Lorenzo Stoakes <lstoakes@gmail.com>,
	Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v2 11/13] mm/gup: Handle huge pmd for follow_pmd_mask()
Message-ID: <20240115185107.GW734935@nvidia.com>
References: <20240103091423.400294-1-peterx@redhat.com>
 <20240103091423.400294-12-peterx@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240103091423.400294-12-peterx@redhat.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?jX3QNSpOZwtINWcBOwz39nQ2SkQLrQJ4BQvkz/yzJqGCsT9l9Kn/QB/n5N5R?=
 =?us-ascii?Q?EFgUfIg9QNV10iclP1vFU8NejLYfJnKUCXriBI7OjRiP/Q0IBaAD5tapAWHW?=
 =?us-ascii?Q?YbVkGeO6N0+zuOeP1OyrkG+TtX2uze9sJ7N5SXWV8Ds8BRyaFKNpE/oc/cHt?=
 =?us-ascii?Q?9ToUeyuP8t1B60OKtOscu878eiowvhalD/KP1huAPJ/9puPbK8WS90sExXIY?=
 =?us-ascii?Q?sJ1b6+QA9AH8KEs8On29OhmW9JY8PqV7g7geUqVzr4BJt6j2/1OP8eT2jjHj?=
 =?us-ascii?Q?LFSbSV0s9ZMYTWs2MY6l6gD5dLvFo3pySIwqPNxWb2Ku8IcjdydtO6EuJjYR?=
 =?us-ascii?Q?32KgMg6eMiZjk+1UbzUqYn3nMgIuxLANTL4ZmpKYuKc9uSzzRMMBQgwZWPS8?=
 =?us-ascii?Q?pKhE6Jf3ECKXdY8FrTeDjwqcZ8d2djWx0mQrSTKQwV7rzFsKg/b+RhX4CuLA?=
 =?us-ascii?Q?z3AF6MOuoKN6XPPNpQzI2AD3mejjmN6MrtOC9qEC2RVvUVlGVl7qKaMNXwBt?=
 =?us-ascii?Q?1eOoO9Plh8Yt1r6iFc961PhBdAlG3VHKFwJdhR5dNVZanDh0Mqmc7eR8uvHK?=
 =?us-ascii?Q?mxtopxhQQVhzoZCCeNQXv2kuLzY0OmQwK8zdR2zFs9D6dxsBSUGPpoTOUI2E?=
 =?us-ascii?Q?Yjh441+BsqUQI1tWHK2sNINWBUo2A6YRbCJUq3EDcvL45xMjFBB+fajVyQqy?=
 =?us-ascii?Q?ZpMO3Favn5CbrexNTu7rcT7PLBBZ05zQpklzwtWJZTxH+uEEpggr8P8Hz8Vn?=
 =?us-ascii?Q?stAIDpYw5NZ0+zg9NDM6CVphZlK01o1Uby9VltuRfTa9uAch6zKKcCXzMdJs?=
 =?us-ascii?Q?Kl/pl7d84mGPtogxCEplM2s7Uo2eROpDEYhCTpEPlsqLvdwFcWO6o/WVmgjR?=
 =?us-ascii?Q?MntYxEvgsuw5ngqkVuEeL8jcl5n9k+8bbAEt025E2FD2Cv10lTylNfTpkLEi?=
 =?us-ascii?Q?neYsmXEZwVbR8TipPJzoJlNb7P/ml/IsJjG3u6sgi9IVUen7arh/fH5g6J8b?=
 =?us-ascii?Q?Opeeaun/Ly6g8Ysm/kor7OOWCS5ipAEaSsTvEuw5HnurtCihk0sMcvNQamyj?=
 =?us-ascii?Q?7Jfiqn+xBiv7cYu18CWtlLiZaY8S8ZyPaO7q5E3JXA0C0Xp9hFm2+YiBsvbb?=
 =?us-ascii?Q?ZP8L777KE044zHF+mBEO/OTAfyWmAyWhAGjNwQPxGcl12dRX1+fZ0ZvjVQgt?=
 =?us-ascii?Q?ZkV/ijKGRt9OGr+xpmpNc/iFxsnDcutywF4HNPdEmUCEC47i1nkEQ1QzlzN1?=
 =?us-ascii?Q?XbRjH0TggJX5iczno3nEDRlPsMzzDwDj9iW5xtpjCZB3vsy0bZ3zldiMsSsg?=
 =?us-ascii?Q?PuapAcK3BIfY9ZC/RhNDU+4PgdczHj3Ls+A4t1z+9W0QW0eEPr2eQ3mODb4z?=
 =?us-ascii?Q?/5KmGFZK3+fpOKu/Tw6B6+qqoRFq8aT0g+csOUOEMbJSv51B0i7G7oD1SC7m?=
 =?us-ascii?Q?Bv65dDpy4TV/Q/+kYOTqKdS/x6MNME3lITVW65zt/LLu7Ri3PYFp5ea4N9wu?=
 =?us-ascii?Q?H51Eg+yOwUVezO+rnzOXkecqKN5sYwsaZ/YmtGG1/0OkCWeLks91sWVcpc4Z?=
 =?us-ascii?Q?gCe5bJE3gqlRK9edffXcRKGOKTopSTjf3+DERrYc?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 58f3eacf-11e8-495d-3337-08dc15faefa8
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2024 18:51:08.7660
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: h2ONvC+x4X73qqLknIM1poogsOHktZKgevjy1eKdc1nZZYsAsGbc0axtuU6y0082
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5769

On Wed, Jan 03, 2024 at 05:14:21PM +0800, peterx@redhat.com wrote:
> From: Peter Xu <peterx@redhat.com>
> 
> Replace pmd_trans_huge() with pmd_thp_or_huge() to also cover pmd_huge() as
> long as enabled.
> 
> FOLL_TOUCH and FOLL_SPLIT_PMD only apply to THP, not yet huge.
> 
> Since now follow_trans_huge_pmd() can process hugetlb pages, renaming it
> into follow_huge_pmd() to match what it does.  Move it into gup.c so not
> depend on CONFIG_THP.
> 
> When at it, move the ctx->page_mask setup into follow_huge_pmd(), only set
> it when the page is valid.  It was not a bug to set it before even if GUP
> failed (page==NULL), because follow_page_mask() callers always ignores
> page_mask if so.  But doing so makes the code cleaner.
> 
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  mm/gup.c         | 107 ++++++++++++++++++++++++++++++++++++++++++++---
>  mm/huge_memory.c |  86 +------------------------------------
>  mm/internal.h    |   5 +--
>  3 files changed, 105 insertions(+), 93 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason