Received-SPF: pass (google.com: domain of linux-kernel+bounces-26439-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <16027339-0a82-4dd1-86aa-19fda6e23f88@wolfvision.net>
Date: Mon, 15 Jan 2024 20:43:09 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/3] ASoC: dt-bindings: xmos,xvf3500: add bindings for
 XMOS XVF3500
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>,
 Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
 Takashi Iwai <tiwai@suse.com>
Cc: Rob Herring <robh@kernel.org>, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
 linux-usb@vger.kernel.org
References: <20240115-feature-xvf3500_driver-v1-0-ed9cfb48bb85@wolfvision.net>
 <20240115-feature-xvf3500_driver-v1-2-ed9cfb48bb85@wolfvision.net>
 <333c2986-c7c2-4a46-90cf-b59ae206e55a@linaro.org>
 <96abddcc-fa65-4f27-84fe-2281fe0fcf1c@wolfvision.net>
 <644f7f02-405d-47fb-bc72-4d54e897255f@linaro.org>
 <5db4b898-93d5-446f-bfed-b57847f9967a@wolfvision.net>
 <435f502c-1e1b-4d40-8dcc-34487905d69c@linaro.org>
 <b7f76546-9998-43e0-abff-a4e73817dbae@wolfvision.net>
 <47bdc31c-50d2-4d33-9339-5132b6364539@linaro.org>
Content-Language: en-US
From: Javier Carrasco <javier.carrasco@wolfvision.net>
In-Reply-To: <47bdc31c-50d2-4d33-9339-5132b6364539@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bnA1bXM0aUh2NFNybVh5a0tnNEJFUHdSSUpyTnhQMUwvTS9NQ2p0djl2VFhs?=
 =?utf-8?B?Vkg1djBucVY4REh4Y3N5ZG13b0pvZnVuNjR3MWJHUHVTKzJKVTVSWVcwN3Jn?=
 =?utf-8?B?SzU2bENOYXJSSzByZ1RIV1ZucFpHQzhvcVUwQ1p5Tk16RGdQcGhnQlV2TkJ0?=
 =?utf-8?B?YUpwSUNVYmJISWlhOTk2SVQ1Ym54OHpPUUhBeVl0NUlzanpxaHBleDVsSGNw?=
 =?utf-8?B?dlhnbWlveHFyK3RvMlhCdm53UG51K1JtbU9vaXU1UjlKdE4vMFQ2TkZOaEIy?=
 =?utf-8?B?ci93b3BCMk5KVDZ0T3lnbW5BTCs4WUtCZlZoZGFBL1h5TmowSDdrbVF5aHdO?=
 =?utf-8?B?N3JkVkdmZlJ1TFRPL2V1VWkrdmwyRVpVL0hoazU5QUR3aUFyamYwVXJvOCtk?=
 =?utf-8?B?K0dSTTVDblNiR1RQeFlZTUVYWDU5TVJ4U2EvQzVxMktMSjVHL1RUbWh0TE1w?=
 =?utf-8?B?cmlQZUkrakVtTzFuL2xYTnA5eUE3aUo1NHdmUWVQU3NRREZWWlZPbXhORHoy?=
 =?utf-8?B?YVJRclhzVitiWGdNOVYxL1lxR3hPbUJPMUlnd09IckZZMWhmSmltOFYyOEdn?=
 =?utf-8?B?N05SSWVMTWRwRUdyN1lsSkhreFp4M1FoR2pVSDNXYTlLRi94WGx4cFhEOFJ2?=
 =?utf-8?B?azJZSFkwM3I0T3dRSkVLS2xJeXppSXBiMXFjSTZUWkRtU3NvWGVUTk9kcjJi?=
 =?utf-8?B?c0VVYm9ESnBoYi96UjhDbjg4VG9XNjNzTG8rNWw3UUpjUGRPcm5uSXpZQ3M3?=
 =?utf-8?B?V1JKbDA1Zk9Qbi84dVBzVzdYa0tla0xVTmVtNjhicldSOU1QdG95NzVyUk5n?=
 =?utf-8?B?L24xWlFMRnhlaTVkTmd4ZlhXZ0pWY0ZoeFVzakhBbHJnNllvclRWT0tOUW1r?=
 =?utf-8?B?cjdkSXRhK1NNVU55OXk1aWFlV1FKTElFbE1hQThnbk5xd1o0SXlKZUN6UUVB?=
 =?utf-8?B?Z0orOHVKM05JbzNBYUxMUDVwSjVnUzZOWDJBU0NENE91WEhjVE9jRjBJVy8r?=
 =?utf-8?B?WG5rbzMzMkdHTmc3QXlaZ0hjR2ZxVWNKcXNOTkFoZUtEMytlUm94cDJJSVBk?=
 =?utf-8?B?dGlRZkNRQlpOK2hReng1UUExL284VWt3V2tZZ0lyR3lZWk9aMFJvektrRGxZ?=
 =?utf-8?B?d01vSGllSnQxQ2FsSVVMbDZwMDlOUjZVQlpCamxUWWdLaHJNNzlCNE4yZy9J?=
 =?utf-8?B?aENkQ0kyM3dwYXJoRWUvK2xEUXpwZ2g0MUtlZDZZV21KenJMOGFIWktBMUZO?=
 =?utf-8?B?QWIvMldpMjVteXF0UnR5WmlaR3RFTy94S1pPM1BHUzNNa1k2S0N4MWtqSW9C?=
 =?utf-8?B?azRLSGFxSWtHM0dCRWsxb0RZUWkvanRzaEE5SzZxVGZLT3JXenNQc1EyQ3pr?=
 =?utf-8?B?RTdKYkx6bXo5RnN2Rk5iMUd0NHBUTGpLWHNrUGJXcTdOOWY5L1dGSW5UdXY3?=
 =?utf-8?B?WXJTY0Vva044NnR4aTF1TDNmR010Q0tNaTBqaXF1amszK2FXelEzb0lMTGpq?=
 =?utf-8?B?VEVQUzM3WmNRT3FueUx4NCttbjVkSlR3UDNYYmx3eTdXVjlmcWp3OGx1U2Rp?=
 =?utf-8?B?SGhQMVpzUFo5Mlo5YlFuMGlJSUs3Y3B0ZzlDVlFHcU9VNmRXZSs3NGJBLzlC?=
 =?utf-8?B?bjhFWjZCT1NYTWNlaVdoTk1Kb3hCWTZyWFpFUjFIRG16YzFwUW95eDFGekI5?=
 =?utf-8?B?OGZRbzZ2T05qQ3puVXUxRFNzbDlwY0hoc1BMcVlkVWwxWGdsQytFYnFyeENC?=
 =?utf-8?B?cnNZZXRlY2hhU21WemsvUVJWWTlOVUQ2NmN1dGFCNmlmYWIyUEZhRlJNZkdt?=
 =?utf-8?B?ODlNVk4xa0pyYm5wVXJxOTB0WU1tNGpwdWRuYXNUalBoMjZGVnhIWFgvL2Jr?=
 =?utf-8?B?VnluaUF4cHVxTFk5RlhlUXQ4UlRlSXBBNElsSWlGQVZJN0JqYit0b2ovSEw4?=
 =?utf-8?B?NmFhZXVzUHRtdUsxZFJYQUpjZkNRVjlWVE81T1YwSzZxMFBtZFdkNk1qZnA1?=
 =?utf-8?B?T3phT2ZhWWdJa2h1NEN3OUJIU2tpYklYWTlrb1p0UGJYNVVjWndZNVN4bDVo?=
 =?utf-8?B?eTZiaFFwMURZVVBXY0hGUWlaMWsxMktaYTVmdHYyTGJWWUlnRlFqZUhLeFpE?=
 =?utf-8?B?cFh2b2R6UjF3WVcxTUJ0ajZUQXEyRjZxNGo0VVVPMitYZU5Pa3NGQUhGZmJK?=
 =?utf-8?B?dm1GbzkyaEZ4K0sybkhPOU9sdW5KT2UyYXdzeW4zZFlRTWE3S0FtNXI2Sjdj?=
 =?utf-8?Q?33qJpTfdYFOgih3tI9XVII6FPfGAwK0u+B5e9xvZDM=3D?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 6e565e4f-baeb-4cd7-6c92-08dc1602357c
X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4974.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2024 19:43:12.5099
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RcYHLXyHhJrzV8HxathjjiglHVCOV71zd+FEnNxgVbzfsRtIwCE2RepWLBGfzU1/5GgNE22pf/B5qElW0j5HaoGbO+fQwAIuTwrSYnjv9Yw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7670

On 15.01.24 19:11, Krzysztof Kozlowski wrote:
> On 15/01/2024 17:24, Javier Carrasco wrote:
>> Do you mean that the XVF3500 should not be represented as a platform
>> device and instead it should turn into an USB device represented as a
>> node of an USB controller? Something like this (Rockchip SoC):
>>
>> &usb_host1_xhci {
>> 	...
>>
>> 	xvf3500 {
>> 		...
>> 	};
>> };
>>
>> Did I get you right or is that not the correct representation? Thank you
>> again.
> 
> I believe it should be just like onboard hub. I don't understand why
> onboard hub was limited to hub, because other USB devices also could be
> designed similarly by hardware folks :/
> 
> And if we talk about Linux drivers, then your current solution does not
> support suspend/resume and device unbind.
> 
> Best regards,
> Krzysztof
> 

Actually this series is an attempt to get rid of a misuse of the
onboard_usb_hub driver by a device that is not a HUB, but requires the
platform-part of that driver for the initialization.

What would be the best approach to provide support upstream? Should I
turn this driver into a generic USB driver that does what the
platform-part of the onboard HUB does? Or are we willing to accept
non-HUB devices in the onboard_usb_hub driver even though it supports
more operations?

I am adding linux-usb to this thread in case someone has other suggestions.

Thanks and best regards,
Javier Carrasco