Received-SPF: pass (google.com: domain of linux-kernel+bounces-26440-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 15 Jan 2024 14:44:10 -0500
From: Frank Li <Frank.li@nxp.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: robh@kernel.org, alexandre.belloni@bootlin.com,
	conor.culhane@silvaco.com, gregkh@linuxfoundation.org,
	imx@lists.linux.dev, jirislaby@kernel.org, joe@perches.com,
	linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org, miquel.raynal@bootlin.com,
	zbigniew.lukwinski@linux.intel.com, devicetree@vger.kernel.org,
	krzysztof.kozlowski+dt@linaro.org
Subject: Re: [PATCH v2 2/7] dt-bindings: i3c: svc: add compatible string i3c:
 silvaco,i3c-target-v1
Message-ID: <ZaWLCrWJEMtFx8cR@lizhi-Precision-Tower-5810>
References: <20240110175221.2335480-1-Frank.Li@nxp.com>
 <20240110175221.2335480-3-Frank.Li@nxp.com>
 <3c0be658-e7a6-4231-b206-86ffb47e0cb2@linaro.org>
 <ZaFbbeQrC7o2dchO@lizhi-Precision-Tower-5810>
 <e3b9aa63-25a5-41cc-9eb7-6e7d1eacb136@linaro.org>
 <ZaFjaWCA6k+tiCSJ@lizhi-Precision-Tower-5810>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZaFjaWCA6k+tiCSJ@lizhi-Precision-Tower-5810>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?4N/P44U3f6mwslBPEFOlxZnHePl6TQC4gfQWmozjn24vKTYXItvEJaNfZ+lI?=
 =?us-ascii?Q?ojjaLhM50jegwHkTK9oaDk0Y8qQbeSkW9GGiMZifvL1lRkmP0fmWorP8TRxC?=
 =?us-ascii?Q?XuahqYJnhllSq6KfVg03lbRdJ24nRDgBSlVCEPDHF+zo44GKf5PFZMOw3AbW?=
 =?us-ascii?Q?W3BQVyXgNlblvwvVH1TEQEc4RVb31ehazAfuoCvmSV+rSwxFf09EN+YwLDZ+?=
 =?us-ascii?Q?rhcpdEtmeXo0xnzlndwOsxYSfaoFW2cTyFa7cdPMeYZwrKTJHayxFs1Zny1L?=
 =?us-ascii?Q?bbo4PmPhLOv8AD72e6BotaxhIZseSnG5blNW1DyAolk43kOLPb3uNf2hn/g6?=
 =?us-ascii?Q?ySNxNsjM/+ZHxWvBW+F/I0bnoIE8aEgjfzAc6VGmEjPq0g21Nu4KBBedL5KK?=
 =?us-ascii?Q?BjOAIhceLjC5b+q9wtXHfLhJlEFuTlv+6yoxEzQdGD/egn1m1GKjbNP+X3e1?=
 =?us-ascii?Q?QSUCTcFVFB2n7Eiw3QymYKXqXGSQIYdyyrgaRsa4IgAo0iEMdPWX2ATkekr+?=
 =?us-ascii?Q?UMTMIZU0lHpQqyJF5eqn/upviVfukOOv/5+HFExaejK0flMmi9TwE6sCeN9G?=
 =?us-ascii?Q?Ye062SVBhcqYeVaNpafi/aCmPxQ7Mzbm7FSnQk3p8lbFjzgnKx1pHLTIE1RZ?=
 =?us-ascii?Q?x2gx0MiwfakXCin+bFsM5eZGkXTTEp5fMy6gcW/E9+7sO0oNVZDTstHUCI25?=
 =?us-ascii?Q?3X593UCneTU34am0lSfm84NLaPh3mAHT9Pt1QMc56t1C4waNzafOltz8h31f?=
 =?us-ascii?Q?O1lM4/Xj+kO5Y9SmuNAwYYDazPxAVIZtb0hyASb+NYfTuxBQfGPLVeOB7FUK?=
 =?us-ascii?Q?LnWOAhbqOzkDgIBgePHUMJJ03WZ4ItiHZohAHos7JJe08+/CYEvPd6eU2qHy?=
 =?us-ascii?Q?RXlwmsR9LgmBDMiScVKF8NcxsT6OFg+w8MKuhZQO51uIwkfDJEi1hDwi5/Wl?=
 =?us-ascii?Q?Vvxzk/qcY9z4ftuzL/fOu8s8WMEpC1+5UttW+Qmb8TWAXj32QimJNbGt+fOm?=
 =?us-ascii?Q?afQUY4E7e16Tv8YdV5pN1r/qnOSH7m+FDVmDsNaIJymf9G/v3emoKakAT6HS?=
 =?us-ascii?Q?QK8w5JWlJ4QFJZnI3gfxV1/hKtbM63/bvVq9r2vrU6/e5+fS5fX4OzvYE+y5?=
 =?us-ascii?Q?Xe2zHMxhcgZ06FTXZ9weYPI9en2oyC9N19SsiqQclmMR+KzHKCwS1BaYjq+V?=
 =?us-ascii?Q?Xmq+9oLd8WVBlow9K+PQvB2owFK8WoKNI/I3FDYE/C069mJ8tYwT82bdWuxq?=
 =?us-ascii?Q?7UXSu6J7C207jRwmTYaShzF80SVNkrDlPWU/zKgGnAq1PkDduEP+DdoDe4yx?=
 =?us-ascii?Q?BC4Rluvx1RG+viXRLNDn6EyzSjp9ENEppeWVtmY3X3YizcxW+y9R0nUm1TRI?=
 =?us-ascii?Q?xSYwaarOLoLh6MhVAUS7nCrh4S2wO8w8LCtFq7rrgwSNC7tAt5MXS3K3NrQ2?=
 =?us-ascii?Q?XCpAog2bUGzxVjgjWXtdYTwe4mdabt+qbaka7RdRyMWJEAytyIi153Ksx+bi?=
 =?us-ascii?Q?uBt4r306VybHtgj6fQXTZpP7dqjcBNwiVJkha0GYEyng7GEQ0/IfEuzR5F5e?=
 =?us-ascii?Q?cfd2Mvb0Je5BahInu+EDCRkIC0XP2iTllNjk9v0V?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a683534-945b-4719-8a5d-08dc16025cfb
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2024 19:44:18.6893
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tH3O//p7u6jTfsJ0ULHcski5FD29QM5IduEso6rgD5uQDEqCV923sAnvKtcJuY07RASpY0h9I9+ypeRHGgupDg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8390

On Fri, Jan 12, 2024 at 11:06:01AM -0500, Frank Li wrote:
> On Fri, Jan 12, 2024 at 04:50:25PM +0100, Krzysztof Kozlowski wrote:
> > On 12/01/2024 16:31, Frank Li wrote:
> > > I review previous comments. The previous RFC patches and I just want I3C
> > > expert review to check if there are comments about whole software
> > > architecture. Of course, thank you for your comments about "slave".
> > > 
> > > Go back this binding doc problem. 
> > > 
> > >   "No, it's the same device.
> > > 
> > >    Anyway, this was not tested.
> > > 
> > >    Please use scripts/get_maintainers.pl to get a list of necessary people
> > >    and lists to CC. It might happen, that command when run on an older
> > >    kernel, gives you outdated entries. Therefore please be sure you base
> > >    your patches on recent Linux kernel.
> > > 
> > >    You missed at least devicetree list (maybe more), so this won't be
> > >    tested by automated tooling. Performing review on untested code might be
> > >    a waste of time, thus I will skip this patch entirely till you follow
> > >    the process allowing the patch to be tested.
> > > 
> > >    Please kindly resend and include all necessary To/Cc entries.
> > >    "
> > > 
> > > It is the same devices, work at difference mode (master  and target).
> > > what's do you want to change to?
> > > 
> > > Copy to new file like pci/pci-ep? all context is the same, except for
> > > compatible string. 
> > > 
> > 
> > Apologies, I mixed up a bit patches, so this was not obvious. I meant
> > this comment:
> > 
> > https://lore.kernel.org/all/20231017201404.GA2570433-robh@kernel.org/
> > 
> > There is no indication in your commit msg that these concerns were
> > addressed.
> 
> Look like everyone already accecpted 'silvaco,i3c-master-v1'.
> 
> driver part:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=8911eae9c8a947e5c1cc4fcce40473f1f5e475cd
> dts part:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=b8ec0f3b42a3498d5115d1fb1490082ab525747b

@Krzysztof:
	Patches were accepted after discussion, what you ponit to. So I
think everyone agree on the name 'silvaco,i3c-master-v1'.
	I plan send next version to fix auto build error. Any additional
comments about this?

Frank

> 
> Frank
> 
> > 
> > Best regards,
> > Krzysztof
> >