Received-SPF: pass (google.com: domain of linux-kernel+bounces-26444-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 15 Jan 2024 14:47:45 -0500
From: Frank Li <Frank.li@nxp.com>
To: krzysztof.kozlowski@linaro.org
Cc: bhelgaas@google.com, conor+dt@kernel.org, devicetree@vger.kernel.org,
	festevam@gmail.com, helgaas@kernel.org, hongxing.zhu@nxp.com,
	imx@lists.linux.dev, kernel@pengutronix.de,
	krzysztof.kozlowski+dt@linaro.org, kw@linux.com,
	l.stach@pengutronix.de, linux-arm-kernel@lists.infradead.org,
	linux-imx@nxp.com, linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org, lpieralisi@kernel.org,
	manivannan.sadhasivam@linaro.org, robh@kernel.org,
	s.hauer@pengutronix.de, shawnguo@kernel.org
Subject: Re: [PATCH v8 00/16] PCI: imx6: Clean up and add imx95 pci support
Message-ID: <ZaWL4QPNwjaeCenJ@lizhi-Precision-Tower-5810>
References: <20240108232145.2116455-1-Frank.Li@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240108232145.2116455-1-Frank.Li@nxp.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?cEx7eL8xWGkKJbUg9S2q01OazDlSxnsAOKiaaJo4XPW5gZoy7ryjs5wRzLGy?=
 =?us-ascii?Q?V2UGDva2N2K8HfAp5wnrgPPuj+fWv/JSmbK1pv8KyrhiBDtk6B68PKKql5mt?=
 =?us-ascii?Q?KS9jHnlirF+syqyVH4EF8NsI7g2llsifTsfW6KUwYi+yuUoWglIvKdMRXRDd?=
 =?us-ascii?Q?SZl2e5JHZoaWG7MCQasrwbxQ/2CXWEuJuhGguiVsSsJzEuxvrPcPGlvEriNE?=
 =?us-ascii?Q?N7gAVL7M630causnlnAwCP4+0oNd7XU/NU3Z+ATPcIRit8TQXNtV01ldllJ5?=
 =?us-ascii?Q?c5eAN5721CFuKnTGpxo6NFCmna1CqonNtNCfZcUH6iGU9tJSTj7UFF4jJZyO?=
 =?us-ascii?Q?+qLK6DaaN4gr0AWJBXe29QIjJlBkroJcfSZHU3nyLR2gXjDI30oGV1oxKAn/?=
 =?us-ascii?Q?FadUQYRo3KHF9SzvTng3vrgHOhMxpQP5lejZBcDM0vbFad+nXetykaDhRHOx?=
 =?us-ascii?Q?950ovRt3LoliFDd4nWBflhNzf4N5ulC+9SVayaVkXGZhcAfirGxsP25yigNv?=
 =?us-ascii?Q?5uepXpu9PsBWLZQc6yP8S0/+kP1ul1LEVCkowEeou0utN+GgQO4rPbj+AJLt?=
 =?us-ascii?Q?qjR4jgD4fK+wCgeR/jy9xndPBnt3xXcIaOaIC82vmMU/cr76xJFkojbqC0fF?=
 =?us-ascii?Q?kq+NTxtkh9fAk6FL+AIyLU0TZTfoTxn+BlpjmRx0twTnLJAtLd1x2Zh40lTw?=
 =?us-ascii?Q?fV5DTeE29HUF9s+ihI2o9hwUaZp4EoqXSp17Luqav38rgBULmH7LU9a31sQw?=
 =?us-ascii?Q?mZCh+f0bxjW3+E8l2tIFpitC1jSdMSH+IMfRjZdLRt8/E8kRxOdkG6ScdQ/6?=
 =?us-ascii?Q?xsKT+KnvohwZjqII+xFvr2L2KtdHdzLwohpyrrAp6Uxz0JJqIe8v5U/vWF6W?=
 =?us-ascii?Q?cfJwPO5vGiv+eRl5uGOfy8Rr2FzfFL97kdGAHJ1mv0dfhGDaZJ+G+H08xTPl?=
 =?us-ascii?Q?M0508qqrkejK4uCRRHWeu6z3WQTMWaKwVDIgDYI/57QSa5wBUJwYHhph/XNL?=
 =?us-ascii?Q?oK2SbZLXNBIDaAW22xpZgXogZRiQYww6dcJKjZFtKucJJRuT5cfTTdpVW4nk?=
 =?us-ascii?Q?o6QDrhAbnFeapxNyu6k7aW2Ckat2zJKN6eEyXDyM0ZbilJPs+k1k+W1cxx34?=
 =?us-ascii?Q?xhqt+2Y8giwNKVKizTxkhe2bHzH4dJ5I0R+eoZzCiYTdh+vWW4gmst6+z5NI?=
 =?us-ascii?Q?etCA7den3u4739AJG/WszDsoSZA9Qwa6nr0KWdFeiY6IoG+bh7vRmrfmYRCE?=
 =?us-ascii?Q?h1IPyFael2hQk7dev/RyqrCNJP9yfqVNCYPOHqt+ZVrIbKfchpIOOLfDwv8n?=
 =?us-ascii?Q?mj727F1Sp/OjiFK2hHJihkU4qya85tIelN5SWut13rz3ws/T5Stmj/VbW3u/?=
 =?us-ascii?Q?vrcFCXElTyPx88EVf4OeI0czrxH1QVr/T6oxOWa93Sf5zqF6vbMQ+AqBoTMF?=
 =?us-ascii?Q?VmZF65tufNmhUiH60HbDfQU2BlIBTCdmd2E6yUPdSS2LTYxs6Z8QfPOyXtf8?=
 =?us-ascii?Q?FP8cRWKhhUuyNR9FRZEStzrF8dyAOINPGRiJJrjShBTzebxPGP4lJN7iqEWd?=
 =?us-ascii?Q?mYW9FIvT7ro61DhNErU=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d0c6eae4-1fe7-498e-d73b-08dc1602dcfe
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2024 19:47:53.4332
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SvcSQ/9y+QuPpteioQo14Zmb087x6uSkdlP7sudUOI8P7SF9gET2mhZutkDGcFmj0mRAKHCiWRIGqPCfS3mOgg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8200

On Mon, Jan 08, 2024 at 06:21:29PM -0500, Frank Li wrote:
> first 6 patches use drvdata: flags to simplify some switch-case code.
> Improve maintaince and easy to read code.

@manivannan:
	Could you help review these? most of these patch have gotten your
review tag. 

Frank

> 
> Then add imx95 basic pci host function.
> 
> follow two patch do endpoint code clean up.
> Then add imx95 basic endpont function.
> 
> Compared with v2, added EP function support and some fixes,  please change
> notes at each patches.
> 
> dt-binding pass pcie node:
> 
> pcie0: pcie@4c300000 {
>                         compatible = "fsl,imx95-pcie";
>                         reg = <0 0x4c300000 0 0x40000>,
>                                 <0 0x4c360000 0 0x10000>,
>                                 <0 0x4c340000 0 0x20000>,
>                                 <0 0x60100000 0 0xfe00000>;
>                         reg-names = "dbi", "atu", "app", "config";
>                         #address-cells = <3>;
>                         #size-cells = <2>;
>                         device_type = "pci";
>                         linux,pci-domain = <0>;
>                         bus-range = <0x00 0xff>;
>                         ranges = <0x81000000 0x0 0x00000000 0x0 0x6ff00000 0 0x00100000>,
>                                  <0x82000000 0x0 0x10000000 0x9 0x10000000 0 0x10000000>;
>                         num-lanes = <1>;
>                         num-viewport = <8>;
>                         interrupts = <GIC_SPI 310 IRQ_TYPE_LEVEL_HIGH>;
>                         interrupt-names = "msi";
>                         #interrupt-cells = <1>;
>                         interrupt-map-mask = <0 0 0 0x7>;
>                         interrupt-map = <0 0 0 1 &gic 0 0 GIC_SPI 309 IRQ_TYPE_LEVEL_HIGH>,
>                                         <0 0 0 2 &gic 0 0 GIC_SPI 308 IRQ_TYPE_LEVEL_HIGH>,
>                                         <0 0 0 3 &gic 0 0 GIC_SPI 307 IRQ_TYPE_LEVEL_HIGH>,
>                                         <0 0 0 4 &gic 0 0 GIC_SPI 306 IRQ_TYPE_LEVEL_HIGH>;
>                         fsl,max-link-speed = <3>;
>                         clocks = <&scmi_clk IMX95_CLK_HSIO>,
>                                  <&scmi_clk IMX95_CLK_HSIOPLL>,
>                                  <&scmi_clk IMX95_CLK_HSIOPLL_VCO>,
>                                  <&scmi_clk IMX95_CLK_HSIOPCIEAUX>;
>                         clock-names = "pcie", "pcie_bus", "pcie_phy", "pcie_aux";
>                         assigned-clocks =<&scmi_clk IMX95_CLK_HSIOPLL_VCO>,
>                                          <&scmi_clk IMX95_CLK_HSIOPLL>,
>                                          <&scmi_clk IMX95_CLK_HSIOPCIEAUX>;
>                         assigned-clock-rates = <3600000000>, <100000000>, <10000000>;
>                         assigned-clock-parents = <0>, <0>,
>                                                  <&scmi_clk IMX95_CLK_SYSPLL1_PFD1_DIV2>;
>                         power-domains = <&scmi_devpd IMX95_PD_HSIO_TOP>;
>                         /* 0x30~0x37 stream id for pci0 */
>                         /*
>                          * iommu-map = <0x000 &apps_smmu 0x30 0x1>,
>                          * <0x100 &apps_smmu 0x31 0x1>;
>                          */
>                         status = "disabled";
>                 };
> 
> pcie1: pcie-ep@4c380000 {
>                         compatible = "fsl,imx95-pcie-ep";
>                         reg = <0 0x4c380000 0 0x20000>,
>                               <0 0x4c3e0000 0 0x1000>,
>                               <0 0x4c3a0000 0 0x1000>,
>                               <0 0x4c3c0000 0 0x10000>,
>                               <0 0x4c3f0000 0 0x10000>,
>                               <0xa 0 1 0>;
>                         reg-names = "dbi", "atu", "dbi2", "app", "dma", "addr_space";
>                         interrupts = <GIC_SPI 317 IRQ_TYPE_LEVEL_HIGH>;
>                         interrupt-names = "dma";
>                         fsl,max-link-speed = <3>;
>                         clocks = <&scmi_clk IMX95_CLK_HSIO>,
>                                  <&scmi_clk IMX95_CLK_HSIOPLL>,
>                                  <&scmi_clk IMX95_CLK_HSIOPLL_VCO>,
>                                  <&scmi_clk IMX95_CLK_HSIOPCIEAUX>;
>                         clock-names = "pcie", "pcie_bus", "pcie_phy", "pcie_aux";
>                         assigned-clocks =<&scmi_clk IMX95_CLK_HSIOPLL_VCO>,
>                                          <&scmi_clk IMX95_CLK_HSIOPLL>,
>                                          <&scmi_clk IMX95_CLK_HSIOPCIEAUX>;
>                         assigned-clock-rates = <3600000000>, <100000000>, <10000000>;
>                         assigned-clock-parents = <0>, <0>,
>                                                  <&scmi_clk IMX95_CLK_SYSPLL1_PFD1_DIV2>;
>                         power-domains = <&scmi_devpd IMX95_PD_HSIO_TOP>;
>                         status = "disabled";
>                 };
> 
> Frank Li (15):
>   PCI: imx6: Simplify clock handling by using clk_bulk*() function
>   PCI: imx6: Simplify phy handling by using IMX6_PCIE_FLAG_HAS_PHYDRV
>   PCI: imx6: Simplify reset handling by using by using
>     *_FLAG_HAS_*_RESET
>   dt-bindings: imx6q-pcie: Add linux,pci-domain as required for iMX8MQ
>   PCI: imx6: Using "linux,pci-domain" as slot ID
>   PCI: imx6: Simplify ltssm_enable() by using ltssm_off and ltssm_mask
>   PCI: imx6: Simplify configure_type() by using mode_off and mode_mask
>   PCI: imx6: Simplify switch-case logic by involve init_phy callback
>   dt-bindings: imx6q-pcie: Clean up irrationality clocks check
>   dt-bindings: imx6q-pcie: restruct reg and reg-name
>   PCI: imx6: Add iMX95 PCIe Root Complex support
>   PCI: imx6: Clean up get addr_space code
>   PCI: imx6: Add epc_features in imx6_pcie_drvdata
>   dt-bindings: imx6q-pcie: Add iMX95 pcie endpoint compatible string
>   PCI: imx6: Add iMX95 Endpoint (EP) support
> 
> Richard Zhu (1):
>   dt-bindings: imx6q-pcie: Add imx95 pcie compatible string
> 
>  .../bindings/pci/fsl,imx6q-pcie-common.yaml   |  28 +-
>  .../bindings/pci/fsl,imx6q-pcie-ep.yaml       |  57 +-
>  .../bindings/pci/fsl,imx6q-pcie.yaml          |  49 +-
>  drivers/pci/controller/dwc/pci-imx6.c         | 643 ++++++++++--------
>  4 files changed, 465 insertions(+), 312 deletions(-)
> 
> -- 
> 2.34.1
>