Received-SPF: pass (google.com: domain of linux-kernel+bounces-26447-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240115135416.10595-1-mitrutzceclan@gmail.com> <20240115135416.10595-3-mitrutzceclan@gmail.com>
In-Reply-To: <20240115135416.10595-3-mitrutzceclan@gmail.com>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Mon, 15 Jan 2024 21:52:20 +0200
Message-ID: <CAHp75VcjcgnLkQWim1AVnyeRGFwwKpaWSCvrmqdv41Lx87hMKw@mail.gmail.com>
Subject: Re: [PATCH 2/2] iio: adc: ad7173: add support for additional models
To: Dumitru Ceclan <mitrutzceclan@gmail.com>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl, andy@kernel.org, 
	linux-gpio@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>, 
	Jonathan Cameron <jic23@kernel.org>, Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Arnd Bergmann <arnd@arndb.de>, ChiaEn Wu <chiaen_wu@richtek.com>, 
	Niklas Schnelle <schnelle@linux.ibm.com>, =?UTF-8?Q?Leonard_G=C3=B6hrs?= <l.goehrs@pengutronix.de>, 
	Mike Looijmans <mike.looijmans@topic.nl>, Haibo Chen <haibo.chen@nxp.com>, 
	Hugo Villeneuve <hvilleneuve@dimonoff.com>, Ceclan Dumitru <dumitru.ceclan@analog.com>, 
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 15, 2024 at 3:54=E2=80=AFPM Dumitru Ceclan <mitrutzceclan@gmail=
com> wrote:
>
> Add support for Analog Devices AD7172-2, AD7175-8, AD7177-2

Missing period.

..

> + * AD717X family SPI ADC driver

X --> x

..

> + * Suported devices:

Supported

..

> + *  AD7172-2 AD7172-4 AD7173-8 AD7175-2 AD7175-8 AD7176-2 AD7177-2

Too long and no good delimiter (like comma), can you reformat this list?

..

> +#define AD7172_2_ID                    0x00d0
> +#define AD7172_4_ID                    0x2050
>  #define AD7173_ID                      0x30d0
> +#define AD7175_2_ID                    0x0cd0
> +#define AD7175_8_ID                    0x3cd0
>  #define AD7176_ID                      0x0c90
> +#define AD7177_ID                      0x4fd0

Why not order by the ID value?

..

> +               //AD7177-2 has the filter values [0-6] marked as reserved
> +               // datasheet page 58

Be consistent with the type of comments. Either all C++ style or C.
Also missing space in the first line.

..

> +               if (ref_sel =3D=3D AD7173_SETUP_REF_SEL_INT_REF &&
> +                   st->info->id =3D=3D AD7172_2_ID){

Missing space.

> +                       fwnode_handle_put(child);
> +                       return dev_err_probe(dev, -EINVAL, "Internal refe=
rence is not available on ad7172-2\n");
> +               }

Not sure if Jonathan makes his series in for fwnode handle RAII.

--=20
With Best Regards,
Andy Shevchenko