Received: by 2002:a05:7412:8d09:b0:fa:4c10:6cad with SMTP id bj9csp55447rdb; Mon, 15 Jan 2024 11:57:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IHOm8sHw+J4xO4ZMDgzCu6SaKRdVACo0TgArMQK0jlPmQPy1ckAFTBfJ9IOljPe1mpXfnDD X-Received: by 2002:a05:6359:5ea9:b0:175:6ac9:1c5d with SMTP id px41-20020a0563595ea900b001756ac91c5dmr5306024rwb.59.1705348626588; Mon, 15 Jan 2024 11:57:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705348626; cv=none; d=google.com; s=arc-20160816; b=hwQRSecP5RjHWdPhHxVeArPWV39ITpt4sm6fXRTCsLPHHtR4+OX0fNxAliQ4n8k6Me UeudBtVfv9ENKoGuwL6Rbl/UYgcBdT4Ms2CTu4ihEHnBM/XA0kUR+CvfY8WBk/o7SQ44 NjSdE2k++U91fZXgs+Yyyh3XfE1AmK1jxh2yJh4u8wns0PRBuvU8O+sfNPBQqLGGbXtO En4M05fxE6jagVnd4Tlk5JwyzMO99mBpX6NbK9uBYcUffuBqidPm1themTLzWG7nufcZ I1BgxP6XPPn/w985rLvR/r/32vaDnsh+jDifu0Xyn4V+7k/3uF9mt9VlqIRt1Ou2+nQu lcRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=DbH1EBS7ke3snntUiXBmVip+0EkPVKygozznbaF6iRQ=; fh=SwzX0tglQFYcPD71mvgbAwSYlQ5cQ3p+hpmdhIQdgbM=; b=iTTUV0M5xj2FvcGDhJOeiwnNbO4c3z761oxaUy3DpOYkj1HyNpOzFAO/pIk/fpy8kh j8Tz25nWr3d1sxZpJuW8C1P1jppRrQf6upkIkK7Co3+vdsVYFs0LLSO2/1eCbyTUNwxc yVME/6GbZ9LvaoJTccSzGQi8hjjVW7/RrjMYhTHJo784FKixYo6ZM/gCmMwbbK+1EJn1 YJVkW1B1iIFiiyWBFpB8Yx9BgUXbkQkjVZVnZG0S0jLiSKDo09aYOfI4/uuO0RnWQXd5 qM83fNYCHyrKeBgrcyfPUVKopGcao4K++uquiG2/0RZV9+fbzXR7zeZZ571Rt2H40G62 ObYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=l1+TXjzr; spf=pass (google.com: domain of linux-kernel+bounces-26450-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-26450-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id k26-20020a63ba1a000000b005ce05e5d57asi9435864pgf.660.2024.01.15.11.57.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jan 2024 11:57:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-26450-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=l1+TXjzr; spf=pass (google.com: domain of linux-kernel+bounces-26450-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-26450-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id BD42AB21EC9 for ; Mon, 15 Jan 2024 19:57:01 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8E06A1946C; Mon, 15 Jan 2024 19:56:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l1+TXjzr" Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DA361798F; Mon, 15 Jan 2024 19:56:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-40e586a62f7so68259225e9.2; Mon, 15 Jan 2024 11:56:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705348605; x=1705953405; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9VpU6+YHkvn08adzjTfnX/FYJd9oIMlOMtpUIvBTFqE=; b=l1+TXjzrwEaAtVkA9xpaTv4TV4xPhRinXvJ0Ja5eg/nbIKHRilBrTs8T96Cc2nehH9 nXvxaLS4bB0x3cXRa2EpDEhUjPuV4FRdARv9iEHYaaKPD1FZJKrLY8IUA/3IdmKcu0JX PFgj46MxGB2VBVm+YVHhPV8z7evrmGL6G/9xJe0F/xVUdrSXwM6OI9nxyD1bIVi1Uz29 GzXYpgj/xJG0Yw/7XIlmfN01Lc20l5GmsX+iPDk8S+i+/xTp3OJ0YKhornWVBNXyZkJy XK2VV58zNHgHyumkSKsyHRKjIGgxXhS2KMQesOG6tYoaL3XkEMiTXsVTLFll4y+8IdAZ ovSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705348605; x=1705953405; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9VpU6+YHkvn08adzjTfnX/FYJd9oIMlOMtpUIvBTFqE=; b=sjVPwcUHtFcRj07mJZz+TBrW7gjQuaTwckhkVd8yQo6aNpK+hA/Lh71msTszf0TxiP 1j3SQJlIM/XnIdInhEKzWoe2S/K88DofxHC54OhG83ERi4s/Z+otYm4brJEnfJFDHGsV DhGRN5T5u0OCRK0kdl1I6zbtoDHCXjJrrKc6LA5boFv/+Lw5ucMGttdKrYTfoGfzOIiA ceR0mj7RT6AEQ2Y2OcT9lRE4LiqvoJvwHZjvq1sW8i81Jh9JwukuZtn/kwl1Jdntuai2 F0euL8kMWGBDeCTfcdTo1mPXu/biREN7MD8MWno3uYau/WKZjGvZJk16YuP3HomqvnQw g9hQ== X-Gm-Message-State: AOJu0YxHgGh8KNNXgVTol+mEd21L1uQNWe+FdCSXNcWGtGXymkTGGBlN Lc076mQu3w+A6kSx7vJvqtYV1/W8AS/bOdQTL9U= X-Received: by 2002:a05:600c:1d95:b0:40e:6dfb:7b3f with SMTP id p21-20020a05600c1d9500b0040e6dfb7b3fmr2194829wms.95.1705348605229; Mon, 15 Jan 2024 11:56:45 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240102-j7200-pcie-s2r-v1-0-84e55da52400@bootlin.com> <20240102-j7200-pcie-s2r-v1-1-84e55da52400@bootlin.com> In-Reply-To: <20240102-j7200-pcie-s2r-v1-1-84e55da52400@bootlin.com> From: Andy Shevchenko Date: Mon, 15 Jan 2024 21:56:09 +0200 Message-ID: Subject: Re: [PATCH 01/14] gpio: pca953x: move suspend/resume to suspend_noirq/resume_noirq To: Thomas Richard Cc: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Tony Lindgren , Haojian Zhuang , Vignesh R , Aaro Koskinen , Janusz Krzysztofik , Andi Shyti , Peter Rosin , Vinod Koul , Kishon Vijay Abraham I , Philipp Zabel , Tom Joseph , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, gregory.clement@bootlin.com, theo.lebrun@bootlin.com, thomas.petazzoni@bootlin.com, u-kumar1@ti.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jan 15, 2024 at 6:16=E2=80=AFPM Thomas Richard wrote: > > Some IOs can be needed during suspend_noirq/resume_noirq. ->suspend_noirq() / ->resume_noirq() > So move suspend/resume callbacks to noirq. .. > -static DEFINE_SIMPLE_DEV_PM_OPS(pca953x_pm_ops, pca953x_suspend, pca953x= _resume); > +static const struct dev_pm_ops pca953x_pm_ops =3D { > + SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(pca953x_suspend_noirq, pca953x_resu= me_noirq) > +}; Please, use correct / modern macro. --=20 With Best Regards, Andy Shevchenko