Received: by 2002:a05:7412:8d09:b0:fa:4c10:6cad with SMTP id bj9csp60211rdb; Mon, 15 Jan 2024 12:06:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IFUgbI03jCJQyvj6bu9mMctzKg4Zi/uSdgUholX60zqQd4jCdHqvFEIBhIvmqyiuYGjCw/9 X-Received: by 2002:a05:6359:4103:b0:175:78df:7a69 with SMTP id kh3-20020a056359410300b0017578df7a69mr3860580rwc.35.1705349203180; Mon, 15 Jan 2024 12:06:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705349203; cv=none; d=google.com; s=arc-20160816; b=abS8OisD5B3g/gd9Ctye/gOKhd6NfJqPHOWmEpFOIgCUxVZSX/Cv/RW5gILlJDnVa2 cLXIrBZ7WV52452BFRyYfkiRC7mCSPNpcckCUkftaFxmPOYwy6sng+NdZWERtsK5Z+WZ 7IQQJQOkuE44HA1m0+3Kb/MjXcuGITFd8PzESxbNmi6aaXK+7+YMGCzC6Q8MXv+u4s9G JyQ+yOEFLa9usRsGggdyYDLI77o9+U1RC0+vN8nhKNp3sx9B6itHAx0bKNUjCJPUSaWq QYWlB/BtbkL5b07eYs1CkbmdntFvjJFRlJynUPkjCxJa3EGEdsyZ4Nc177sc4dffvsxS RC8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=nGRylkWIm0Flxrp4dnVTDO7Nn3vgX6kG/NA1KUiqzwk=; fh=SwzX0tglQFYcPD71mvgbAwSYlQ5cQ3p+hpmdhIQdgbM=; b=nL2edC1CdxO7xZKvpshVPR4RbVRcx2kUJZ9Gdy4ojbiu/aqKzt1exNDY/zKuaApVMl gst/sa7kzSnp8h0FlPzn7sfQITzShIhxl7RO2BjVz5YQmXquzIpFkk8kEgsksaBOR0JX eXa9zhaoynJvAhiJTIHH0WcoB5B6KrnszTQF0u1yTTjc+NaIlnogaYUTT4bS9PweO+QE RZ33BpDhqb2rmmrsp9jd/xGSJ21xpNlb3+0C8UQwBV12T1FnSjLpGbIbvnwiQHu3PQqD RbWtqls0ko/7pnF2jU3xHwiu3dnpgSTCtZsv0RPovmE/XtqgS6V5rdy6+1VSxpHYIWmF crjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=D4NHu6N7; spf=pass (google.com: domain of linux-kernel+bounces-26461-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-26461-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id p41-20020a056a000a2900b006db88321489si1408928pfh.326.2024.01.15.12.06.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jan 2024 12:06:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-26461-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=D4NHu6N7; spf=pass (google.com: domain of linux-kernel+bounces-26461-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-26461-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id C1EBB283775 for ; Mon, 15 Jan 2024 20:06:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 666FF199A1; Mon, 15 Jan 2024 20:06:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D4NHu6N7" Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D46518E2A; Mon, 15 Jan 2024 20:06:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-55969c01168so1388652a12.1; Mon, 15 Jan 2024 12:06:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705349188; x=1705953988; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=87z/U/eZmGA0TAuJWEdp0n7QdUhBeveGTh40YHaQDwQ=; b=D4NHu6N7CpjfCfWhuL4FAv97HkJvhuR++KXjQqvRchEjgm4it5w07ETx6kIibNpSoh k1IYEhVen57wNaqlcdaGcPrqEqVgLrWsA7qbUayk9LmWUAMWFBk2TUfpiZuPgK6VMf9P Z+UVfGyF5o/bomXrtPJ8+1m3rfRAXVLkZmpImtf6bGj0O79gqtM0ZYFVZlCcUV5y9i7H p1TJjLqJlVj+HOFBS6w69XscaYQEUpq20EkIK+tTwl0soYPyDumEyrReu576ABF97Yv/ Xv9QPtNNqBKICnErO1j+TirzygBVTswYHPLdZ/A2dyneX7b8ZBrd5mLbjGs7bqhvL6Vz msug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705349188; x=1705953988; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=87z/U/eZmGA0TAuJWEdp0n7QdUhBeveGTh40YHaQDwQ=; b=OiuEc0kKIVnTo8lzucNDyfidTHW7lq7mWG2KBMavhhPtzjxn7BYKQlR47VAdXPO/mZ 0SWoftjlhfxQeOf6zAl3LnjrrgJ0fpPiiojphTZ0LduRFBBD26VwckZEP1YkmY4/nNJZ T/F9I7Dmp4R39Cx4pZWeME8VKywKOki2ggYYISFkQfMbsUo3awy2L1KXnjgpq2I5KIy9 4CJdaY28ELccP+pOtdkpORzOhzpE7HmDW5vYL0DiybC+tCrT9x7dXOanBxriXMbhbGd7 mrl+Jf3Br71bBT8HwBKef/rOdX9oPCndoZj4SX1cUQkPma3ixxuVEV2ZYIAbFacVlFoQ jnOg== X-Gm-Message-State: AOJu0YxCFZ9oXxJULJpvh0XPv+kf0+NG6+OHp1A6PIN7mFyLZ+WvOmB4 tvy2W29+IDWSAKQ4gSMQXdpa618PVpBoqdn8AXo= X-Received: by 2002:a17:907:3dac:b0:a23:690e:48bf with SMTP id he44-20020a1709073dac00b00a23690e48bfmr7583783ejc.12.1705349188168; Mon, 15 Jan 2024 12:06:28 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240102-j7200-pcie-s2r-v1-0-84e55da52400@bootlin.com> <20240102-j7200-pcie-s2r-v1-4-84e55da52400@bootlin.com> In-Reply-To: <20240102-j7200-pcie-s2r-v1-4-84e55da52400@bootlin.com> From: Andy Shevchenko Date: Mon, 15 Jan 2024 22:05:52 +0200 Message-ID: Subject: Re: [PATCH 04/14] mux: mmio: Add resume support To: Thomas Richard Cc: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Tony Lindgren , Haojian Zhuang , Vignesh R , Aaro Koskinen , Janusz Krzysztofik , Andi Shyti , Peter Rosin , Vinod Koul , Kishon Vijay Abraham I , Philipp Zabel , Tom Joseph , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, gregory.clement@bootlin.com, theo.lebrun@bootlin.com, thomas.petazzoni@bootlin.com, u-kumar1@ti.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jan 15, 2024 at 6:16=E2=80=AFPM Thomas Richard wrote: > > From: Th=C3=A9o Lebrun > > Implement resume support Why? .. > +#ifdef CONFIG_PM No ifdeffery, use proper macros. .. > + dev_err(dev, "control %u: error restoring mux: %d= \n", i, ret); Won't anything go wrong and spam the log buffer? --=20 With Best Regards, Andy Shevchenko