Received-SPF: pass (google.com: domain of linux-kernel+bounces-26511-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <d12c2a3e-2a66-4624-b5e9-9921f3359036@amd.com>
Date: Mon, 15 Jan 2024 16:51:52 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] drm/amd/display: Fix a switch statement in
 populate_dml_output_cfg_from_stream_state()
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
 Harry Wentland <harry.wentland@amd.com>, Leo Li <sunpeng.li@amd.com>,
 Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
 Alex Deucher <alexander.deucher@amd.com>,
 =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
 "Pan, Xinhui" <Xinhui.Pan@amd.com>, David Airlie <airlied@gmail.com>,
 Daniel Vetter <daniel@ffwll.ch>, Roman Li <roman.li@amd.com>,
 Qingqing Zhuo <Qingqing.Zhuo@amd.com>
Cc: dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org,
 linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org
References: <e597276a8240329a5ece90762425c7cde2ddd7a2.1705157202.git.christophe.jaillet@wanadoo.fr>
Content-Language: en-US
From: Hamza Mahfooz <hamza.mahfooz@amd.com>
In-Reply-To: <e597276a8240329a5ece90762425c7cde2ddd7a2.1705157202.git.christophe.jaillet@wanadoo.fr>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?STQwcjAxTzNWQlRqRVVEL2xZVXE4WDZxbytLbDV5Q2tYbk1Ha1Z3Y3pvYlc4?=
 =?utf-8?B?UzdJUUpra0l2VUYvOFM5S3lGT2FzTk5neC9Ubk50cTR2eWJqcnNTYTEyQ3Zu?=
 =?utf-8?B?bXJTbGxjRXdlNHRGck51bmorbjQreVBqZ3paSTZDVHVnOFk2YWNVeEtXSkpM?=
 =?utf-8?B?bU9vUm1BcnVKYWNaOFhIN0M4MU9KMldjajZLUVJmMEdKOThsR2gyelR0NGN5?=
 =?utf-8?B?WVM5blVpeW9qWlVPUDdVT1g2c1ZFbldJclpCTE9DVUFRWW00dEVYcXlJMHBw?=
 =?utf-8?B?cW0xbHpvY0RmK0g4d2wrSFFQNUYxRWt1SE8wQjMrWEtrd0syclBFNkNEcGxK?=
 =?utf-8?B?cTlFdzZDUWZyWDNjVXpERi9yWDFaa2VqdnU0MzBOOHJwWEJuLzdrV0lkekdL?=
 =?utf-8?B?RUZ0N3dTbzQ4czdXRDJhYXhVMm9nY0oxNklWUFNBODVBaVJJVVU2cUtXeWxH?=
 =?utf-8?B?RFZJZVgwb3dyN3BCQU53RkorUG4rUEFNeTV1dlEzcjFZaEdmUzJMcFVHcC9s?=
 =?utf-8?B?THlXUzVPcm0wc0laaWQ3L3FuMkNQTkNQMWZJMXdFbUxQK0J0Skt3aVpRd0Fr?=
 =?utf-8?B?K2VDeFVkTGtwQ3VwajZxVlhuQzV4UGlPdFhEd01BQmVrRVIxNFBvT1B3OUwr?=
 =?utf-8?B?cHA1aE5SWllXWjJnNGlhbFFTTnVqRExTdzFXTjNHR3BpTEVwalJBdVFYZzcv?=
 =?utf-8?B?VmJ6elBObG4yT29oVG9oOGpPeiszTDM4VWZ5VVZxTHU2dEMwMzNJaEhrZEE3?=
 =?utf-8?B?TTE0VlBpeEE2OFJKNm1TK0FYOExwbTlxSGhrczRMV3ZjMGhlVGt5RC9WUlRL?=
 =?utf-8?B?R2dBcDJ2Z3BWUnk0Si9OZkY1ZktuZ3RLdm5GTWs5Z1pHSEN2OTNzUXIySlZP?=
 =?utf-8?B?OGttY1MwNlhlTmZidzFQQXhuQlVPQ0JPRXJVYTg3dVFtNmk2OHFiQXpUd096?=
 =?utf-8?B?WWhnUEFaQjlrRHhNQTNtNEJiU1VMUjdtWmczd0ZERDVLYnRrZG5aNk1XclB4?=
 =?utf-8?B?N3pScnJRQ1Rqc0xVenJ1V2lYTUlRUlFRQTY4RzZKejFYS01XRFltYWlHclA0?=
 =?utf-8?B?Y3lxYThEQWduZjNNNmRXYkdiVFhCdUVZTWFBQzgxZFBrTjZndTN1aGVLcnhJ?=
 =?utf-8?B?NktLQUwzdmozblJVbk43TFN1bTRWT3JIbW5RdnZ4K2lWaFp0RmxOYzFuYmF5?=
 =?utf-8?B?K1FTaVhwSEcvdVFzVjc5N3NmdzBDc3dyWVMxS3pEY2dhUkd3ZVBZeW1TOTFx?=
 =?utf-8?B?S0pkYkg1QnI0UlNtRU1NN0xiRXlJUmRRb0xuUDdvS2NNYU9MeDRmWVVhcHk5?=
 =?utf-8?B?c3NTYmhMakdNK0NZL0FZa0N1MVptdUxDZUtqQnlKSjllR1M1dzZ1K3FiM3lK?=
 =?utf-8?B?Z2tCYkZjYjRQOE9jeGxZTU54ZVZ0WnlMazZHUjBrVm9yTW4rRnhQaWtVSUtp?=
 =?utf-8?B?SWlodzNrRTZBUUUvcWVwaUxrZDdScGtWVWdPa0tqdWtiWUZ5OU94MmhQMjVr?=
 =?utf-8?B?amNrL2RWT25BU0t0MWE4eGgxVmU3cWdpMkpvb0doK0wveDVuSUd4OURzV0ZS?=
 =?utf-8?B?c2s1N1VETnp4a3dHYmcwZ0YzeVBnKzhlbHRRVmVKbzZZUjBNcVNlS1RpNStr?=
 =?utf-8?B?VlpLN1Y4YXVEdDZQSkV1bUlLWGF1TXFxTkJqcHBBamhlNFhlSFpQcG9XazJk?=
 =?utf-8?B?MzQyMlcwL00yZDVCL0tXRENHdjhhZVVhUGc1MVNqZ01ZKzdKRmprOUJDQUMx?=
 =?utf-8?B?WHoraHZRa25CSFRtQ1dTa2ZkdlVnS0pyOGZFUHZDOVQzaGpDMy9ObU1qbGVm?=
 =?utf-8?B?Z3BSYUo3NHNqTUx6cFpheVZ4a2ZHdUtoS0FQYkYwZ1RwZVkxTmJSaEMrd3h1?=
 =?utf-8?B?WlBJRU96UGNUTk9IbEVhRzlOSjhCNHdQVC95T2JST2xwOGNhSDZTSElwME1X?=
 =?utf-8?B?eHFPeGIxZkQ0WGwwZW9OSDVyeVhkLzA5SkZUT2lERjNYTktJS3JqZVFsQkV6?=
 =?utf-8?B?L2o2eW1xVzZFMXRNVnU2RHJlVlUrVCttc0U1dVhXdUt6SFIzZUhKelZ0RUVF?=
 =?utf-8?B?OXBOZ1lVdEQ4OG1WWkNVYWdSTkdxTVl6NHNCUnlNSjlqeWF6dkMzL3paclh5?=
 =?utf-8?Q?cKV/9c8FOOWrXpIBYQaS6Q8JS?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2478011b-54b5-4aa9-544a-08dc16143143
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6280.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2024 21:51:56.2727
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GoKl+UWAMNOBgh91AwoyfemAico71Uaz02/ypIQdqxpZB066bGnE7xlhfdr6DbEYxs5CC0lPy32nMOrgN8YebQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7665

On 1/13/24 09:58, Christophe JAILLET wrote:
> It is likely that the statement related to 'dml_edp' is misplaced. So move
> it in the correct "case SIGNAL_TYPE_EDP".
> 
> Fixes: 7966f319c66d ("drm/amd/display: Introduce DML2")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Nice catch! Applied, thanks!

> ---
>   drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c b/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c
> index fa6a93dd9629..64d01a9cd68c 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c
> @@ -626,8 +626,8 @@ static void populate_dml_output_cfg_from_stream_state(struct dml_output_cfg_st *
>   		if (is_dp2p0_output_encoder(pipe))
>   			out->OutputEncoder[location] = dml_dp2p0;
>   		break;
> -		out->OutputEncoder[location] = dml_edp;
>   	case SIGNAL_TYPE_EDP:
> +		out->OutputEncoder[location] = dml_edp;
>   		break;
>   	case SIGNAL_TYPE_HDMI_TYPE_A:
>   	case SIGNAL_TYPE_DVI_SINGLE_LINK:
-- 
Hamza