Received: by 2002:a05:7412:8d09:b0:fa:4c10:6cad with SMTP id bj9csp135540rdb; Mon, 15 Jan 2024 15:22:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IEw4t2mYfXqUt1QjEGYPi+hFLq0JYTyM6+/scY/pM29zgV0YXiAN35PT/tItvJlvjGZ48Nf X-Received: by 2002:a05:6a00:a1b:b0:6d9:bd62:bf8a with SMTP id p27-20020a056a000a1b00b006d9bd62bf8amr3824470pfh.68.1705360964986; Mon, 15 Jan 2024 15:22:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705360964; cv=none; d=google.com; s=arc-20160816; b=EwbfatLSRQEwqKfnH8ZHUPZWrRwyUbdNYeEUQ23NCwWmhgB4b7gtcHzAAWzFpcrB6E xT43tmklFRDb+mkWkX4uvg1NtnLvlzRLtp90PU38FtfzffFos4GqeG/JWbUBsvRRq3VL RL5/LZ0G/clult0k10lfL4OFel1Ptc7URkVNzkjMIecFWprVHew2WH6FzTfKxJb/dh11 b5eciOWoE6I8/I3bJRhneYHK8zgcHVV8KguMkj2JDzxXgzLgi2WLIwuN8TlRRvG9RT04 7ZlKNmmTLwtjNnTwDxcNDrVUtTbXoXRGOg0MuV+eP53DNYMxktbgve+1XDsFv6rxTtTg yBTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=MZoQRbudR0nr1ST4F7AMUIQKL7EqS+GqfmQTeUc6QIo=; fh=4Hu6a1oOd2qZzOoGo6asIB0VDXzMkGQThOl2sostdJ0=; b=YsryCq0sLF63mX9uHHOWOyzAlfCZYY8FWdWIVgILohYiV4qTaBJUmRgXuwT4PMmpLH 1azMrzABks9jZilf72l6uYh1t5os1PK1c4EFzA2soFBA90qt/Ne3wujJHoxtVLxbnjwR /+58+wJoO2o7pkwWFOv5dYQL2KPIjTswhu/7t1W1JUDCx2IFdBO92ArotCJqghu8TgHN kwFyxFC/nDmxutR6JR81+wY5rL/HiilR+yJSQnPUO2DHRK4D1dJ2VvQFCmzCEo3cRcfw gpGctswyZ95a5jhZ9vKEstKmz/RS7HiaPL7Sjvx9FU55rx9X/xEHpAbSzh/GHvDTm80m 11nw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=oKaeMWgN; spf=pass (google.com: domain of linux-kernel+bounces-26527-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-26527-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id q13-20020a056a00088d00b006db3b3ea0eesi10370488pfj.209.2024.01.15.15.22.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jan 2024 15:22:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-26527-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=oKaeMWgN; spf=pass (google.com: domain of linux-kernel+bounces-26527-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-26527-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 19BB4283B9D for ; Mon, 15 Jan 2024 23:22:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5C4601B7F6; Mon, 15 Jan 2024 23:22:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="oKaeMWgN" Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5AAE1B7E0; Mon, 15 Jan 2024 23:22:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 1229E240004; Mon, 15 Jan 2024 23:22:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1705360941; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MZoQRbudR0nr1ST4F7AMUIQKL7EqS+GqfmQTeUc6QIo=; b=oKaeMWgN2U9zyL8KCCc6vNlnMxv6Ju6RPulN0NB8l9Nsu92PSH/kHAmc+22HC0HS7Hxi2H wgQkaV3Z5wdSetHfxSe+g/+2xXpUin7PdoQgFBtSVWkHfj7Askk+orH8qG5rvzl4UKUcQy DB329L8FadlEF8APxitAWWg1ez5B+U8k6eVkLJyaTThatErwF36Lg5G+ffy3JEjV4PBK/t J1Q9W8qnLVR3oc4GQ4r/IE1NPCkEaSWb0uGq9/8sDO892d/5G9u/k+aVdjapdyzIn4RV7k 9n6PKgmmQHZZLewFiAuvpdt+xXFb8RtDuQ0awGXuKPGtkR2yRIK3948p3u2qKw== From: alexandre.belloni@bootlin.com To: Antoniu Miclaus , Alexandre Belloni Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] rtc: max31335: use regmap_update_bits_check Date: Tue, 16 Jan 2024 00:22:14 +0100 Message-ID: <20240115232215.273374-2-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240115232215.273374-1-alexandre.belloni@bootlin.com> References: <20240115232215.273374-1-alexandre.belloni@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-GND-Sasl: alexandre.belloni@bootlin.com From: Alexandre Belloni Simplify the IRQ handler by using regmap_update_bits_check. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-max31335.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-max31335.c b/drivers/rtc/rtc-max31335.c index 2ce23f60a7f3..a38d303d9df4 100644 --- a/drivers/rtc/rtc-max31335.c +++ b/drivers/rtc/rtc-max31335.c @@ -348,18 +348,16 @@ static int max31335_alarm_irq_enable(struct device *dev, unsigned int enabled) static irqreturn_t max31335_handle_irq(int irq, void *dev_id) { struct max31335_data *max31335 = dev_id; - int ret, status; + bool status; + int ret; - ret = regmap_read(max31335->regmap, MAX31335_STATUS1, &status); + ret = regmap_update_bits_check(max31335->regmap, MAX31335_STATUS1, + MAX31335_STATUS1_A1F, 0, &status); if (ret) return IRQ_HANDLED; - if (FIELD_GET(MAX31335_STATUS1_A1F, status)) { - regmap_update_bits(max31335->regmap, MAX31335_STATUS1, - MAX31335_STATUS1_A1F, 0); - + if (status) rtc_update_irq(max31335->rtc, 1, RTC_AF | RTC_IRQF); - } return IRQ_HANDLED; } -- 2.43.0