Received-SPF: pass (google.com: domain of linux-kernel+bounces-26611-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Eric Mackay <eric.mackay@oracle.com>
To: cl@linux.com
Cc: linux@armlinux.org.uk, Jonathan.Cameron@Huawei.com, Matteo.Carlini@arm.com,
        Valentin.Schneider@arm.com, akpm@linux-foundation.org,
        anshuman.khandual@arm.com, catalin.marinas@arm.com,
        dave.kleikamp@oracle.com, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org, robin.murphy@arm.com,
        vanshikonda@os.amperecomputing.com, yang@os.amperecomputing.com
Subject: Re: [PATCH] ARM64: Dynamically allocate cpumasks and increase supported CPUs to 512
Date: Mon, 15 Jan 2024 15:59:11 -0800
Message-Id: <20240115235911.80586-1-eric.mackay@oracle.com>
In-Reply-To: <794a1211-630b-3ee5-55a3-c06f10df1490@linux.com>
References: <794a1211-630b-3ee5-55a3-c06f10df1490@linux.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?GRJDycc7E56XQX+y55P3KR4Xh+gDxgUU+CixhVUhU3tItSIOAmvt0SK8+N2e?=
 =?us-ascii?Q?Jkj8rX9QITLQCXs1pFSLyyLMOEgK61z73gHFq/m+WXZxKmKPG8k3iNKeadLz?=
 =?us-ascii?Q?89nTIxx3Tl9ZN0p+78E6O+l8KejiIRQAj95IILPsBOf7YPjIYSI0tTfwG/qM?=
 =?us-ascii?Q?kTxdk1Tl6wiAg8MahlW6Oxa+WYBMJVogWISJ+0FFG9YOw+3L78dOmhGdn1lw?=
 =?us-ascii?Q?LWDznhFnUlfyi7+xu9q823E1Mzh5faI8XTD1kgqbP5VZplfmp7R35UmcZ1Qu?=
 =?us-ascii?Q?RE8cCHXSGAkVOP/mNui/AfHHjp79D1kRsR3DK3+IAYo4dsgEb8pj5bWCvoCm?=
 =?us-ascii?Q?7A04lOKGe1XdiZEnE5msnihW+hFOuVLiexuP0zMWrQ+OGUR+YcJRNAn3MZXf?=
 =?us-ascii?Q?SpJzu3/d75EfpGaBgaxkL679ZxJWZP0C2VBddf1p2R4QDL3B/0KvBNZV90JT?=
 =?us-ascii?Q?dwy7cZL2tFR4wnkVR4NVf0G9dAPRxbyYrk82oWire5IFWALXNO3F5eEmCQc5?=
 =?us-ascii?Q?dpECjNGDqHwohvmrvXuJeYH4PEYs1gNEi/QD4Lxyagio9KNBRF/h1HEfLUUH?=
 =?us-ascii?Q?fTQ9peoj6V/RJ6JcDJNUw7nheousN3RgNWxm5SXOvg26dD4kxHzE53pLfDa4?=
 =?us-ascii?Q?+XovSyPR7eW69qwCY+xJvFqXpneFcEbUvnYDMQqglWCXPFzlynXofr3x8y5O?=
 =?us-ascii?Q?C4wOrZXBQiNX+f2+hwxFGe42CVBJGVHS2y0iVKCWE49CGxHYjYgpIl9bJ0I0?=
 =?us-ascii?Q?ZKMoPxQN2NYNr9bkOi9r1FwrGhM+rKMsugDFMhGpCOSF1nNciSdZCsDa55X4?=
 =?us-ascii?Q?h4840JfAVZ2zHwykUsISX/bfqiD3pX7SC8d/KoYO+5IMmBc0jVLB7GhB9bnv?=
 =?us-ascii?Q?qznIByTj2V1aZxsLgTAT1pTQ4dZ0vpt+SdCq8xBrtwYA8aokmO6cJC8anIo0?=
 =?us-ascii?Q?uZe3HNfTzrBPao1YOk5p28NGeG+iCkJLP7qObubsHYd8gGpipzxgp15FeszP?=
 =?us-ascii?Q?+ebGP4OU0kt7yq1VXKIXhnhK0DjuvpY9Oi8LDCjapxyQpY4+wQVPgp2yLiT2?=
 =?us-ascii?Q?TmykLmDMew2vUJpNUhEbgjCACN9s2rCY132FobdZ9ZuDPbuli3yxgHw3nhTq?=
 =?us-ascii?Q?cCEb51V0+cT1SX+R5gRKjw8ZlDr8WNSdnoS3dXz0omhKrog8U8k9l+NSEtKK?=
 =?us-ascii?Q?/aLE5GYLZP853XPnj84pmZtPm2qqXe8a6KbsVesZ7bJeftuq9J4irTLyzb4a?=
 =?us-ascii?Q?MAffVKKPF87r+KZzA3CkFm4Pz2l7PPLid3TsV7rHEYM3Xoq/zcczO1sl44j3?=
 =?us-ascii?Q?g4fngwq4bNUSm5Hw9jhTYYo3Qvl5n5RCESGMSBmXye9gb1Wkzgz1pcbtVxU5?=
 =?us-ascii?Q?NPDrpE+c9IhOAZsmrD4QXiq7JMMF7Kgvv52F5RuUXJvlzGZ79YbIMYEyD/Yp?=
 =?us-ascii?Q?BNzqhYIVR2mGm29PjVFdpCugGkFW5p+YxytLgMDgOd03ZNp6mPeGhUmERVkA?=
 =?us-ascii?Q?5dlxYH1HH06OFnQevfBt+gzRElsYMF8gPmMzPehYJGFJot60I1XX/pJUVLv/?=
 =?us-ascii?Q?lwIBiPeAqDYILdVNT8P+TbJvps2MvxvmBU7HPiRjD2/7FXYlzb4jMuUHZWN1?=
 =?us-ascii?Q?fw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	Ih3guDj0hruVSXg5Iyc/0/X3DzP2Ham0r8F1WZTKP3BDCcR+y9PwThwy8tf/s0RzD0j4wrlh3U7MLmxQYYnYzVPW/F3SMXkIBx5eNEQNTTGLLvllwBiwZut++it2ETaGY8wAyKo0oS6q27Gb79WmFYieKsIeE6piC0X/c2uojUZpQDL6+hRs2rVYphV0kxs9ME8f8eXzqKgpT+sDabISpbttHULO528ftZXSeNo0/BtVZILmuw0+7RH0st1dU4sshFdW45FPsrkK6DbTdYTa100Eh+tXMVh5uZkdkq7JviEFknrtnSe8+/MQpk5Yg0DRNoLEMrB2dPfNMPA8U32c+CcI+KYjcNUAtdQGpZcgc3TV7yAb5JpAzCEyTSkOqoLUGiZFlU5L8p7MYkCmz8MTy+nOFxSfseB+SZMJ5QEO2fA+D0IowV/fyBVrXvRrm+F9wloWJejzZoMpbhXd0aa+6r+LciqfHQi/hDpv57LB/4Ak4OYxKA19JrVOScVoGk6nBRHMP9tjR1yTh1OPq0QOKNjbWW656A52+Jehz5tpYGOPU72Vwd0WhbKbgeh/oJIRFK+ndUow14P0FNY+Xxy0MYZEMCuj8Sf7X+rOvWCnai4=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 499943e4-a1d9-47e9-4ba0-08dc1625fa44
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4418.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2024 23:59:14.9007
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: omUphZ8P7PNLvKcM0HAExkXqmAOoYFRMSsayoPO/X33Wia5fI5LPzPP02fXu3wqD3cJVxWYw6MhGGiow4rJzew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB5966
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-15_17,2024-01-15_03,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 adultscore=0 phishscore=0
 suspectscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2401150179
X-Proofpoint-ORIG-GUID: rO7_UyixFxAsGCg8yBEwwIMRBqh3orUA
X-Proofpoint-GUID: rO7_UyixFxAsGCg8yBEwwIMRBqh3orUA

Whitespace issues aside, I have applied the patch on top of kernel 6.1.55 and tested on both a dual-socket Ampere Altra machine with < 256 CPUs, and a dual-socket AmpereOne machine with > 256 CPUs. Works as expected, with all CPUs visible and functional.

>   config NR_CPUS
>   	int "Maximum number of CPUs (2-4096)"
>   	range 2 4096
> - 	default "256"
> + 	default 512

Nit: the new default value should be in quotation marks, if we want to be pedantic

Tested-by: Eric Mackay <eric.mackay@oracle.com>