Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933468AbXLMXn2 (ORCPT ); Thu, 13 Dec 2007 18:43:28 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755704AbXLMXnS (ORCPT ); Thu, 13 Dec 2007 18:43:18 -0500 Received: from nz-out-0506.google.com ([64.233.162.235]:31740 "EHLO nz-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753299AbXLMXnR (ORCPT ); Thu, 13 Dec 2007 18:43:17 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=pJv5USv7WBNmscs4NBY40p8okUmUISaopdeh+AKLgLCHev3CRL/LoEGHf3CEU3Mnh4DwZyJB7j1KHEHlQGBRZ+guE3Kso+UPa01UGE7R5tWA+13ckKdr9MtP3wrAp1GSueEp3bzjBK7CMgq7xo2US7d7dVJ2SX3hnsq/78x4VLE= Message-ID: Date: Thu, 13 Dec 2007 21:43:15 -0200 From: "Mauricio Mauad Menegaz Filho" To: "Andi Kleen" Subject: Re: Print taint info in more places. Cc: "Dave Jones" , "Linux Kernel" In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20071213224927.GA18639@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1230 Lines: 24 2007/12/13, Andi Kleen : > Dave Jones writes: > > > #define WARN_ON(condition) ({ \ > > int __ret_warn_on = !!(condition); \ > > if (unlikely(__ret_warn_on)) { \ > > - printk("WARNING: at %s:%d %s()\n", __FILE__, \ > > - __LINE__, __FUNCTION__); \ > > + printk(KERN_ERR "WARNING: at %s:%d %s() (%s)\n", \ > > + __FILE__, __LINE__, __FUNCTION__, \ > > + print_tainted()); \ > > dump_stack(); \ > > Have you checked how this affects code size? It might be worth it > now to do a out of line helper. > Have you checked how does spotting a bug is worth the extra size sometimes (almost all the time)? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/