Received-SPF: pass (google.com: domain of linux-kernel+bounces-26916-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Feedback-ID: i1f8241ce:Fastmail
Message-ID: <8b31ae29-b88b-4ded-95b4-c2d9bbad24e1@feathertop.org>
Date: Tue, 16 Jan 2024 13:00:15 +1100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] dt-bindings: rockchip: Fix Hardkernel ODROID-M1 board
 bindings
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 KyuHyuk Lee <lee@kyuhyuk.kr>, Rob Herring <robh+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
 Chris Morgan <macromorgan@hotmail.com>, Tianling Shen <cnsztl@gmail.com>,
 Jagan Teki <jagan@edgeble.ai>, Ondrej Jirman <megi@xff.cz>,
 Andy Yan <andyshrk@163.com>, devicetree@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org,
 linux-kernel@vger.kernel.org
References: <20240115145142.6292-1-lee@kyuhyuk.kr>
 <b4f97202-43ec-4f04-af95-b1ccd3b5d203@linaro.org>
From: Tim Lunn <tim@feathertop.org>
In-Reply-To: <b4f97202-43ec-4f04-af95-b1ccd3b5d203@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


On 1/16/24 01:58, Krzysztof Kozlowski wrote:
> On 15/01/2024 15:51, KyuHyuk Lee wrote:
>> The vendor in ODROID-M1 is hardkernel, but it was incorrectly written
>> as rockchip. Fixed the vendor prefix correctly.
>>
>> Signed-off-by: KyuHyuk Lee <lee@kyuhyuk.kr>
>> ---
>>   Documentation/devicetree/bindings/arm/rockchip.yaml | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> You need to start testing your patches. Your last M1 fails as well in
> multiple places.
>
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check W=1` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).
>
> The DTS change will break the users, so would be nice to mention this in
> its commit msg.

I notice there are a couple of other boards that incorrectly use 
rockchip as the vendor also:

           - const: rockchip,rk3399-orangepi
           - const: rockchip,rk3568-bpi-r2pro

Perhaps these should also be fixed at the same time?

Regards
   Tim

>
> Best regards,
> Krzysztof
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip