Received-SPF: pass (google.com: domain of linux-kernel+bounces-26928-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Mon, 15 Jan 2024 21:29:30 -0500
From: Frank Li <Frank.li@nxp.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: robh@kernel.org, alexandre.belloni@bootlin.com,
	conor.culhane@silvaco.com, gregkh@linuxfoundation.org,
	imx@lists.linux.dev, jirislaby@kernel.org, joe@perches.com,
	linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org, miquel.raynal@bootlin.com,
	zbigniew.lukwinski@linux.intel.com, devicetree@vger.kernel.org,
	krzysztof.kozlowski+dt@linaro.org
Subject: Re: [PATCH v2 2/7] dt-bindings: i3c: svc: add compatible string i3c:
 silvaco,i3c-target-v1
Message-ID: <ZaXqCoCHPWER94Hh@lizhi-Precision-Tower-5810>
References: <20240110175221.2335480-1-Frank.Li@nxp.com>
 <20240110175221.2335480-3-Frank.Li@nxp.com>
 <3c0be658-e7a6-4231-b206-86ffb47e0cb2@linaro.org>
 <ZaFbbeQrC7o2dchO@lizhi-Precision-Tower-5810>
 <e3b9aa63-25a5-41cc-9eb7-6e7d1eacb136@linaro.org>
 <ZaFjaWCA6k+tiCSJ@lizhi-Precision-Tower-5810>
 <ZaWLCrWJEMtFx8cR@lizhi-Precision-Tower-5810>
 <1b628901-7f71-4c97-9a16-723912988417@linaro.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1b628901-7f71-4c97-9a16-723912988417@linaro.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?v+dg8t4Kze0OtPR/n4PnPnCmSJUMeQirDgNtouUMpJY0Lc5Jru/ok7/fa44V?=
 =?us-ascii?Q?/xujYBNXWKU6Y/nIBkKirCENFW+Z56GhvlKfifScFGOekpc1YMsgvJ54C8F9?=
 =?us-ascii?Q?2ZoT7SPN9SbUo3GlFXxhJvUNxQsUUczmjR3Cj2vPrDDO61QmsHDlOkf9bSW6?=
 =?us-ascii?Q?GNAb5vaZSQMEk3EVIh+JbjLYnavHwbbmqi8S2qNHSOMkFpwQZ3cmUPkA2YRB?=
 =?us-ascii?Q?X+QmcuEnI2DfUuVMWQ7ILpfC7d6kBh0qA5z2vrj4TaCjAIwUAzPjfrE36j6o?=
 =?us-ascii?Q?4O8CxGOCklTINa4X6OcZHEc1WaDrQaSqNC0VLKmLVEAipPG9qHDFysuimwbP?=
 =?us-ascii?Q?iLcKc+WpbIr/EYjboj3wlV/NLq4TU8jFCweYDMW+WDraLnXGsdMnJXOui3Ix?=
 =?us-ascii?Q?SGZDGZFZz/6DRQtRZsk99Df5wGl8ZpsXkocVOhYUvgzcozWbxJppTEGXf4tF?=
 =?us-ascii?Q?fpG5e9hyhAXB6dgeDO+qkV2Vl/JJyIGI5CxN58FfD0bVog84QaBwAbwQIDuv?=
 =?us-ascii?Q?YUVRHMKSrz/EZ+CsnDnC1MSY5513gUc2Q3lzSz0c+3eM9tVj8wuDAnpEJltQ?=
 =?us-ascii?Q?9zRmgfSQcaO1KF16dYupXBQaHS4+BAzkK1utrKtubFXdmk2ctESxX2IWP6um?=
 =?us-ascii?Q?qDKG6BDx2PraDzcL5Edq5Rmf+IsVwwnq32WViVVqkVQx3R5aOd1CILl99BZg?=
 =?us-ascii?Q?2UQK6yTPXLlFc02okyI7MgwVru9Xy4moFZqGMi4EO9JQ3BOcv+07Y9VbqaWc?=
 =?us-ascii?Q?ehLVLST62kxlnPGOSfq+oT9TNZmSCw3SYKxIrCnTKmemOe5vuTeb43NbFKvr?=
 =?us-ascii?Q?SZVvom9kQEKTndQ+6S0i41Pe4WXtqMP37mWo4jOVmZwLRpwX7RMXAKAVZfTt?=
 =?us-ascii?Q?tpG0wnqs3J9kt12BpLU4akgWTxxKaX06b+CHFR+MwfeSQOaQsXla4RwzybHQ?=
 =?us-ascii?Q?2XJD8mM4TPTOqxudFXNEF/iJxcdMVP9A2tOS7l00eUOH5jv/x/7kQx5jOqpk?=
 =?us-ascii?Q?0BQ5LWuw4+uIFJPAYNK8jxDxZR6S1u7EGE/dXlBLV47LW0PgF3thSfnz3zvh?=
 =?us-ascii?Q?qjOPeWS4b3u7kCjx6A0zYzK2HrpazFks/MbOLpFzo/3gROo2VoxtT0RhhOQ2?=
 =?us-ascii?Q?LtPfAr2E+2zTAxqoXYpNXTTLrpQsG1tpflMSHzQ2bYed2bERnSeO0mI6qVYI?=
 =?us-ascii?Q?rsS3hH0O9WrufLn3CJTOtX4sXVLVB6GYZoAHjEr+YIUzp+wHfQ5fltaP7isV?=
 =?us-ascii?Q?VTA5K7R3VW/R6eczAj9yNN/WXhJ3YoEiYes4XIyJc+a1f93njbcJ0pIJZ5G3?=
 =?us-ascii?Q?cpJoB1eq1SWdjFEnl5QcRfKxp5RF3EFa74VtyowEIXtsi9fV7S1GvweX6v1j?=
 =?us-ascii?Q?JztNYAGJGoze5VqhcjqyUPHsP79bGRSlvlKzA3no1pb1D16g7GlqcxheIzmP?=
 =?us-ascii?Q?ni9XvEAqBAA/q5jPKNz1HDzYhUdaxYdF3n9RGM8Fnzdhuu/fd6iRzGmm6E1s?=
 =?us-ascii?Q?2X04ZVRfhRhUG7ACDubsRqTDJxA0fEnxL7eOex/eEW3kZNcJFonBQ0mz+vrJ?=
 =?us-ascii?Q?yFwbVoiC4UHXAyNSPIA=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7936bdae-6a03-4e5d-5b14-08dc163afcc6
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2024 02:29:38.9107
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NxwbgTsNmMvOxZh2gGrSvCYynThZfPSyd7XQjPvPv4EfGDc775MQm5MxXC2DEJLWU5BYdNtHZEicgREvYkvpTQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9418

On Mon, Jan 15, 2024 at 09:38:19PM +0100, Krzysztof Kozlowski wrote:
> On 15/01/2024 20:44, Frank Li wrote:
> > On Fri, Jan 12, 2024 at 11:06:01AM -0500, Frank Li wrote:
> >> On Fri, Jan 12, 2024 at 04:50:25PM +0100, Krzysztof Kozlowski wrote:
> >>> On 12/01/2024 16:31, Frank Li wrote:
> >>>> I review previous comments. The previous RFC patches and I just want I3C
> >>>> expert review to check if there are comments about whole software
> >>>> architecture. Of course, thank you for your comments about "slave".
> >>>>
> >>>> Go back this binding doc problem. 
> >>>>
> >>>>   "No, it's the same device.
> >>>>
> >>>>    Anyway, this was not tested.
> >>>>
> >>>>    Please use scripts/get_maintainers.pl to get a list of necessary people
> >>>>    and lists to CC. It might happen, that command when run on an older
> >>>>    kernel, gives you outdated entries. Therefore please be sure you base
> >>>>    your patches on recent Linux kernel.
> >>>>
> >>>>    You missed at least devicetree list (maybe more), so this won't be
> >>>>    tested by automated tooling. Performing review on untested code might be
> >>>>    a waste of time, thus I will skip this patch entirely till you follow
> >>>>    the process allowing the patch to be tested.
> >>>>
> >>>>    Please kindly resend and include all necessary To/Cc entries.
> >>>>    "
> >>>>
> >>>> It is the same devices, work at difference mode (master  and target).
> >>>> what's do you want to change to?
> >>>>
> >>>> Copy to new file like pci/pci-ep? all context is the same, except for
> >>>> compatible string. 
> >>>>
> >>>
> >>> Apologies, I mixed up a bit patches, so this was not obvious. I meant
> >>> this comment:
> >>>
> >>> https://lore.kernel.org/all/20231017201404.GA2570433-robh@kernel.org/
> >>>
> >>> There is no indication in your commit msg that these concerns were
> >>> addressed.
> >>
> >> Look like everyone already accecpted 'silvaco,i3c-master-v1'.
> >>
> >> driver part:
> >> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=8911eae9c8a947e5c1cc4fcce40473f1f5e475cd
> >> dts part:
> >> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=b8ec0f3b42a3498d5115d1fb1490082ab525747b
> > 
> > @Krzysztof:
> > 	Patches were accepted after discussion, what you ponit to. So I
> > think everyone agree on the name 'silvaco,i3c-master-v1'.
> > 	I plan send next version to fix auto build error. Any additional
> > comments about this?
> 
> I still do not see how did you address Rob's comment and his point is
> valid. You just did not reply to it.

See https://lore.kernel.org/imx/ZXCiaKfMYYShoiXK@lizhi-Precision-Tower-5810/

Frank

> 
> Best regards,
> Krzysztof
>