Received-SPF: pass (google.com: domain of linux-kernel+bounces-26931-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Content-Type: text/plain;
	charset=us-ascii
Precedence: bulk
Mime-Version: 1.0
Subject: Re: [PATCH v2] fs/hugetlbfs/inode.c: mm/memory-failure.c: fix
 hugetlbfs hwpoison handling
From: Muchun Song <muchun.song@linux.dev>
In-Reply-To: <20240112180840.367006-1-sidhartha.kumar@oracle.com>
Date: Tue, 16 Jan 2024 10:43:00 +0800
Cc: LKML <linux-kernel@vger.kernel.org>,
 Linux-MM <linux-mm@kvack.org>,
 Andrew Morton <akpm@linux-foundation.org>,
 usama.anjum@collabora.com,
 Jiaqi Yan <jiaqiyan@google.com>,
 "Matthew Wilcox (Oracle)" <willy@infradead.org>,
 Miaohe Lin <linmiaohe@huawei.com>,
 Naoya Horiguchi <naoya.horiguchi@nec.com>,
 Yang Shi <shy828301@gmail.com>,
 James Houghton <jthoughton@google.com>,
 jane.chu@oracle.com,
 stable@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <1D4F7C82-92BA-4EFC-A082-B5FE30758E91@linux.dev>
References: <20240112180840.367006-1-sidhartha.kumar@oracle.com>
To: Sidhartha Kumar <sidhartha.kumar@oracle.com>


> On Jan 13, 2024, at 02:08, Sidhartha Kumar =
<sidhartha.kumar@oracle.com> wrote:
>=20
> has_extra_refcount() makes the assumption that the page cache adds a =
ref
> count of 1 and subtracts this in the extra_pins case. Commit =
a08c7193e4f1
> (mm/filemap: remove hugetlb special casing in filemap.c) modifies
> __filemap_add_folio() by calling folio_ref_add(folio, nr); for all =
cases
> (including hugtetlb) where nr is the number of pages in the folio. We
> should adjust the number of references coming from the page cache by
> subtracing the number of pages rather than 1.
>=20
> In hugetlbfs_read_iter(), folio_test_has_hwpoisoned() is testing the =
wrong
> flag as, in the hugetlb case, memory-failure code calls
> folio_test_set_hwpoison() to indicate poison. folio_test_hwpoison() is =
the
> correct function to test for that flag.
>=20
> After these fixes, the hugetlb hwpoison read selftest passes all =
cases.
>=20
> Fixes: a08c7193e4f1 ("mm/filemap: remove hugetlb special casing in =
filemap.c")
> Closes: =
https://lore.kernel.org/linux-mm/20230713001833.3778937-1-jiaqiyan@google.=
com/T/#m8e1469119e5b831bbd05d495f96b842e4a1c5519
> Cc: <stable@vger.kernel.org> # 6.7+
> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
> Reported-by: Muhammad Usama Anjum <usama.anjum@collabora.com>

Acked-by: Muchun Song <muchun.song@linux.dev>

Thanks.