Received: by 2002:a05:7412:8d09:b0:fa:4c10:6cad with SMTP id bj9csp243188rdb; Mon, 15 Jan 2024 20:57:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IFis+XRDDA36Vxb/ouQmz0JC/Yj9Te4ELhvtI1EQvG5RgiecY3zbbqV4A79RxA4BOPpgPQa X-Received: by 2002:ac8:7d02:0:b0:429:e764:e561 with SMTP id g2-20020ac87d02000000b00429e764e561mr4851164qtb.52.1705381056554; Mon, 15 Jan 2024 20:57:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705381056; cv=none; d=google.com; s=arc-20160816; b=PKfIkZ39S/dyyDVc+4lyS74GuGTDHQrV6Q362LzZeThNp0P+/z8czlytCYELBR0ps0 WMfBgnUDor66m/D8daW8hfYDylvP2oCl+21a35efJqYXBaZLeoo13396f45CV15MnqGe 1/7BShBbM1TYPBJRuHhfnJy9dMdFxz1ZHMGg7U+YQXwt6MBoigqeR0fv66aOUTQE1A9C yc9JrlumEwqqLhKMX/2yGU47aBTTzOrUgopCgVg/1zeufGSoe+b+0puMsYzrCRpCyCez cIuUCgz7SudywFgn0E+h6hP8reWS+yu1B+wJJRDP0r7Mnt4BgM9IOl2hBB/7drhGVhvA Lk2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=U2XA2OAgI/6k5jcvtQF+oa4XtOzEHDhjNpKX1DHzuDM=; fh=1qJ2I/Yw8x7USMJXsluaV+7jwsDIKHnKiLkByuJq1Ro=; b=eyKWkByWzst9mI8RwPpG1wDho9sm3Xkq6RhBJz/S0Ei1ciovX06hDifVK04MHro7DE fBx0lkC37yk/7XzjNKwc9A469rb3s8cctCdz1OvuXypGQSBdIA93l9PD2zFsc6skQpz8 ldhoD389xeczROouVGz7uuSHLJuGUQYishH2LGCQIQvYTopXpug4t2khujsF8LAKsNsW wORgpRJURQXUxj64nPR6qQVeHe4iZwEnMOyz7g2RUo5FThO+7wdvZbdEgDDZ0i/jkvl/ SXA/AgdWT8yRh0wKeTqp9PzoSFhYa+9KU63Md7dJ2u41Rr7K/6YqriQEvlrnKphIwVDu O6aQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-26977-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-26977-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=fujitsu.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id b2-20020a05622a020200b0042977560a47si9292003qtx.340.2024.01.15.20.57.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jan 2024 20:57:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-26977-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-26977-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-26977-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=fujitsu.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 524651C22A68 for ; Tue, 16 Jan 2024 04:57:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2367A1BDDB; Tue, 16 Jan 2024 04:52:34 +0000 (UTC) Received: from esa7.hc1455-7.c3s2.iphmx.com (esa7.hc1455-7.c3s2.iphmx.com [139.138.61.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA5A71947C; Tue, 16 Jan 2024 04:52:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fujitsu.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fujitsu.com X-IronPort-AV: E=McAfee;i="6600,9927,10954"; a="125018782" X-IronPort-AV: E=Sophos;i="6.04,198,1695654000"; d="scan'208";a="125018782" Received: from unknown (HELO oym-r1.gw.nic.fujitsu.com) ([210.162.30.89]) by esa7.hc1455-7.c3s2.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jan 2024 13:52:27 +0900 Received: from oym-m3.gw.nic.fujitsu.com (oym-nat-oym-m3.gw.nic.fujitsu.com [192.168.87.60]) by oym-r1.gw.nic.fujitsu.com (Postfix) with ESMTP id C7512E8BF5; Tue, 16 Jan 2024 13:52:25 +0900 (JST) Received: from kws-ab3.gw.nic.fujitsu.com (kws-ab3.gw.nic.fujitsu.com [192.51.206.21]) by oym-m3.gw.nic.fujitsu.com (Postfix) with ESMTP id F346CD948C; Tue, 16 Jan 2024 13:52:24 +0900 (JST) Received: from edo.cn.fujitsu.com (edo.cn.fujitsu.com [10.167.33.5]) by kws-ab3.gw.nic.fujitsu.com (Postfix) with ESMTP id 8870E200A7687; Tue, 16 Jan 2024 13:52:24 +0900 (JST) Received: from localhost.localdomain (unknown [10.167.226.45]) by edo.cn.fujitsu.com (Postfix) with ESMTP id 1C5441A0070; Tue, 16 Jan 2024 12:52:24 +0800 (CST) From: Li Zhijian To: linux-kernel@vger.kernel.org Cc: Li Zhijian , "James E.J. Bottomley" , linux-scsi@vger.kernel.org Subject: [PATCH 33/42] drivers/scsi/pcmcia/sym53c500_cs: Convert snprintf to sysfs_emit Date: Tue, 16 Jan 2024 12:51:42 +0800 Message-Id: <20240116045151.3940401-31-lizhijian@fujitsu.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20240116045151.3940401-1-lizhijian@fujitsu.com> References: <20240116041129.3937800-1-lizhijian@fujitsu.com> <20240116045151.3940401-1-lizhijian@fujitsu.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-TM-AS-Product-Ver: IMSS-9.1.0.1417-9.0.0.1002-28122.004 X-TM-AS-User-Approved-Sender: Yes X-TMASE-Version: IMSS-9.1.0.1417-9.0.1002-28122.004 X-TMASE-Result: 10--5.340000-10.000000 X-TMASE-MatchedRID: CncXHiplHCc4ibokZ3+Q0CoiRKlBVkYIBXngI6jFvpfvd49YGReckE1N J2MN+nPkgxCMf8A0YpR5sRK06wHV4TBF7stuNMMxTuctSpiuWyUUi4Ehat0546MQi364g884JmV 7j1WQqodAYdLFXr37PhAISLmT6dDEHxPMjOKY7A/+HHE8LDNSg8RB0bsfrpPIfiAqrjYtFiQ67M DzwA1xIzCSmoDF4fl0mz1os8fbBNeZBJZQJRLtsX7cGd19dSFd X-TMASE-SNAP-Result: 1.821001.0001-0-1-22:0,33:0,34:0-0 Per filesystems/sysfs.rst, show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. coccinelle complains that there are still a couple of functions that use snprintf(). Convert them to sysfs_emit(). > ./drivers/scsi/pcmcia/sym53c500_cs.c:627:8-16: WARNING: please use sysfs_emit No functional change intended CC: "James E.J. Bottomley" CC: linux-scsi@vger.kernel.org Signed-off-by: Li Zhijian --- drivers/scsi/pcmcia/sym53c500_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/pcmcia/sym53c500_cs.c b/drivers/scsi/pcmcia/sym53c500_cs.c index 278c78d066c4..264eeb24b811 100644 --- a/drivers/scsi/pcmcia/sym53c500_cs.c +++ b/drivers/scsi/pcmcia/sym53c500_cs.c @@ -624,7 +624,7 @@ SYM53C500_show_pio(struct device *dev, struct device_attribute *attr, struct sym53c500_data *data = (struct sym53c500_data *)SHp->hostdata; - return snprintf(buf, 4, "%d\n", data->fast_pio); + return sysfs_emit(buf, "%d\n", data->fast_pio); } static ssize_t -- 2.29.2